From d48d0034ef5ab37482f75432d88ddf54e992939e Mon Sep 17 00:00:00 2001 From: Craig Date: Sun, 30 Jun 2019 13:47:00 +1200 Subject: [PATCH 01/17] changed version numbers, started working on the release notes. --- README.md | 2 +- configure.ac | 2 +- doc/Doxyfile | 2 +- doc/README.md | 2 +- doc/README_windows.txt | 2 +- doc/release-notes/release-notes-4.7.0.md | 92 ++++++++++++++++++++++++ 6 files changed, 97 insertions(+), 5 deletions(-) create mode 100644 doc/release-notes/release-notes-4.7.0.md diff --git a/README.md b/README.md index ee7af894a..b82ce5c9c 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ ![NavCoin](./img/logo-extended.png) -This is the working repository for NavCoin 4.6.0, our fork of bitcoin-core 0.13. +This is the working repository for NavCoin 4.7.0, our fork of bitcoin-core 0.13. For more information please visit the website: diff --git a/configure.ac b/configure.ac index 3f3991620..462644976 100644 --- a/configure.ac +++ b/configure.ac @@ -1,7 +1,7 @@ dnl require autoconf 2.60 (AS_ECHO/AS_ECHO_N) AC_PREREQ([2.60]) define(_CLIENT_VERSION_MAJOR, 4) -define(_CLIENT_VERSION_MINOR, 6) +define(_CLIENT_VERSION_MINOR, 7) define(_CLIENT_VERSION_REVISION, 0) define(_CLIENT_VERSION_BUILD, 0) define(_CLIENT_VERSION_IS_RELEASE, true) diff --git a/doc/Doxyfile b/doc/Doxyfile index 325d24cdb..3b8e1fb8f 100755 --- a/doc/Doxyfile +++ b/doc/Doxyfile @@ -34,7 +34,7 @@ PROJECT_NAME = NavCoin # This could be handy for archiving the generated documentation or # if some version control system is used. -PROJECT_NUMBER = 4.6.0 +PROJECT_NUMBER = 4.7.0 # Using the PROJECT_BRIEF tag one can provide an optional one line description # for a project that appears at the top of each page and should give viewer diff --git a/doc/README.md b/doc/README.md index ddf298adb..ec0423a16 100644 --- a/doc/README.md +++ b/doc/README.md @@ -1,4 +1,4 @@ -NavCoin Core 4.6.0 +NavCoin Core 4.7.0 ===================== Setup diff --git a/doc/README_windows.txt b/doc/README_windows.txt index a5c844857..0bae73fe2 100755 --- a/doc/README_windows.txt +++ b/doc/README_windows.txt @@ -1,4 +1,4 @@ -NavCoin Core 4.6.0 +NavCoin Core 4.7.0 ===================== Intro diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md new file mode 100644 index 000000000..0a84c4db2 --- /dev/null +++ b/doc/release-notes/release-notes-4.7.0.md @@ -0,0 +1,92 @@ +# NavCoin v4.6.0 Release Notes + +## Community Fund UI + +<[Pull Request 428](https://github.com/NAVCoin/navcoin-core/pull/428)> +<[Commit cbffaee](https://github.com/NAVCoin/navcoin-core/commit/cbffaeee68d649069e0964b4930d04c441a7b63c)> + +- Added a Community Fund tab to the core wallet +- Ability to view and filter proposals and payment request +- Proposals and payment requests can be voted on and created +- Removed the old Community Fund UI + +## Accumulation of staking rewards in different address + +<[Pull Request 401](https://github.com/NAVCoin/navcoin-core/pull/401)> +<[Commit 2fb7b47](https://github.com/NAVCoin/navcoin-core/commit/2fb7b47625dfe866f6079d8c7ac8c1dfb9f9de1d)> +This features introduces support for the `-stakingaddress` launch argument which sets a NavCoin address where the staking rewards are accumulated. It also allows you to specify mappings from one address to another, such that the first address's staking rewards will be deposited in the second address. + +`stakingaddress` can take: +- one argument (i.e. one NavCoin address), e.g. `-stakingaddress=NxxxxMyNavCoinAddressxxxxxxxxxxxxx`; or +- a JSON argument, mapping several staking addresses to corresponding receiving addresses, e.g. `-stakingaddress={"NxxxxMyStakingAddress1xxxxxxxxxxxx":"NxxxxMyReceivingAddress1xxxxxxxxxx","NxxxxMyStakingAddress2xxxxxxxxxxxx":"NxxxxMyReceivingAddress2xxxxxxxxxx","NxxxxMyStakingAddress3xxxxxxxxxxxx":"NxxxxMyReceivingAddress3xxxxxxxxxx"}`. One staking address in the JSON argument can also be set to `all` and stakes from any staking address will be sent to the receiving address unless otherwise specified, e.g. `-stakingaddress={"all":"NxxxxMyReceivingAddressALLxxxxxxxx",...}` + +Not compatible with cold staking. + +## Mnemonic seed phrase support + +<[Pull Request 400](https://github.com/NAVCoin/navcoin-core/pull/400)> +<[Commit 375c657](https://github.com/NAVCoin/navcoin-core/commit/375c657337c33c56a6b97350ba886bce9ba60c7c)> +This PR adds a new RPC command to export the existing master private key encoded as a mnemonic: +`dumpmnemonic` It admits an argument specifying the language. +Support for two new wallet options (`-importmnemonic` and `-mnemoniclanguage`) have also been added to allow to create a new wallet from the specified mnemonic. + +## Fix wrong balance after orphan stakes +<[Pull Request 438](https://github.com/NAVCoin/navcoin-core/pull/438)> +<[Commit 4041e3e](https://github.com/NAVCoin/navcoin-core/commit/4041e3ef5de672c6d4e6a20ce5b7f22df090ed14)> +This PR fixes an historical issue which made the wallet show a wrong balance after orphan stakes. + +## Index cold staking address unspent output by spending address +<[Pull Request 434](https://github.com/NAVCoin/navcoin-core/pull/434)> +<[Commit 404d85f](https://github.com/NAVCoin/navcoin-core/commit/404d85f8ea65bf764d3fa681a4d1483c3e72c507)> + +When running a node with -addressindex=1 executing the RPC command “getaddressutxos” with the spending pubkeyhash of a cold staking address will now return any utxo’s available to spend by that key including those where the pubkeyhash is the spending key of a coldstaking transaction. Previously only regular utxo’s sent directly to that pubkeyhash were returned. + +## Fix for Payment Request reorganizations +<[Pull Request 456](https://github.com/NAVCoin/navcoin-core/pull/456)> +<[Commit 688bf4d](https://github.com/NAVCoin/navcoin-core/commit/688bf4d808ca5b5d3d08fef00d085397bb5b47f0)> + +This PR prevents payment requests with invalid hashes (not set yet or out of the main chain) to count for the already requested balance of a proposal. + +## Full List of merged pull requests + +- Build: Compatibility with boost 1.67 <[Pull Request 470](https://github.com/navcoin/navcoin-core/pull/470)> <[Commit 47ac15f](https://github.com/navcoin/navcoin-core/commit/47ac15f2fd8caa8ec15455be9742f8a897c13c49)> +- Adds OP_POOL to scripts <[Pull Request 464](https://github.com/navcoin/navcoin-core/pull/464)> <[Commit 0c57840](https://github.com/navcoin/navcoin-core/commit/0c578405233834a3b300666987cb8c3d2dd40f3b)> +- Added a short bash command for dependencies to build-unix.md <[Pull Request 452](https://github.com/navcoin/navcoin-core/pull/452)> <[Commit ddba46d](https://github.com/navcoin/navcoin-core/commit/ddba46d4f92b152a361e8783cd3e8f3d1b4fa41b)> +- Added the NavCoin Knowledge Base menu item <[Pull Request 454](https://github.com/navcoin/navcoin-core/pull/454)> <[Commit c9a1802](https://github.com/navcoin/navcoin-core/commit/c9a1802c1674b2e0014045b246818e3d4a77ad4a)> +- Currency Change now updates staking info as well <[Pull Request 453](https://github.com/navcoin/navcoin-core/pull/453)> <[Commit 4df0766](https://github.com/navcoin/navcoin-core/commit/4df0766fa8a34b928f8680d25b4928f5764288e2)> +- Removed some autogenerated files by QT <[Pull Request 462](https://github.com/navcoin/navcoin-core/pull/462)> <[Commit 8a638e9](https://github.com/navcoin/navcoin-core/commit/8a638e9edecf1ee7a2d571139eaa3f8fbc1eadfd)> +- Update copyright year and wallet version in clienversion.h <[Pull Request 475](https://github.com/navcoin/navcoin-core/pull/475)> <[Commit f00efb3](https://github.com/navcoin/navcoin-core/commit/f00efb3c4d4c3437ccccdb168fb1d43e68a9de66)> +- Added password prompt for CFund payment/proposal dialogs <[Pull Request 474](https://github.com/navcoin/navcoin-core/pull/474)> <[Commit aa4bbaa](https://github.com/navcoin/navcoin-core/commit/aa4bbaaf7a82600775065f6bab894f78583b9784)> +- Added new details for getstakinginfo error message <[Pull Request 472](https://github.com/navcoin/navcoin-core/pull/472)> <[Commit 4a62021](https://github.com/navcoin/navcoin-core/commit/4a620216be20493225267b6a6ef9c8d21f11a5e7)> +- Updated all references to old Repo Address for NavCoin github current url <[Pull Request 463](https://github.com/navcoin/navcoin-core/pull/463)> <[Commit f31382f](https://github.com/navcoin/navcoin-core/commit/f31382f824385c40e90c3ad10d4bca9655ce98df)> +- Updated the navcoin.ico file to use new art <[Pull Request 489](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit e9275a0](https://github.com/navcoin/navcoin-core/commit/e9275a00ef80ece414539ca9d29569bc20294dc6)> +- Updated navcoin.icns file with new assets <[Pull Request 493](https://github.com/navcoin/navcoin-core/pull/493)> <[Commit 342e29b](https://github.com/navcoin/navcoin-core/commit/342e29b5d99aa42bbf3ae71f8ff92a1a843182d1)> +- Updated other ico files <[Pull Request 492](https://github.com/navcoin/navcoin-core/pull/492)> <[Commit 926c49a](https://github.com/navcoin/navcoin-core/commit/926c49a273189277afad6a3fa9f91be060682b3c)> +- Fix for importaddress returning incorrect amounts <[Pull Request 479](https://github.com/navcoin/navcoin-core/pull/479)> <[Commit b115c2d](https://github.com/navcoin/navcoin-core/commit/b115c2dd495dc28a87957b4104afe8cf78171b7a)> +- Added editorconfig file <[Pull Request 497](https://github.com/navcoin/navcoin-core/pull/497)> <[Commit f501b18](https://github.com/navcoin/navcoin-core/commit/f501b184662ea4ab8e7d0365df01ae094dcd4ecb)> +- Fix for Coin Control "sorting" bug <[Pull Request 461](https://github.com/navcoin/navcoin-core/pull/461)> <[Commit a4c8eb6](https://github.com/navcoin/navcoin-core/commit/a4c8eb6e670f701ba4401fce161ccae64f174486)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> \ No newline at end of file From 6f40f248a9f42b12d42d9572759cbf4d6e3b6737 Mon Sep 17 00:00:00 2001 From: Craig Date: Sun, 30 Jun 2019 13:48:24 +1200 Subject: [PATCH 02/17] added vscode workspace file to gitignore --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 8da0d78ab..4acd6b8c0 100644 --- a/.gitignore +++ b/.gitignore @@ -139,3 +139,5 @@ ui_*.h *.cflags *.cxxflags *.creator.* + +navcoin-core\.code-workspace From 9b5665e424e46fb63b05d1c026f02abfef8c9b4b Mon Sep 17 00:00:00 2001 From: Craig Date: Sun, 30 Jun 2019 13:58:27 +1200 Subject: [PATCH 03/17] more PR's added --- doc/release-notes/release-notes-4.7.0.md | 77 ++++++------------------ 1 file changed, 19 insertions(+), 58 deletions(-) diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index 0a84c4db2..da87f6d60 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -1,51 +1,12 @@ -# NavCoin v4.6.0 Release Notes +# NavCoin v4.7.0 Release Notes -## Community Fund UI +## Description of major feature -<[Pull Request 428](https://github.com/NAVCoin/navcoin-core/pull/428)> -<[Commit cbffaee](https://github.com/NAVCoin/navcoin-core/commit/cbffaeee68d649069e0964b4930d04c441a7b63c)> +<[Pull Request XXX](https://github.com/NAVCoin/navcoin-core/pull/XXX)> +<[Commit XXX](https://github.com/NAVCoin/navcoin-core/commit/XXX)> -- Added a Community Fund tab to the core wallet -- Ability to view and filter proposals and payment request -- Proposals and payment requests can be voted on and created -- Removed the old Community Fund UI - -## Accumulation of staking rewards in different address - -<[Pull Request 401](https://github.com/NAVCoin/navcoin-core/pull/401)> -<[Commit 2fb7b47](https://github.com/NAVCoin/navcoin-core/commit/2fb7b47625dfe866f6079d8c7ac8c1dfb9f9de1d)> -This features introduces support for the `-stakingaddress` launch argument which sets a NavCoin address where the staking rewards are accumulated. It also allows you to specify mappings from one address to another, such that the first address's staking rewards will be deposited in the second address. - -`stakingaddress` can take: -- one argument (i.e. one NavCoin address), e.g. `-stakingaddress=NxxxxMyNavCoinAddressxxxxxxxxxxxxx`; or -- a JSON argument, mapping several staking addresses to corresponding receiving addresses, e.g. `-stakingaddress={"NxxxxMyStakingAddress1xxxxxxxxxxxx":"NxxxxMyReceivingAddress1xxxxxxxxxx","NxxxxMyStakingAddress2xxxxxxxxxxxx":"NxxxxMyReceivingAddress2xxxxxxxxxx","NxxxxMyStakingAddress3xxxxxxxxxxxx":"NxxxxMyReceivingAddress3xxxxxxxxxx"}`. One staking address in the JSON argument can also be set to `all` and stakes from any staking address will be sent to the receiving address unless otherwise specified, e.g. `-stakingaddress={"all":"NxxxxMyReceivingAddressALLxxxxxxxx",...}` - -Not compatible with cold staking. - -## Mnemonic seed phrase support - -<[Pull Request 400](https://github.com/NAVCoin/navcoin-core/pull/400)> -<[Commit 375c657](https://github.com/NAVCoin/navcoin-core/commit/375c657337c33c56a6b97350ba886bce9ba60c7c)> -This PR adds a new RPC command to export the existing master private key encoded as a mnemonic: -`dumpmnemonic` It admits an argument specifying the language. -Support for two new wallet options (`-importmnemonic` and `-mnemoniclanguage`) have also been added to allow to create a new wallet from the specified mnemonic. - -## Fix wrong balance after orphan stakes -<[Pull Request 438](https://github.com/NAVCoin/navcoin-core/pull/438)> -<[Commit 4041e3e](https://github.com/NAVCoin/navcoin-core/commit/4041e3ef5de672c6d4e6a20ce5b7f22df090ed14)> -This PR fixes an historical issue which made the wallet show a wrong balance after orphan stakes. - -## Index cold staking address unspent output by spending address -<[Pull Request 434](https://github.com/NAVCoin/navcoin-core/pull/434)> -<[Commit 404d85f](https://github.com/NAVCoin/navcoin-core/commit/404d85f8ea65bf764d3fa681a4d1483c3e72c507)> - -When running a node with -addressindex=1 executing the RPC command “getaddressutxos” with the spending pubkeyhash of a cold staking address will now return any utxo’s available to spend by that key including those where the pubkeyhash is the spending key of a coldstaking transaction. Previously only regular utxo’s sent directly to that pubkeyhash were returned. - -## Fix for Payment Request reorganizations -<[Pull Request 456](https://github.com/NAVCoin/navcoin-core/pull/456)> -<[Commit 688bf4d](https://github.com/NAVCoin/navcoin-core/commit/688bf4d808ca5b5d3d08fef00d085397bb5b47f0)> - -This PR prevents payment requests with invalid hashes (not set yet or out of the main chain) to count for the already requested balance of a proposal. +- list of features +- list of features ## Full List of merged pull requests @@ -65,19 +26,19 @@ This PR prevents payment requests with invalid hashes (not set yet or out of the - Fix for importaddress returning incorrect amounts <[Pull Request 479](https://github.com/navcoin/navcoin-core/pull/479)> <[Commit b115c2d](https://github.com/navcoin/navcoin-core/commit/b115c2dd495dc28a87957b4104afe8cf78171b7a)> - Added editorconfig file <[Pull Request 497](https://github.com/navcoin/navcoin-core/pull/497)> <[Commit f501b18](https://github.com/navcoin/navcoin-core/commit/f501b184662ea4ab8e7d0365df01ae094dcd4ecb)> - Fix for Coin Control "sorting" bug <[Pull Request 461](https://github.com/navcoin/navcoin-core/pull/461)> <[Commit a4c8eb6](https://github.com/navcoin/navcoin-core/commit/a4c8eb6e670f701ba4401fce161ccae64f174486)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> +- Use of the CoinsDB for the Community Fund <[Pull Request 487](https://github.com/navcoin/navcoin-core/pull/487)> <[Commit a8f425b](https://github.com/navcoin/navcoin-core/commit/a8f425b9bd86147693c1e79427c39876425ac7cf)> +- TX_POOL missing in switch condition in the IsMine function <[Pull Request 500](https://github.com/navcoin/navcoin-core/pull/500)> <[Commit 498e75f](https://github.com/navcoin/navcoin-core/commit/498e75f2b915bf5d8fccc10c1080ed68b478fceb)> +- Fixed some file permissions <[Pull Request 502](https://github.com/navcoin/navcoin-core/pull/502)> <[Commit 7fac091](https://github.com/navcoin/navcoin-core/commit/7fac091ff95382c44544aa4c8d23109c370a9bd1)> +- Added error log tab in debug window <[Pull Request 466](https://github.com/navcoin/navcoin-core/pull/466)> <[Commit bed76b9](https://github.com/navcoin/navcoin-core/commit/bed76b917b6590148a371d5a3d86d2a534ef1f3b)> +- Fix RPC Tests <[Pull Request 480](https://github.com/navcoin/navcoin-core/pull/480)> <[Commit c2855a7](https://github.com/navcoin/navcoin-core/commit/c2855a73c8f4ea6395c440bc65d5fff2ab1cfeb3)> +- Fixed a bug with the errorLogFile causing crashes <[Pull Request 507](https://github.com/navcoin/navcoin-core/pull/507)> <[Commit 9f40cbd](https://github.com/navcoin/navcoin-core/commit/9f40cbd071f4c68efc70182133ab2d094823226d)> +- Prevent segfault on gui close <[Pull Request 505](https://github.com/navcoin/navcoin-core/pull/505)> <[Commit d4b23bf](https://github.com/navcoin/navcoin-core/commit/d4b23bf13033b7603b62ba6bb6d5e8ca387ba3d3)> +- Remove Bootstrap option from GUI <[Pull Request 512](https://github.com/navcoin/navcoin-core/pull/512)> <[Commit 79624cf](https://github.com/navcoin/navcoin-core/commit/79624cfc0806a1cf46e0ab02b8b351f339c2c146)> +- Use `-rescan` when `-importmnemonic` <[Pull Request 494](https://github.com/navcoin/navcoin-core/pull/494)> <[Commit e061768](https://github.com/navcoin/navcoin-core/commit/e0617681629779afa10224c92e9b45713b54b410)> +- Creates default config file <[Pull Request 504](https://github.com/navcoin/navcoin-core/pull/504)> <[Commit 940c669](https://github.com/navcoin/navcoin-core/commit/940c669b9a717b9bb82fe5f2acbf9f9457a6e8f2)> +- Changes required for GLIBC backward compatibility with gitian builds <[Pull Request 501](https://github.com/navcoin/navcoin-core/pull/501)> <[Commit d3b5687](https://github.com/navcoin/navcoin-core/commit/d3b56870eba55fbd2a0e323af6651f47d31e8b64)> +- Fix potential deadlock <[Pull Request 506](https://github.com/navcoin/navcoin-core/pull/506)> <[Commit de6e167](https://github.com/navcoin/navcoin-core/commit/de6e167511381b5259d58518a69a48ea72417071)> +- Moved the checkboxes into the empty QGroupBox <[Pull Request 484](https://github.com/navcoin/navcoin-core/pull/484)> <[Commit 4fb8043](https://github.com/navcoin/navcoin-core/commit/4fb8043f068fae1814ff76049a45f237b4df6f8e)> - title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> - title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> - title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> From 9fc50786a9cc7f82dc7714106fa3ef9664dd828c Mon Sep 17 00:00:00 2001 From: Craig Date: Sun, 30 Jun 2019 17:17:05 +1200 Subject: [PATCH 04/17] release notes done apart from #544 when it gets merged. --- doc/release-notes/release-notes-4.7.0.md | 67 ++++++++++++++++++------ 1 file changed, 51 insertions(+), 16 deletions(-) diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index da87f6d60..4d434cfd6 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -1,12 +1,48 @@ # NavCoin v4.7.0 Release Notes -## Description of major feature +## Added password prompt for CFund payment/proposal dialogs -<[Pull Request XXX](https://github.com/NAVCoin/navcoin-core/pull/XXX)> +<[Pull Request 474](https://github.com/NAVCoin/navcoin-core/pull/474)> +<[Commit aa4bbaa](https://github.com/navcoin/navcoin-core/commit/aa4bbaaf7a82600775065f6bab894f78583b9784)> + +Peviously you would have to unlock the wallet via the console or debug window before it was possible to create a proposal or payment request through the graphical interface. Now there is a dialog to unlock the wallet while using the Community Fund GUI. + + +## Use of the CoinsDB for the Community Fund + +<[Pull Request 487](https://github.com/NAVCoin/navcoin-core/pull/487)> +<[Commit a8f425b](https://github.com/NAVCoin/navcoin-core/commit/a8f425b9bd86147693c1e79427c39876425ac7cf)> + +Previously the community fund data was stored in a seperate local database to the rest of the coin data. The data has now been migrated to be part of the CoinsDB which should increase performance and mitigate the data consistency issues that some users were experiencing. + + +## Added error log tab in debug window + +<[Pull Request 466](https://github.com/NAVCoin/navcoin-core/pull/466)> +<[Commit bed76b9](https://github.com/NAVCoin/navcoin-core/commit/bed76b917b6590148a371d5a3d86d2a534ef1f3b)> + +You can now see errors which are logged to the debug.log file in the debug window of navcoin-qt. Users no longer have to manually read or search the debug.log via command line to find error messages. + +## Added some new FIAT currencies and enabled auto price update + +<[Pull Request 469](https://github.com/NAVCoin/navcoin-core/pull/469)> +<[Commit 5ee24af](https://github.com/NAVCoin/navcoin-core/commit/5ee24afd29937cd7c12d538313783671318d1c87)> + +30 Fiat can now be configured as the display units through of navcoin-qt. The issue causing the sockets polling for exchange rates not to close correctly has also been resolved which prevents the wallet from eventually crashing. + +## Added new progress ui for sync + +<[Pull Request 526](https://github.com/NAVCoin/navcoin-core/pull/526)> +<[Commit 42769b2](https://github.com/NAVCoin/navcoin-core/commit/42769b2352f1a33e5b4f8c2971e787b22b00ecb4)> + +When the wallet starts and detects it is still catching up to the latest block a progress overlay will be presented to the user. The user can close the overlay but it is now clearer that the wallet is still syncing and the balances will be incorrect until syncing finishes. + +## Revert nBits patch + +<[Pull Request 544](https://github.com/NAVCoin/navcoin-core/pull/544)> <[Commit XXX](https://github.com/NAVCoin/navcoin-core/commit/XXX)> -- list of features -- list of features +This pull request reverts <[Pull Request 517](https://github.com/navcoin/navcoin-core/pull/517)> which introduced a problem preventing the wallet from syncing from scratch that was detected after 517 was already merged. ## Full List of merged pull requests @@ -39,15 +75,14 @@ - Changes required for GLIBC backward compatibility with gitian builds <[Pull Request 501](https://github.com/navcoin/navcoin-core/pull/501)> <[Commit d3b5687](https://github.com/navcoin/navcoin-core/commit/d3b56870eba55fbd2a0e323af6651f47d31e8b64)> - Fix potential deadlock <[Pull Request 506](https://github.com/navcoin/navcoin-core/pull/506)> <[Commit de6e167](https://github.com/navcoin/navcoin-core/commit/de6e167511381b5259d58518a69a48ea72417071)> - Moved the checkboxes into the empty QGroupBox <[Pull Request 484](https://github.com/navcoin/navcoin-core/pull/484)> <[Commit 4fb8043](https://github.com/navcoin/navcoin-core/commit/4fb8043f068fae1814ff76049a45f237b4df6f8e)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> -- title <[Pull Request XXX](https://github.com/navcoin/navcoin-core/pull/XXX)> <[Commit XXX](http)> \ No newline at end of file +- Added new attributes to the `getstakinginfo` and `getstakereport` commands <[Pull Request 485](https://github.com/navcoin/navcoin-core/pull/485)> <[Commit 82a2ba8](https://github.com/navcoin/navcoin-core/commit/82a2ba8aaae4fa6a7007f8efcb1842609fad70f5)> +- Added some new FIAT currencies and enabled auto price update <[Pull Request 469](https://github.com/navcoin/navcoin-core/pull/469)> <[Commit 5ee24af](https://github.com/navcoin/navcoin-core/commit/5ee24afd29937cd7c12d538313783671318d1c87)> +- OSX DMG and Mac Deploy bug fixes <[Pull Request 514](https://github.com/navcoin/navcoin-core/pull/514)> <[Commit e393fe4](https://github.com/navcoin/navcoin-core/commit/e393fe494b7c44d1dc61fa6c5f046cec3e134009)> +- Updated ./src/univalue from upstream <[Pull Request 524](https://github.com/navcoin/navcoin-core/pull/524)> <[Commit 4ff2780](https://github.com/navcoin/navcoin-core/commit/4ff2780dd838b9be6d1f4544a1d1e973ff68130e)> +- Added new progress ui for sync <[Pull Request 526](https://github.com/navcoin/navcoin-core/pull/526)> <[Commit 42769b2](https://github.com/navcoin/navcoin-core/commit/42769b2352f1a33e5b4f8c2971e787b22b00ecb4)> +- Make some tests more reliable <[Pull Request 537](https://github.com/navcoin/navcoin-core/pull/537)> <[Commit 8c4b490](https://github.com/navcoin/navcoin-core/commit/8c4b490fddea29598cc23a90a32687c5e4afd260)> +- Fixed some more file permissions <[Pull Request 533](https://github.com/navcoin/navcoin-core/pull/533)> <[Commit baa66eb](https://github.com/navcoin/navcoin-core/commit/baa66ebbf88a49c1a2099c9955a1a80b940c0969)> +- Move nBits check to ContextualCheckBlock <[Pull Request 517](https://github.com/navcoin/navcoin-core/pull/517)> <[Commit a16c48f](https://github.com/navcoin/navcoin-core/commit/a16c48f317b5dca9fce2394f70f840c59fd20228)> +- Updated the error log tab logic <[Pull Request 532](https://github.com/navcoin/navcoin-core/pull/532)> <[Commit a4f23ac](https://github.com/navcoin/navcoin-core/commit/a4f23acbc291c789ab819d38bfdf56698c88dcef)> +- Check node address in header spam protection <[Pull Request 536](https://github.com/navcoin/navcoin-core/pull/536)> <[Commit 45c98d5](https://github.com/navcoin/navcoin-core/commit/45c98d56f56a4fd706deca1594d774e49d7dadb1)> +- Revert nBits patch <[Pull Request 544](https://github.com/navcoin/navcoin-core/pull/544)> <[Commit XXX](http)> From 25247c885f67bbc07147fff8840e59cbf43e411f Mon Sep 17 00:00:00 2001 From: Craig Date: Sun, 30 Jun 2019 21:18:07 +1200 Subject: [PATCH 05/17] removed version numbers from unnecessary files and removed the revert PR from the release notes --- README.md | 2 +- doc/README.md | 2 +- doc/README_windows.txt | 2 +- doc/release-notes/release-notes-4.7.0.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index b82ce5c9c..9274e4aaf 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ ![NavCoin](./img/logo-extended.png) -This is the working repository for NavCoin 4.7.0, our fork of bitcoin-core 0.13. +This is the working repository for NavCoin Core, our fork of bitcoin-core 0.13. For more information please visit the website: diff --git a/doc/README.md b/doc/README.md index ec0423a16..64dd1f650 100644 --- a/doc/README.md +++ b/doc/README.md @@ -1,4 +1,4 @@ -NavCoin Core 4.7.0 +NavCoin Core ===================== Setup diff --git a/doc/README_windows.txt b/doc/README_windows.txt index 0bae73fe2..52e18b6f0 100755 --- a/doc/README_windows.txt +++ b/doc/README_windows.txt @@ -1,4 +1,4 @@ -NavCoin Core 4.7.0 +NavCoin Core ===================== Intro diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index 4d434cfd6..d1341e73a 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -42,7 +42,7 @@ When the wallet starts and detects it is still catching up to the latest block a <[Pull Request 544](https://github.com/NAVCoin/navcoin-core/pull/544)> <[Commit XXX](https://github.com/NAVCoin/navcoin-core/commit/XXX)> -This pull request reverts <[Pull Request 517](https://github.com/navcoin/navcoin-core/pull/517)> which introduced a problem preventing the wallet from syncing from scratch that was detected after 517 was already merged. +This pull request reverts <[Pull Request 517](https://github.com/navcoin/navcoin-core/pull/517)> which introduced a problem preventing the wallet from syncing from scratch that was detected after #517 was already merged. ## Full List of merged pull requests From 9b392905ad6080a539cf68e01dc3ff8c52707701 Mon Sep 17 00:00:00 2001 From: Craig Date: Sun, 30 Jun 2019 21:23:50 +1200 Subject: [PATCH 06/17] replaced references to /NAVCoin/ with /navcoin/ to match the updated github organisation name lowercasing. --- README.md | 2 +- doc/build-osx.md | 2 +- doc/build-unix.md | 4 +- doc/gitian-building.md | 2 +- doc/npips.md | 2 +- doc/release-notes/release-notes-4.3.0.md | 4 +- doc/release-notes/release-notes-4.4.0.md | 4 +- doc/release-notes/release-notes-4.5.0.md | 38 ++++++++--------- doc/release-notes/release-notes-4.5.1.md | 16 +++---- doc/release-notes/release-notes-4.5.2.md | 32 +++++++------- doc/release-notes/release-notes-4.6.0.md | 54 ++++++++++++------------ doc/release-notes/release-notes-4.7.0.md | 25 ++++------- src/init.cpp | 2 +- 13 files changed, 90 insertions(+), 97 deletions(-) diff --git a/README.md b/README.md index 9274e4aaf..fbd93b88e 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ For more information please visit the website: https://navcoin.org/en/roadmap -[![Build Status](https://travis-ci.org/NAVCoin/navcoin-core.svg?branch=master)](https://travis-ci.org/NAVCoin/navcoin-core) +[![Build Status](https://travis-ci.org/navcoin/navcoin-core.svg?branch=master)](https://travis-ci.org/navcoin/navcoin-core) ## Building diff --git a/doc/build-osx.md b/doc/build-osx.md index 8bd0261b6..b4fe18a76 100644 --- a/doc/build-osx.md +++ b/doc/build-osx.md @@ -35,7 +35,7 @@ Libunbound needs to be compiled from source. Download last version from http://w 1. Clone the navcoin source code and cd into `navcoin` ```bash - git clone https://github.com/NAVCoin/navcoin-core.git + git clone https://github.com/navcoin/navcoin-core.git cd navcoin-core ``` diff --git a/doc/build-unix.md b/doc/build-unix.md index 9914c705f..582de0428 100644 --- a/doc/build-unix.md +++ b/doc/build-unix.md @@ -7,10 +7,10 @@ Some notes on how to build NavCoin Core in Unix. ## Building in Ubuntu 18.04 -You can easily build the dependencies by running the [NavCoin dev tools script](https://github.com/NAVCoin/navcoin-dev-tools/blob/master/ubuntu-18.04-navcoin-core-dev-setup.sh) using the command bellow. +You can easily build the dependencies by running the [NavCoin dev tools script](https://github.com/navcoin/navcoin-dev-tools/blob/master/ubuntu-18.04-navcoin-core-dev-setup.sh) using the command bellow. ```bash -curl -o- https://raw.githubusercontent.com/NAVCoin/navcoin-dev-tools/master/ubuntu-18.04-navcoin-core-dev-setup.sh | bash +curl -o- https://raw.githubusercontent.com/navcoin/navcoin-dev-tools/master/ubuntu-18.04-navcoin-core-dev-setup.sh | bash ``` From the navcoin-core directory, you will still need to: diff --git a/doc/gitian-building.md b/doc/gitian-building.md index c16ee7448..b004361e1 100644 --- a/doc/gitian-building.md +++ b/doc/gitian-building.md @@ -493,5 +493,5 @@ Uploading signatures --------------------- After building and signing you can push your signatures (both the `.assert` and `.assert.sig` files) to the -[NAVCoin/navcoin-sigs](https://github.com/NAVCoin/navcoin-sigs) repository, or if that's not possible create a pull +[NAVCoin/navcoin-sigs](https://github.com/navcoin/navcoin-sigs) repository, or if that's not possible create a pull request. diff --git a/doc/npips.md b/doc/npips.md index 8939586c0..be1f8b860 100644 --- a/doc/npips.md +++ b/doc/npips.md @@ -1,3 +1,3 @@ NPIPs (NavCoin Protocol Improvement Proposals) that are implemented by into NavCoin Core: -* [`NPIP 1`](https://github.com/NAVCoin/npips/blob/master/npip-0001.mediawiki): This change details how all protocol improvements will be handled from here on out **v4.2.0** ([PR #209](https://github.com/NAVCoin/navcoin-core/pull/209)) +* [`NPIP 1`](https://github.com/navcoin/npips/blob/master/npip-0001.mediawiki): This change details how all protocol improvements will be handled from here on out **v4.2.0** ([PR #209](https://github.com/navcoin/navcoin-core/pull/209)) diff --git a/doc/release-notes/release-notes-4.3.0.md b/doc/release-notes/release-notes-4.3.0.md index c0e637cf3..944552924 100644 --- a/doc/release-notes/release-notes-4.3.0.md +++ b/doc/release-notes/release-notes-4.3.0.md @@ -2,7 +2,7 @@ ## Introduces OpenAlias: -This PR https://github.com/NAVCoin/navcoin-core/pull/213 completes the implementation of the OpenAlias protocol into the NavCoin Core client. +This PR https://github.com/navcoin/navcoin-core/pull/213 completes the implementation of the OpenAlias protocol into the NavCoin Core client. OpenAlias is an standard created by the Monero Core project used in the Monero wallet and some other clients like Bitcoin Electrum which allows the wallet to translate email addresses into cryptocurrency addresses using custom TXT entries in the DNS records of a domain. @@ -31,7 +31,7 @@ We now clasify orphan transactions with a new "Orphan" status and show them in t ## Remove BIGNUM use -This PR https://github.com/NAVCoin/navcoin-core/pull/214 completely removes the use of the OpenSSL's class BIGNUM, substituting the uses of CBigNum with the class uint256 with extended arithmetic capabilities (arith_uint256). OpenSSL deprecated some BIGNUM functions in version 1.1, making the wallet unable to compile in systems which use the newer version. This patch fixes this issue. +This PR https://github.com/navcoin/navcoin-core/pull/214 completely removes the use of the OpenSSL's class BIGNUM, substituting the uses of CBigNum with the class uint256 with extended arithmetic capabilities (arith_uint256). OpenSSL deprecated some BIGNUM functions in version 1.1, making the wallet unable to compile in systems which use the newer version. This patch fixes this issue. # ZeroMQ Windows Patch diff --git a/doc/release-notes/release-notes-4.4.0.md b/doc/release-notes/release-notes-4.4.0.md index 3ed26a63d..eac05851d 100644 --- a/doc/release-notes/release-notes-4.4.0.md +++ b/doc/release-notes/release-notes-4.4.0.md @@ -24,13 +24,13 @@ The Version Bit 14 will signal for the soft fork to activate NPIP0003. This is largely a technical improvement which consolidates mined Community Fund contributions to every 500th block instead of every block to reduce blockchain bloat. -You can read more about [NPIP0003 on the NPIP GitHub](https://github.com/NAVCoin/npips/blob/master/npip-0003.mediawiki). +You can read more about [NPIP0003 on the NPIP GitHub](https://github.com/navcoin/npips/blob/master/npip-0003.mediawiki). ## Community Fund Contribution Increase The Version Bit 16 will signal for the soft fork to increase the Community Fund contribution from 0.25 NAV to 0.50 NAV per block. -You can read more about [NPIP0005 on the NPIP GitHub](https://github.com/NAVCoin/npips/blob/master/npip-0005.mediawiki). +You can read more about [NPIP0005 on the NPIP GitHub](https://github.com/navcoin/npips/blob/master/npip-0005.mediawiki). ## Reject specific version bits diff --git a/doc/release-notes/release-notes-4.5.0.md b/doc/release-notes/release-notes-4.5.0.md index 0e5c78fd4..dc3307f2d 100644 --- a/doc/release-notes/release-notes-4.5.0.md +++ b/doc/release-notes/release-notes-4.5.0.md @@ -2,10 +2,10 @@ ## Cold Staking Protocol Upgrade -<[Pull Request 249](https://github.com/NAVCoin/navcoin-core/pull/249)> -<[Commit b1c776c](https://github.com/NAVCoin/navcoin-core/commit/b1c776c605e5bace1d4f6bee50182b92951fd327 )> +<[Pull Request 249](https://github.com/navcoin/navcoin-core/pull/249)> +<[Commit b1c776c](https://github.com/navcoin/navcoin-core/commit/b1c776c605e5bace1d4f6bee50182b92951fd327 )> -This Protocol Upgrade will implement the [NPIP_0002](https://github.com/NAVCoin/npips/blob/master/npip-0002.mediawiki) which will introduce a new opcode (OP_COINSTAKE) for the NavCoin scripting language and a new standard transaction type using the new opcode. +This Protocol Upgrade will implement the [NPIP_0002](https://github.com/navcoin/npips/blob/master/npip-0002.mediawiki) which will introduce a new opcode (OP_COINSTAKE) for the NavCoin scripting language and a new standard transaction type using the new opcode. The wallet will vote this Protocol Upgrade with `YES` by default. @@ -35,10 +35,10 @@ To not vote for this Protocol Upgrade, add the following line to your `navcoin.c ## Static Rewards Protocol Upgrade -<[Pull Request 328](https://github.com/NAVCoin/navcoin-core/pull/328)> -<[Commit 9601f85](https://github.com/NAVCoin/navcoin-core/commit/9601f8501526cba19ded59ae685e393345ef430c)> +<[Pull Request 328](https://github.com/navcoin/navcoin-core/pull/328)> +<[Commit 9601f85](https://github.com/navcoin/navcoin-core/commit/9601f8501526cba19ded59ae685e393345ef430c)> -This Protocol Upgrade will change the NavCoin Staking block reward to a fixed amount of 2 NAV per block. You can read more about this upgrade at its NPIP page, [NPIP_0004](https://github.com/NAVCoin/npips/blob/master/npip-0004.mediawiki). +This Protocol Upgrade will change the NavCoin Staking block reward to a fixed amount of 2 NAV per block. You can read more about this upgrade at its NPIP page, [NPIP_0004](https://github.com/navcoin/npips/blob/master/npip-0004.mediawiki). The wallet will vote this Protocol Upgrade with `YES` by default. @@ -52,8 +52,8 @@ To reject this Protocol Upgrade, add the following line to your `navcoin.conf` f ## Dynamic Community Fund Quorum Protocol Upgrade -<[Pull Request 328](https://github.com/NAVCoin/navcoin-core/pull/333)> -<[Commit 9601f85](https://github.com/NAVCoin/navcoin-core/commit/c1ea4ac484401d17230cb82481fe17beea168979)> +<[Pull Request 328](https://github.com/navcoin/navcoin-core/pull/333)> +<[Commit 9601f85](https://github.com/navcoin/navcoin-core/commit/c1ea4ac484401d17230cb82481fe17beea168979)> This Protocol Upgrade would introduce a reduction of the required quorum for the Community Fund in the second half of the votings from 50% to 40%. @@ -68,8 +68,8 @@ To accept this Protocol Upgrade, add the following line to your `navcoin.conf` f ## Reject specific version bits by default -<[Pull Request 336](https://github.com/NAVCoin/navcoin-core/pull/336)> -<[Commit eb6a1a2](https://github.com/NAVCoin/navcoin-core/commit/eb6a1a27903a477306a7ef73d3d85bd52ff1f3c4)> +<[Pull Request 336](https://github.com/navcoin/navcoin-core/pull/336)> +<[Commit eb6a1a2](https://github.com/navcoin/navcoin-core/commit/eb6a1a27903a477306a7ef73d3d85bd52ff1f3c4)> By default the wallet votes yes for the Protocol Upgrades included in the wallet. This change adds a list of version bits which will be voted no by default, while also adding an option to manually vote yes for those bits. @@ -78,8 +78,8 @@ To manually vote yes for a version bit add the following to your `navcoin.conf` ## Block header spam protection -<[Pull Request 335](https://github.com/NAVCoin/navcoin-core/pull/335)> -<[Commit 210a22d](https://github.com/NAVCoin/navcoin-core/commit/210a22daaffbd36d90a5ee0121c0c4ce3de0ed75)> +<[Pull Request 335](https://github.com/navcoin/navcoin-core/pull/335)> +<[Commit 210a22d](https://github.com/navcoin/navcoin-core/commit/210a22daaffbd36d90a5ee0121c0c4ce3de0ed75)> The wallet will now rate-limit the amount of block headers received from a single peer before banning them for misbehaving. This is an anti-spam measure and is customizable via the config file or via launch arguments. @@ -93,8 +93,8 @@ The new launch arguments are: ## Community Fund RPC commands -<[Pull Request 334](https://github.com/NAVCoin/navcoin-core/pull/334)> -<[Commit cc8e213](https://github.com/NAVCoin/navcoin-core/commit/cc8e21306cb804671676c6e10c0c2751061e7cc8)> +<[Pull Request 334](https://github.com/navcoin/navcoin-core/pull/334)> +<[Commit cc8e213](https://github.com/navcoin/navcoin-core/commit/cc8e21306cb804671676c6e10c0c2751061e7cc8)> - Shows help for `proposalvotelist` and `paymentrequestvotelist`. - Shows proposals and payment requests in pending state without vote. @@ -103,9 +103,9 @@ The new launch arguments are: ### Other modifications in the NavCoin client, docs and codebase -- Added github issue and pull request templates. <[Pull Request 347](https://github.com/NAVCoin/navcoin-core/pull/347)> <[Commit ce2e282](https://github.com/NAVCoin/navcoin-core/commit/ce2e28295e97398d538f23d795cf20b0544973b2)>. -- Updated link to bootstrap file in wallet gui. <[Pull Request 338](https://github.com/NAVCoin/navcoin-core/pull/338)> <[Commit 8aa7cdd](https://github.com/NAVCoin/navcoin-core/commit/8aa7cddc74acac9d1e8e5f7eb50627ec064896fe)>. -- Community Fund RPC Tests clean up. <[Pull Request 318](https://github.com/NAVCoin/navcoin-core/pull/318)> <[Commit 7730c7b](https://github.com/NAVCoin/navcoin-core/commit/7730c7bc84256ddb995408c1bc775015f0219d2d)>. -- Fixed changelog link to NPIP. <[Pull Request 317](https://github.com/NAVCoin/navcoin-core/pull/317)> <[Commit f0ea24c](https://github.com/NAVCoin/navcoin-core/commit/f0ea24c2228107f765735ec2136f9f20e6eda456)>. -- Updated link to NavCoin github repo. <[Pull Request 314](https://github.com/NAVCoin/navcoin-core/pull/314)> <[Commit dcdece2](https://github.com/NAVCoin/navcoin-core/commit/dcdece2be47b4ab55b6231024aef2bc20e7d3b0c)> +- Added github issue and pull request templates. <[Pull Request 347](https://github.com/navcoin/navcoin-core/pull/347)> <[Commit ce2e282](https://github.com/navcoin/navcoin-core/commit/ce2e28295e97398d538f23d795cf20b0544973b2)>. +- Updated link to bootstrap file in wallet gui. <[Pull Request 338](https://github.com/navcoin/navcoin-core/pull/338)> <[Commit 8aa7cdd](https://github.com/navcoin/navcoin-core/commit/8aa7cddc74acac9d1e8e5f7eb50627ec064896fe)>. +- Community Fund RPC Tests clean up. <[Pull Request 318](https://github.com/navcoin/navcoin-core/pull/318)> <[Commit 7730c7b](https://github.com/navcoin/navcoin-core/commit/7730c7bc84256ddb995408c1bc775015f0219d2d)>. +- Fixed changelog link to NPIP. <[Pull Request 317](https://github.com/navcoin/navcoin-core/pull/317)> <[Commit f0ea24c](https://github.com/navcoin/navcoin-core/commit/f0ea24c2228107f765735ec2136f9f20e6eda456)>. +- Updated link to NavCoin github repo. <[Pull Request 314](https://github.com/navcoin/navcoin-core/pull/314)> <[Commit dcdece2](https://github.com/navcoin/navcoin-core/commit/dcdece2be47b4ab55b6231024aef2bc20e7d3b0c)> - New genesis block for testnet. diff --git a/doc/release-notes/release-notes-4.5.1.md b/doc/release-notes/release-notes-4.5.1.md index 8a9f586c0..b4641cf78 100644 --- a/doc/release-notes/release-notes-4.5.1.md +++ b/doc/release-notes/release-notes-4.5.1.md @@ -6,27 +6,27 @@ Currently if a node reindexes their chainstate db, the node will recalculate the deadline of expired proposals and rewrite such proposals as accepted. A node which reindexes will end up with a different state and potentially reject blocks containing payment requests causing some users to end up on their own fork of the blockchain. -<[Pull Request 367](https://github.com/NAVCoin/navcoin-core/pull/367)> -<[Commit c59cd80](https://github.com/NAVCoin/navcoin-core/commit/c59cd802e43960ab4ff88dece294dbcecc6bce8e)> +<[Pull Request 367](https://github.com/navcoin/navcoin-core/pull/367)> +<[Commit c59cd80](https://github.com/navcoin/navcoin-core/commit/c59cd802e43960ab4ff88dece294dbcecc6bce8e)> - This patch ensures the state of previously expired proposals are not rewritten as accepted when a chainstate db is reindexed locally. - Ensures proper expiry of proposals after their duration has been exceeded. - Adds tests to check the proper expiry of proposals. -<[Pull Request 370](https://github.com/NAVCoin/navcoin-core/pull/370)> +<[Pull Request 370](https://github.com/navcoin/navcoin-core/pull/370)> - Fixes the payout of payment requests when the proposal is already expired. Adds a new state for proposals (`PENDING_VOTING_PREQ`) to handle expired proposals with pending payment requests. - Adds tests to check the correct implementation of this state. ## Static Rewards Hotfix -<[Pull Request 369](https://github.com/NAVCoin/navcoin-core/pull/369)> -<[Commit 88a9060](https://github.com/NAVCoin/navcoin-core/commit/88a9060b80603afdab6dc374ef1144fcb58bc462)> +<[Pull Request 369](https://github.com/navcoin/navcoin-core/pull/369)> +<[Commit 88a9060](https://github.com/navcoin/navcoin-core/commit/88a9060b80603afdab6dc374ef1144fcb58bc462)> Currently if a block included both a static reward and some transaction(s), the network will reject such blocks since the total amount of fees would be verified incorrectly. This patch fixes the verification and adds tests to check the blocks are correctly accepted. ## Other modifications in the NavCoin client, docs and codebase -- Fixed output of `cfundstats` rpc command. <[Pull Request 374](https://github.com/NAVCoin/navcoin-core/pull/374)> <[Commit fe5f8c7](https://github.com/NAVCoin/navcoin-core/commit/fe5f8c79ea5708692181dfb913e8b17d5517c4ea)>. -- Improvements to core wallet CFund voting window. <[Pull Request 368](https://github.com/NAVCoin/navcoin-core/pull/368)> <[Commit 1b1077b](https://github.com/NAVCoin/navcoin-core/commit/1b1077be384c1a230d7c568a7fa05d4b43a4111b)> -- Minor typo fix to coldstaking wizard. <[Pull Request 364](https://github.com/NAVCoin/navcoin-core/pull/364)> <[Commit 769ff16](https://github.com/NAVCoin/navcoin-core/commit/769ff16b05f70ccfa24adcaf589bfa5a4157c067)> +- Fixed output of `cfundstats` rpc command. <[Pull Request 374](https://github.com/navcoin/navcoin-core/pull/374)> <[Commit fe5f8c7](https://github.com/navcoin/navcoin-core/commit/fe5f8c79ea5708692181dfb913e8b17d5517c4ea)>. +- Improvements to core wallet CFund voting window. <[Pull Request 368](https://github.com/navcoin/navcoin-core/pull/368)> <[Commit 1b1077b](https://github.com/navcoin/navcoin-core/commit/1b1077be384c1a230d7c568a7fa05d4b43a4111b)> +- Minor typo fix to coldstaking wizard. <[Pull Request 364](https://github.com/navcoin/navcoin-core/pull/364)> <[Commit 769ff16](https://github.com/navcoin/navcoin-core/commit/769ff16b05f70ccfa24adcaf589bfa5a4157c067)> diff --git a/doc/release-notes/release-notes-4.5.2.md b/doc/release-notes/release-notes-4.5.2.md index 1eb431b3a..d303a7abf 100644 --- a/doc/release-notes/release-notes-4.5.2.md +++ b/doc/release-notes/release-notes-4.5.2.md @@ -1,32 +1,32 @@ # NavCoin v4.5.2 Release Notes ## Community Fund Duplicate Payment Hard Fork -<[Pull Request 413](https://github.com/NAVCoin/navcoin-core/pull/413)> -<[Commit 7ef765b](https://github.com/NAVCoin/navcoin-core/commit/7ef765bf05802d491a6be8b8ea781e33f9c5aa4f)> +<[Pull Request 413](https://github.com/navcoin/navcoin-core/pull/413)> +<[Commit 7ef765b](https://github.com/navcoin/navcoin-core/commit/7ef765bf05802d491a6be8b8ea781e33f9c5aa4f)> Fixes a bug where the Community Fund payment requests could be accepted by the network multiple times. Enforces version bit 21 for all blocks after blockheight 2882875 as well as rejecting duplicate payments after the fork height. ## Voting Cycle Counter Hotfix -<[Pull Request 396](https://github.com/NAVCoin/navcoin-core/pull/396)> -<[Commit a6782c3](https://github.com/NAVCoin/navcoin-core/commit/a6782c3be14444433b8a2b9abeac9aef7151331d)> +<[Pull Request 396](https://github.com/navcoin/navcoin-core/pull/396)> +<[Commit a6782c3](https://github.com/navcoin/navcoin-core/commit/a6782c3be14444433b8a2b9abeac9aef7151331d)> Fixes a bug where the `votingCycle` field of community fund proposals and payment requests would continue to increment after their terminal state if a user reorgs. Also for proposal/payment requests which change from pending to expired, when the voting cycle is 1 over the cycle limit, staker's votes would continue to be counted even though such proposal/payment request is expired. This bug did not affect network consensus on the status of proposal or payment requests. ## Faster Blockchain Sync -<[Pull Request 390](https://github.com/NAVCoin/navcoin-core/pull/390)> -<[Commit 1990d92](https://github.com/NAVCoin/navcoin-core/commit/1990d929f216e69efa96484b31d3e65ff4196aee)> +<[Pull Request 390](https://github.com/navcoin/navcoin-core/pull/390)> +<[Commit 1990d92](https://github.com/navcoin/navcoin-core/commit/1990d929f216e69efa96484b31d3e65ff4196aee)> Keeps a cache of the community fund votes to avoid an unnecessary recalculation per block which was causing extreme slow synchronization per block. After applying the patch the CountVotes() function is significantly faster. ## RPC Tests newly implemented and fixed The RPC unit test work mainly involved fixing broken RPC tests inherited from Bitcoin as well as creating new ones. This expands our test suite allowing for greater coverage which provides quality checks to the existing codebase and future updates. -- Fixes to 17 rpc tests inherited from Bitcoin and implements 2 new tests <[Pull Request 405](https://github.com/NAVCoin/navcoin-core/pull/405)><[Commit ed3f590](https://github.com/NAVCoin/navcoin-core/commit/ed3f590ad8d1b25bfdc6caee153a9372c8180cb6)> -- Added rpc help test <[Pull Request 392](https://github.com/NAVCoin/navcoin-core/pull/392)> <[Commit 6707a98](https://github.com/NAVCoin/navcoin-core/commit/6707a98f4788251fdc5afcea914a456f38926349)> -- Fixes to cfund rpc tests <[Pull Request 376](https://github.com/NAVCoin/navcoin-core/pull/376)> <[Commit 6f157e4](https://github.com/NAVCoin/navcoin-core/commit/6f157e4ba2c92f3f038798baa30eb0aaa563b43d)> +- Fixes to 17 rpc tests inherited from Bitcoin and implements 2 new tests <[Pull Request 405](https://github.com/navcoin/navcoin-core/pull/405)><[Commit ed3f590](https://github.com/navcoin/navcoin-core/commit/ed3f590ad8d1b25bfdc6caee153a9372c8180cb6)> +- Added rpc help test <[Pull Request 392](https://github.com/navcoin/navcoin-core/pull/392)> <[Commit 6707a98](https://github.com/navcoin/navcoin-core/commit/6707a98f4788251fdc5afcea914a456f38926349)> +- Fixes to cfund rpc tests <[Pull Request 376](https://github.com/navcoin/navcoin-core/pull/376)> <[Commit 6f157e4](https://github.com/navcoin/navcoin-core/commit/6f157e4ba2c92f3f038798baa30eb0aaa563b43d)> ## Other updates to the NavCoin client, docs and codebase -- Restart of testnet <[Pull Request 402](https://github.com/NAVCoin/navcoin-core/pull/402)> <[Commit c821bad](https://github.com/NAVCoin/navcoin-core/commit/c821badee5bfc4910671e37680b731ce52aadd6e)> -- RPC paymentrequestvotelist and proposalvotelist output changed to JSON <[Pull Request 380](https://github.com/NAVCoin/navcoin-core/pull/380)> <[Commit b2ed39a](https://github.com/NAVCoin/navcoin-core/commit/b2ed39a45d190b06b25eb404c02b4c8a3c90f5a7)> -- Disables dark mode on MacOS Mojave <[Pull Request 403](https://github.com/NAVCoin/navcoin-core/pull/403)> <[Commit e436506](https://github.com/NAVCoin/navcoin-core/commit/e4365060007ae08b17fe2de99971677c7d32ce11)> -- Updates to OS X building docs <[Pull Request 406](https://github.com/NAVCoin/navcoin-core/pull/406)><[Commit a1fc1fa](https://github.com/NAVCoin/navcoin-core/commit/a1fc1fa19fcb07194b5955a3a18e6fd5d4f81170)> -- Updates to Unix building docs <[Pull Request 408](https://github.com/NAVCoin/navcoin-core/pull/408)> <[Commit aacbb3d](https://github.com/NAVCoin/navcoin-core/commit/aacbb3dfc51374da649274754d2fec44dc27b342)> -- Updates to gitian building docs for Debian 9 <[Pull Request 365](https://github.com/NAVCoin/navcoin-core/pull/365)> <[Commit 732c257](https://github.com/NAVCoin/navcoin-core/commit/732c257b8a3c9c439c9fef9be7cbb726db118018)> -- Deletes duplicate Qt Creator files <[Pull Request 382](https://github.com/NAVCoin/navcoin-core/pull/382)> <[Commit 8eb4652](https://github.com/NAVCoin/navcoin-core/commit/8eb4652cb9e35524a8449cf4ef1645af47e435ba)> +- Restart of testnet <[Pull Request 402](https://github.com/navcoin/navcoin-core/pull/402)> <[Commit c821bad](https://github.com/navcoin/navcoin-core/commit/c821badee5bfc4910671e37680b731ce52aadd6e)> +- RPC paymentrequestvotelist and proposalvotelist output changed to JSON <[Pull Request 380](https://github.com/navcoin/navcoin-core/pull/380)> <[Commit b2ed39a](https://github.com/navcoin/navcoin-core/commit/b2ed39a45d190b06b25eb404c02b4c8a3c90f5a7)> +- Disables dark mode on MacOS Mojave <[Pull Request 403](https://github.com/navcoin/navcoin-core/pull/403)> <[Commit e436506](https://github.com/navcoin/navcoin-core/commit/e4365060007ae08b17fe2de99971677c7d32ce11)> +- Updates to OS X building docs <[Pull Request 406](https://github.com/navcoin/navcoin-core/pull/406)><[Commit a1fc1fa](https://github.com/navcoin/navcoin-core/commit/a1fc1fa19fcb07194b5955a3a18e6fd5d4f81170)> +- Updates to Unix building docs <[Pull Request 408](https://github.com/navcoin/navcoin-core/pull/408)> <[Commit aacbb3d](https://github.com/navcoin/navcoin-core/commit/aacbb3dfc51374da649274754d2fec44dc27b342)> +- Updates to gitian building docs for Debian 9 <[Pull Request 365](https://github.com/navcoin/navcoin-core/pull/365)> <[Commit 732c257](https://github.com/navcoin/navcoin-core/commit/732c257b8a3c9c439c9fef9be7cbb726db118018)> +- Deletes duplicate Qt Creator files <[Pull Request 382](https://github.com/navcoin/navcoin-core/pull/382)> <[Commit 8eb4652](https://github.com/navcoin/navcoin-core/commit/8eb4652cb9e35524a8449cf4ef1645af47e435ba)> diff --git a/doc/release-notes/release-notes-4.6.0.md b/doc/release-notes/release-notes-4.6.0.md index 345ad25b0..44225ae64 100644 --- a/doc/release-notes/release-notes-4.6.0.md +++ b/doc/release-notes/release-notes-4.6.0.md @@ -2,8 +2,8 @@ ## Community Fund UI -<[Pull Request 428](https://github.com/NAVCoin/navcoin-core/pull/428)> -<[Commit cbffaee](https://github.com/NAVCoin/navcoin-core/commit/cbffaeee68d649069e0964b4930d04c441a7b63c)> +<[Pull Request 428](https://github.com/navcoin/navcoin-core/pull/428)> +<[Commit cbffaee](https://github.com/navcoin/navcoin-core/commit/cbffaeee68d649069e0964b4930d04c441a7b63c)> - Added a Community Fund tab to the core wallet - Ability to view and filter proposals and payment request @@ -12,8 +12,8 @@ ## Accumulation of staking rewards in different address -<[Pull Request 401](https://github.com/NAVCoin/navcoin-core/pull/401)> -<[Commit 2fb7b47](https://github.com/NAVCoin/navcoin-core/commit/2fb7b47625dfe866f6079d8c7ac8c1dfb9f9de1d)> +<[Pull Request 401](https://github.com/navcoin/navcoin-core/pull/401)> +<[Commit 2fb7b47](https://github.com/navcoin/navcoin-core/commit/2fb7b47625dfe866f6079d8c7ac8c1dfb9f9de1d)> This features introduces support for the `-stakingaddress` launch argument which sets a NavCoin address where the staking rewards are accumulated. It also allows you to specify mappings from one address to another, such that the first address's staking rewards will be deposited in the second address. `stakingaddress` can take: @@ -24,43 +24,43 @@ Not compatible with cold staking. ## Mnemonic seed phrase support -<[Pull Request 400](https://github.com/NAVCoin/navcoin-core/pull/400)> -<[Commit 375c657](https://github.com/NAVCoin/navcoin-core/commit/375c657337c33c56a6b97350ba886bce9ba60c7c)> +<[Pull Request 400](https://github.com/navcoin/navcoin-core/pull/400)> +<[Commit 375c657](https://github.com/navcoin/navcoin-core/commit/375c657337c33c56a6b97350ba886bce9ba60c7c)> This PR adds a new RPC command to export the existing master private key encoded as a mnemonic: `dumpmnemonic` It admits an argument specifying the language. Support for two new wallet options (`-importmnemonic` and `-mnemoniclanguage`) have also been added to allow to create a new wallet from the specified mnemonic. ## Fix wrong balance after orphan stakes -<[Pull Request 438](https://github.com/NAVCoin/navcoin-core/pull/438)> -<[Commit 4041e3e](https://github.com/NAVCoin/navcoin-core/commit/4041e3ef5de672c6d4e6a20ce5b7f22df090ed14)> +<[Pull Request 438](https://github.com/navcoin/navcoin-core/pull/438)> +<[Commit 4041e3e](https://github.com/navcoin/navcoin-core/commit/4041e3ef5de672c6d4e6a20ce5b7f22df090ed14)> This PR fixes an historical issue which made the wallet show a wrong balance after orphan stakes. ## Index cold staking address unspent output by spending address -<[Pull Request 434](https://github.com/NAVCoin/navcoin-core/pull/434)> -<[Commit 404d85f](https://github.com/NAVCoin/navcoin-core/commit/404d85f8ea65bf764d3fa681a4d1483c3e72c507)> +<[Pull Request 434](https://github.com/navcoin/navcoin-core/pull/434)> +<[Commit 404d85f](https://github.com/navcoin/navcoin-core/commit/404d85f8ea65bf764d3fa681a4d1483c3e72c507)> When running a node with -addressindex=1 executing the RPC command “getaddressutxos” with the spending pubkeyhash of a cold staking address will now return any utxo’s available to spend by that key including those where the pubkeyhash is the spending key of a coldstaking transaction. Previously only regular utxo’s sent directly to that pubkeyhash were returned. ## Fix for Payment Request reorganizations -<[Pull Request 456](https://github.com/NAVCoin/navcoin-core/pull/456)> -<[Commit 688bf4d](https://github.com/NAVCoin/navcoin-core/commit/688bf4d808ca5b5d3d08fef00d085397bb5b47f0)> +<[Pull Request 456](https://github.com/navcoin/navcoin-core/pull/456)> +<[Commit 688bf4d](https://github.com/navcoin/navcoin-core/commit/688bf4d808ca5b5d3d08fef00d085397bb5b47f0)> This PR prevents payment requests with invalid hashes (not set yet or out of the main chain) to count for the already requested balance of a proposal. ## Other updates to the NavCoin client, docs and codebase -- Missing increased buffer for cfund gui <[Pull Request 459](https://github.com/NAVCoin/navcoin-core/pull/459)> <[Commit 073ef14](https://github.com/NAVCoin/navcoin-core/commit/073ef14a9b46c92d03da20c3b279a8156f6cdaf9)> -- Updated the help text for 'getcoldstakingaddress' RPC/cli call <[Pull Request 458](https://github.com/NAVCoin/navcoin-core/pull/458)> <[Commit b4a1db5](https://github.com/NAVCoin/navcoin-core/commit/b4a1db5cdd3afe8e1e7f4a50068b15d162548447)> -- Combined fix for issues #445 and #446 <[Pull Request 450](https://github.com/NAVCoin/navcoin-core/pull/450)> <[Commit 96198f9](https://github.com/NAVCoin/navcoin-core/commit/96198f924bd71848d051e7a630c1818854bfa339)> -- Fixes coldstake tx amount for spending wallets <[Pull Request 447](https://github.com/NAVCoin/navcoin-core/pull/447)> <[Commit 8c93c6b](https://github.com/NAVCoin/navcoin-core/commit/8c93c6bea3f8aa926675ebe2e9e4bb604738d964)> -- Community Fund GUI date buffer increase <[Pull Request 443](https://github.com/NAVCoin/navcoin-core/pull/443)> <[Commit 8072efb](https://github.com/NAVCoin/navcoin-core/commit/8072efb01ad1882c7ea1a853d5d1e5960ae5c61b)> -- Use chainActive.Tip() instead of pindexBestHeader <[Pull Request 442](https://github.com/NAVCoin/navcoin-core/pull/442)> <[Commit 4de0827](https://github.com/NAVCoin/navcoin-core/commit/4de08271f82f888d73024317af08723a82fca467)> -- Fix Gitian Build <[Pull Request 441](https://github.com/NAVCoin/navcoin-core/pull/441)> <[Commit afa2e8b](https://github.com/NAVCoin/navcoin-core/commit/afa2e8b8e9fd8cf67605e15ac8671e996bcc2e2d)> -- Adds arrayslice.h to Makefile.am <[Pull Request 440](https://github.com/NAVCoin/navcoin-core/pull/440)> <[Commit 5ba6b6a](https://github.com/NAVCoin/navcoin-core/commit/5ba6b6affbee20e9298776a99a70331384b1a1e2)> -- Update FreeType depend file to 2.7.1 <[Pull Request 433](https://github.com/NAVCoin/navcoin-core/pull/433)> <[Commit 6025758](https://github.com/NAVCoin/navcoin-core/commit/60257582df85c07b794ceb186e2289eada4d3832)> -- Fix crash with -banversion <[Pull Request 432](https://github.com/NAVCoin/navcoin-core/pull/432)> <[Commit a25b139](https://github.com/NAVCoin/navcoin-core/commit/a25b1391120b3906d12173a88abce64b405fa0f4)> -- Fixed cold staking report RPC command <[Pull Request 425](https://github.com/NAVCoin/navcoin-core/pull/425)> <[Commit 765d5be](https://github.com/NAVCoin/navcoin-core/commit/765d5bee07d1611acc12341f6b99d73c411095ac)> -- Fixed comment syntax in merkle_blocks.py <[Pull Request 426](https://github.com/NAVCoin/navcoin-core/pull/426)><[Commit f26e2a7](https://github.com/NAVCoin/navcoin-core/commit/f26e2a78e8ca6ec0c216af4e468e18bdf07a7835)> -- Fixed "GUI: libpng warning" in wallet <[Pull Request 419](https://github.com/NAVCoin/navcoin-core/pull/419)> <[Commit 0df065e](https://github.com/NAVCoin/navcoin-core/commit/0df065efe1241d588de1c2fc415bcc9701f679e9)> -- Fixed merkle_blocks.py test randomly failing <[Pull Request 423](https://github.com/NAVCoin/navcoin-core/pull/423)> <[Commit 52ed487](https://github.com/NAVCoin/navcoin-core/commit/52ed487a5c5c60f14fdfa3de5ee222c4b6953b4f)> -- Fixed while loops of cfund tests causing random test fails <[Pull Request 418](https://github.com/NAVCoin/navcoin-core/pull/418)> <[Commit 66a4852](https://github.com/NAVCoin/navcoin-core/commit/66a48524b98a8f3e382739a61ab763db52c9d670)> +- Missing increased buffer for cfund gui <[Pull Request 459](https://github.com/navcoin/navcoin-core/pull/459)> <[Commit 073ef14](https://github.com/navcoin/navcoin-core/commit/073ef14a9b46c92d03da20c3b279a8156f6cdaf9)> +- Updated the help text for 'getcoldstakingaddress' RPC/cli call <[Pull Request 458](https://github.com/navcoin/navcoin-core/pull/458)> <[Commit b4a1db5](https://github.com/navcoin/navcoin-core/commit/b4a1db5cdd3afe8e1e7f4a50068b15d162548447)> +- Combined fix for issues #445 and #446 <[Pull Request 450](https://github.com/navcoin/navcoin-core/pull/450)> <[Commit 96198f9](https://github.com/navcoin/navcoin-core/commit/96198f924bd71848d051e7a630c1818854bfa339)> +- Fixes coldstake tx amount for spending wallets <[Pull Request 447](https://github.com/navcoin/navcoin-core/pull/447)> <[Commit 8c93c6b](https://github.com/navcoin/navcoin-core/commit/8c93c6bea3f8aa926675ebe2e9e4bb604738d964)> +- Community Fund GUI date buffer increase <[Pull Request 443](https://github.com/navcoin/navcoin-core/pull/443)> <[Commit 8072efb](https://github.com/navcoin/navcoin-core/commit/8072efb01ad1882c7ea1a853d5d1e5960ae5c61b)> +- Use chainActive.Tip() instead of pindexBestHeader <[Pull Request 442](https://github.com/navcoin/navcoin-core/pull/442)> <[Commit 4de0827](https://github.com/navcoin/navcoin-core/commit/4de08271f82f888d73024317af08723a82fca467)> +- Fix Gitian Build <[Pull Request 441](https://github.com/navcoin/navcoin-core/pull/441)> <[Commit afa2e8b](https://github.com/navcoin/navcoin-core/commit/afa2e8b8e9fd8cf67605e15ac8671e996bcc2e2d)> +- Adds arrayslice.h to Makefile.am <[Pull Request 440](https://github.com/navcoin/navcoin-core/pull/440)> <[Commit 5ba6b6a](https://github.com/navcoin/navcoin-core/commit/5ba6b6affbee20e9298776a99a70331384b1a1e2)> +- Update FreeType depend file to 2.7.1 <[Pull Request 433](https://github.com/navcoin/navcoin-core/pull/433)> <[Commit 6025758](https://github.com/navcoin/navcoin-core/commit/60257582df85c07b794ceb186e2289eada4d3832)> +- Fix crash with -banversion <[Pull Request 432](https://github.com/navcoin/navcoin-core/pull/432)> <[Commit a25b139](https://github.com/navcoin/navcoin-core/commit/a25b1391120b3906d12173a88abce64b405fa0f4)> +- Fixed cold staking report RPC command <[Pull Request 425](https://github.com/navcoin/navcoin-core/pull/425)> <[Commit 765d5be](https://github.com/navcoin/navcoin-core/commit/765d5bee07d1611acc12341f6b99d73c411095ac)> +- Fixed comment syntax in merkle_blocks.py <[Pull Request 426](https://github.com/navcoin/navcoin-core/pull/426)><[Commit f26e2a7](https://github.com/navcoin/navcoin-core/commit/f26e2a78e8ca6ec0c216af4e468e18bdf07a7835)> +- Fixed "GUI: libpng warning" in wallet <[Pull Request 419](https://github.com/navcoin/navcoin-core/pull/419)> <[Commit 0df065e](https://github.com/navcoin/navcoin-core/commit/0df065efe1241d588de1c2fc415bcc9701f679e9)> +- Fixed merkle_blocks.py test randomly failing <[Pull Request 423](https://github.com/navcoin/navcoin-core/pull/423)> <[Commit 52ed487](https://github.com/navcoin/navcoin-core/commit/52ed487a5c5c60f14fdfa3de5ee222c4b6953b4f)> +- Fixed while loops of cfund tests causing random test fails <[Pull Request 418](https://github.com/navcoin/navcoin-core/pull/418)> <[Commit 66a4852](https://github.com/navcoin/navcoin-core/commit/66a48524b98a8f3e382739a61ab763db52c9d670)> diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index d1341e73a..423c72aad 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -2,7 +2,7 @@ ## Added password prompt for CFund payment/proposal dialogs -<[Pull Request 474](https://github.com/NAVCoin/navcoin-core/pull/474)> +<[Pull Request 474](https://github.com/navcoin/navcoin-core/pull/474)> <[Commit aa4bbaa](https://github.com/navcoin/navcoin-core/commit/aa4bbaaf7a82600775065f6bab894f78583b9784)> Peviously you would have to unlock the wallet via the console or debug window before it was possible to create a proposal or payment request through the graphical interface. Now there is a dialog to unlock the wallet while using the Community Fund GUI. @@ -10,40 +10,33 @@ Peviously you would have to unlock the wallet via the console or debug window be ## Use of the CoinsDB for the Community Fund -<[Pull Request 487](https://github.com/NAVCoin/navcoin-core/pull/487)> -<[Commit a8f425b](https://github.com/NAVCoin/navcoin-core/commit/a8f425b9bd86147693c1e79427c39876425ac7cf)> +<[Pull Request 487](https://github.com/navcoin/navcoin-core/pull/487)> +<[Commit a8f425b](https://github.com/navcoin/navcoin-core/commit/a8f425b9bd86147693c1e79427c39876425ac7cf)> Previously the community fund data was stored in a seperate local database to the rest of the coin data. The data has now been migrated to be part of the CoinsDB which should increase performance and mitigate the data consistency issues that some users were experiencing. ## Added error log tab in debug window -<[Pull Request 466](https://github.com/NAVCoin/navcoin-core/pull/466)> -<[Commit bed76b9](https://github.com/NAVCoin/navcoin-core/commit/bed76b917b6590148a371d5a3d86d2a534ef1f3b)> +<[Pull Request 466](https://github.com/navcoin/navcoin-core/pull/466)> +<[Commit bed76b9](https://github.com/navcoin/navcoin-core/commit/bed76b917b6590148a371d5a3d86d2a534ef1f3b)> You can now see errors which are logged to the debug.log file in the debug window of navcoin-qt. Users no longer have to manually read or search the debug.log via command line to find error messages. ## Added some new FIAT currencies and enabled auto price update -<[Pull Request 469](https://github.com/NAVCoin/navcoin-core/pull/469)> -<[Commit 5ee24af](https://github.com/NAVCoin/navcoin-core/commit/5ee24afd29937cd7c12d538313783671318d1c87)> +<[Pull Request 469](https://github.com/navcoin/navcoin-core/pull/469)> +<[Commit 5ee24af](https://github.com/navcoin/navcoin-core/commit/5ee24afd29937cd7c12d538313783671318d1c87)> 30 Fiat can now be configured as the display units through of navcoin-qt. The issue causing the sockets polling for exchange rates not to close correctly has also been resolved which prevents the wallet from eventually crashing. ## Added new progress ui for sync -<[Pull Request 526](https://github.com/NAVCoin/navcoin-core/pull/526)> -<[Commit 42769b2](https://github.com/NAVCoin/navcoin-core/commit/42769b2352f1a33e5b4f8c2971e787b22b00ecb4)> +<[Pull Request 526](https://github.com/navcoin/navcoin-core/pull/526)> +<[Commit 42769b2](https://github.com/navcoin/navcoin-core/commit/42769b2352f1a33e5b4f8c2971e787b22b00ecb4)> When the wallet starts and detects it is still catching up to the latest block a progress overlay will be presented to the user. The user can close the overlay but it is now clearer that the wallet is still syncing and the balances will be incorrect until syncing finishes. -## Revert nBits patch - -<[Pull Request 544](https://github.com/NAVCoin/navcoin-core/pull/544)> -<[Commit XXX](https://github.com/NAVCoin/navcoin-core/commit/XXX)> - -This pull request reverts <[Pull Request 517](https://github.com/navcoin/navcoin-core/pull/517)> which introduced a problem preventing the wallet from syncing from scratch that was detected after #517 was already merged. - ## Full List of merged pull requests - Build: Compatibility with boost 1.67 <[Pull Request 470](https://github.com/navcoin/navcoin-core/pull/470)> <[Commit 47ac15f](https://github.com/navcoin/navcoin-core/commit/47ac15f2fd8caa8ec15455be9742f8a897c13c49)> diff --git a/src/init.cpp b/src/init.cpp index 766246bcd..03d0f608b 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -568,7 +568,7 @@ std::string HelpMessage(HelpMessageMode mode) std::string LicenseInfo() { - const std::string URL_SOURCE_CODE = ""; + const std::string URL_SOURCE_CODE = ""; const std::string URL_WEBSITE = ""; // todo: remove urls from translations on next change return CopyrightHolders(strprintf(_("Copyright (C) %i-%i"), 2009, COPYRIGHT_YEAR) + " ") + "\n" + From 6527368a0fb02e5f133fce0046244dd7ca736524 Mon Sep 17 00:00:00 2001 From: Craig Date: Mon, 1 Jul 2019 07:52:12 +1200 Subject: [PATCH 07/17] PR 544 added to release notes --- doc/release-notes/release-notes-4.7.0.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index 423c72aad..d5de0a9ad 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -78,4 +78,4 @@ When the wallet starts and detects it is still catching up to the latest block a - Move nBits check to ContextualCheckBlock <[Pull Request 517](https://github.com/navcoin/navcoin-core/pull/517)> <[Commit a16c48f](https://github.com/navcoin/navcoin-core/commit/a16c48f317b5dca9fce2394f70f840c59fd20228)> - Updated the error log tab logic <[Pull Request 532](https://github.com/navcoin/navcoin-core/pull/532)> <[Commit a4f23ac](https://github.com/navcoin/navcoin-core/commit/a4f23acbc291c789ab819d38bfdf56698c88dcef)> - Check node address in header spam protection <[Pull Request 536](https://github.com/navcoin/navcoin-core/pull/536)> <[Commit 45c98d5](https://github.com/navcoin/navcoin-core/commit/45c98d56f56a4fd706deca1594d774e49d7dadb1)> -- Revert nBits patch <[Pull Request 544](https://github.com/navcoin/navcoin-core/pull/544)> <[Commit XXX](http)> +- Revert nBits patch <[Pull Request 544](https://github.com/navcoin/navcoin-core/pull/544)> <[Commit ab51282](https://github.com/navcoin/navcoin-core/commit/ab51282efee7b66f1ee1520c3b965567d3e0f6a4)> From c26f98e518d9932bd159723ce43def6c6d71a48e Mon Sep 17 00:00:00 2001 From: Craig Date: Tue, 9 Jul 2019 08:17:44 +1200 Subject: [PATCH 08/17] updating release notes --- doc/release-notes/release-notes-4.7.0.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index d5de0a9ad..208b2173c 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -79,3 +79,5 @@ When the wallet starts and detects it is still catching up to the latest block a - Updated the error log tab logic <[Pull Request 532](https://github.com/navcoin/navcoin-core/pull/532)> <[Commit a4f23ac](https://github.com/navcoin/navcoin-core/commit/a4f23acbc291c789ab819d38bfdf56698c88dcef)> - Check node address in header spam protection <[Pull Request 536](https://github.com/navcoin/navcoin-core/pull/536)> <[Commit 45c98d5](https://github.com/navcoin/navcoin-core/commit/45c98d56f56a4fd706deca1594d774e49d7dadb1)> - Revert nBits patch <[Pull Request 544](https://github.com/navcoin/navcoin-core/pull/544)> <[Commit ab51282](https://github.com/navcoin/navcoin-core/commit/ab51282efee7b66f1ee1520c3b965567d3e0f6a4)> +- Updated __poll_chk implementation to be not so strict <[Pull Request 549](https://github.com/navcoin/navcoin-core/pull/549)> <[Commit ee83269](https://github.com/navcoin/navcoin-core/commit/ee832697b981077a591a0c2d2a8df64f4fda9651)> +- Added an additional LOCK for cs_main <[Pull Request 558](https://github.com/navcoin/navcoin-core/pull/558)> <[Commit ac5df35](https://github.com/navcoin/navcoin-core/commit/ac5df354f3b9c961a60b581284c1748a275bef5d)> From 3d6fea6891ffd4e7071185502f6823b163d61eb8 Mon Sep 17 00:00:00 2001 From: Craig Date: Sun, 14 Jul 2019 19:56:47 +1200 Subject: [PATCH 09/17] added more PRs to the release notes --- doc/release-notes/release-notes-4.7.0.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index 208b2173c..863745d84 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -81,3 +81,6 @@ When the wallet starts and detects it is still catching up to the latest block a - Revert nBits patch <[Pull Request 544](https://github.com/navcoin/navcoin-core/pull/544)> <[Commit ab51282](https://github.com/navcoin/navcoin-core/commit/ab51282efee7b66f1ee1520c3b965567d3e0f6a4)> - Updated __poll_chk implementation to be not so strict <[Pull Request 549](https://github.com/navcoin/navcoin-core/pull/549)> <[Commit ee83269](https://github.com/navcoin/navcoin-core/commit/ee832697b981077a591a0c2d2a8df64f4fda9651)> - Added an additional LOCK for cs_main <[Pull Request 558](https://github.com/navcoin/navcoin-core/pull/558)> <[Commit ac5df35](https://github.com/navcoin/navcoin-core/commit/ac5df354f3b9c961a60b581284c1748a275bef5d)> +- Added an additional LOCK for cs_main <[Pull Request 558](https://github.com/navcoin/navcoin-core/pull/558)> <[Commit ac5df35](https://github.com/navcoin/navcoin-core/commit/ac5df354f3b9c961a60b581284c1748a275bef5d)> +- new SVG icons <[Pull Request 555](https://github.com/navcoin/navcoin-core/pull/555)> <[Commit 9619bc4](https://github.com/navcoin/navcoin-core/commit/9619bc4352af42ab9234664d5836ede23294a69c)> +- Added a lock before we call GetTxStakeAmount() <[Pull Request 564](https://github.com/navcoin/navcoin-core/pull/564)> <[Commit bfeb225](https://github.com/navcoin/navcoin-core/commit/bfeb22567f7a77e65431ccc3802cdc925428709d)> \ No newline at end of file From d80809952eacba9f3a55b02e8bbdb05f816a231e Mon Sep 17 00:00:00 2001 From: alex v Date: Sun, 14 Jul 2019 14:28:12 +0200 Subject: [PATCH 10/17] Add new strings --- src/qt/locale/navcoin_en.ts | 4408 +++++++++-------------------------- src/qt/navcoinstrings.cpp | 17 +- 2 files changed, 1137 insertions(+), 3288 deletions(-) diff --git a/src/qt/locale/navcoin_en.ts b/src/qt/locale/navcoin_en.ts index 252daae47..701aac6b3 100755 --- a/src/qt/locale/navcoin_en.ts +++ b/src/qt/locale/navcoin_en.ts @@ -30,7 +30,6 @@ - Show Private Key @@ -59,758 +58,734 @@ &Delete &Delete + + + AskPassphraseDialog - - Choose the address to send coins to - + + Passphrase Dialog + Passphrase Dialog - - Choose the address to receive coins with - + + Enter passphrase + Enter passphrase - - C&hoose - + + New passphrase + New passphrase - - Sending addresses - + + Repeat new passphrase + Repeat new passphrase - - Receiving addresses + + Unlock only for staking + + + CoinControlDialog - - These are your NavCoin addresses for sending payments. Always check the amount and the receiving address before sending coins. + + Coin Selection - - These are your NavCoin addresses for receiving payments. It is recommended to use a new receiving address for each transaction. + + Quantity: - - &Copy Address + + Bytes: - - Copy &Label + + Amount: - - &Edit + + Priority: - - Show &Private Key + + Fee: - - Export Address List + + Dust: - - Comma separated file (*.csv) + + After Fee: - - Exporting Failed + + Change: - - There was an error trying to save the address list to %1. Please try again. + + (un)select all - - Private key for %1:<br><br>%2 + + Tree mode - - - AddressTableModel - - Label + + List mode - - Address - + + Amount + Amount - - (no label) + + Received with label - - - AskPassphraseDialog - - Passphrase Dialog - Passphrase Dialog + + Received with address + - - Enter passphrase - Enter passphrase + + Date + Date - - New passphrase - New passphrase + + Confirmations + - - Repeat new passphrase - Repeat new passphrase + + Confirmed + Confirmed - - Unlock only for staking + + Priority + + + CommunityFundCreatePaymentRequestDialog - - Enter the new passphrase to the wallet.<br/>Please use a passphrase of <b>ten or more random characters</b>, or <b>eight or more words</b>. + + + Create Payment Request - - Encrypt wallet + + Proposal Hash: - - - This operation needs your wallet passphrase to unlock the wallet. + + Requested Amount (NAV): - - Unlock wallet + + Description: - - Unlock wallet for staking + + Submit Payment Request - - This operation needs your wallet passphrase to decrypt the wallet. + + Close + + + CommunityFundCreateProposalDialog - - Decrypt wallet + + + + Create Proposal - - Change passphrase + + NavCoin Address: - - Enter the old passphrase and new passphrase to the wallet. + + Requested Amount (NAV): - - Confirm wallet encryption + + Description: - - Warning: If you encrypt your wallet and lose your passphrase, you will <b>LOSE ALL OF YOUR NAVCOINS</b>! + + Proposal Duration: - - Are you sure you wish to encrypt your wallet? + + Days - - - Wallet encrypted + + Hours - - %1 will close now to finish the encryption process. Remember that encrypting your wallet cannot fully protect your navcoins from being stolen by malware infecting your computer. + + Minutes - - IMPORTANT: Any previous backups you have made of your wallet file should be replaced with the newly generated, encrypted wallet file. For security reasons, previous backups of the unencrypted wallet file will become useless as soon as you start using the new, encrypted wallet. + + Close - - - - - Wallet encryption failed + + By submitting the proposal a X NAV deduction will occur from your wallet + + + CommunityFundDisplay - - Wallet encryption failed due to an internal error. Your wallet was not encrypted. - + + Form + Form - - - The supplied passphrases do not match. + + Proposal Title - - Wallet unlock failed + + Status: - - - - The passphrase entered for the wallet decryption was incorrect. + + pending - - Wallet decryption failed + + NAV Requested: - - Wallet passphrase was successfully changed. + + 100 NAV - - Warning: The Caps Lock key is on! + Expires In: - - - BanTableModel - - IP/Netmask + + 100 Days 100 Hours 100 Minutes - - Banned Until + + View Detail - CoinControlDialog - - - Coin Selection - - + CommunityFundDisplayDetailed - - Quantity: + + Proposal Details - - Bytes: + + Proposal Title - + Amount: - - Priority: + + + 100 NAV - + Fee: - - Dust: + + Address: - - After Fee: + + NfQJDyPrJ1DzyQQ29jQyewhS5qT3x3TMTG - - Change: + + Proposal Duration: - - (un)select all + + + 100 Days 100 Minutes 100 Seconds - - Tree mode + + Expires In: - - List mode + + Status: - - Amount - Amount + + pending + - - Received with label + + Number of Yes Votes: - - Received with address + + 100 Yes - - Date - Date + + Number of No Votes: + - - Confirmations + + 100 No - - Confirmed - Confirmed + + Transaction Block Hash: + - - Priority + + 95dbb71cfa4b67b258b34c1489e11e96955e1a9f26dd58a19f63417a37bce5d4 - - Copy address + + Transaction Hash: - - Copy label + + 2da711320aa9e83b91f6e4111898abc0214fdb347623a5b2286d3caf33c1e8dd - - - Copy amount + + Proposal Hash - - Copy transaction ID + + 9d486795bf6d90198b336dc354aa17f109f75cfa5536684b594f1d0c7f0f0981 - - Lock unspent + + Version Number: - - Unlock unspent + + 2 - - Copy quantity + + Voting Cycle Number: - - Copy fee + + 100 - - Copy after fee + + Link to Proposal: - - Copy bytes + + https://navcommunity.net/view-proposal/95dbb71cfa4b67b258b34c1489e11e96955e1a9f26dd58a19f63417a37bce5d4 - - Copy priority + + Close + + + CommunityFundDisplayPaymentRequest - - Copy dust - + + Form + Form - - Copy change + + Payment Reqest Title - - highest + + Status: - - higher + + pending - - high + + NAV Requested - - medium-high + + 100 NAV - - medium + + Expires In: - - low-medium + + 100 Days 100 Hours 100 Minutes - - low + + View Details + + + CommunityFundDisplayPaymentRequestDetailed - - lower + + Payment Request Details - - lowest + + Payment Request Title - - (%1 locked) + + Amount: - - none + + 100 NAV - - yes + + Status: - - no + + pending - - This label turns red if the transaction size is greater than 1000 bytes. + + Number of Yes Votes: - - - This means a fee of at least %1 per kB is required. + + + 1000 - - Can vary +/- 1 byte per input. + + Number of No Votes: - - Transactions with higher priority are more likely to get included into a block. + + Payment Request Hash: - - This label turns red if the priority is smaller than "medium". + + + + + 9d486795bf6d90198b336dc354aa17f109f75cfa5536684b594f1d0c7f0f0981 - - This label turns red if any recipient receives an amount smaller than the current dust threshold. + + Transaction Block Hash: - - Can vary +/- %1 satoshi(s) per input. + + Transaction Hash: - - - (no label) + + Version Number: - - change from %1 (%2) + + 2 - - (change) + + Voting Cycle Number: - - - ColdStakingAddressPage - - Generated address + + 0 - - Resulting URI too long, try to reduce the text for label / message. + + Expires in: - - Error encoding URI into QR Code. + + 1 Voting Cycle - - - ColdStakingWizard - - Create a Cold Staking address + + Proposal Hash: - - - EditAddressDialog - - Edit Address - Edit Address + + 2da711320aa9e83b91f6e4111898abc0214fdb347623a5b2286d3caf33c1e8dd + - - &Label - &Label + + Payment Hash: + - - The label associated with this address list entry + + Link to Payment Request: - - The address associated with this address list entry. This can only be modified for sending addresses. + + https://navcommunity.net/view-proposal/95dbb71cfa4b67b258b34c1489e11e96955e1a9f26dd58a19f63417a37bce5d4 - - &Address - &Address + + Close + + + + CommunityFundPage - - New receiving address - + + Form + Form - - New sending address + + Available: - - Edit receiving address + + Locked: - - Edit sending address + + Spent: - - The entered address "%1" is not a valid NavCoin address. + + + + 100 NAV - - The entered address "%1" is already in the address book. + + Proposals - - Could not unlock wallet. + + Payment Requests - - New key generation failed. + + All - - - FreespaceChecker - - NavCoin will try to import an old wallet.dat file. + + Your Vote - - You must choose a wallet.dat file. + + No Vote - - Cannot read wallet.dat file. + + Pending - - - GetAddressesPage - - Specify the addresses + + Accepted - - &Staking Address: + + Rejected - - S&pending Address: + + Expired - - Your Spending address and Staking address must be different. + + Create Proposal - - The addresses can't be the same! + + Create Payment Request - HelpMessageDialog - - - version - version - - - - - (%1-bit) - - + CommunityFundSuccessDialog - - About %1 + + Success - - Command-line options + + Created Proposal Successfully - - Usage: - Usage: - - - - command-line options - command-line options - - - - UI Options: + + You can view your created proposal in the core wallet or at www.url.com - - Choose data directory on startup (default: %u) + + Close + + + EditAddressDialog - - Set language, for example "de_DE" (default: system locale) - + + Edit Address + Edit Address - - Start minimized - + + &Label + &Label - - Set SSL root certificates for payment request (default: -system-) + + The label associated with this address list entry - - Show splash screen on startup (default: %u) + + The address associated with this address list entry. This can only be modified for sending addresses. - - Reset all settings changed in the GUI - + + &Address + &Address @@ -845,3526 +820,1421 @@ Import an old 3.x wallet: + + + ModalOverlay - - Error creating data folder. - + + Form + Form - - Error - Error + + Recent transactions may not yet be visible, and therefore your wallet's balance might be incorrect. This information will be correct once your wallet has finished synchronizing with the navcoin network, as detailed below. + - - - IntroPage - - Introduction + + Attempting to spend navcoins that are affected by not-yet-displayed transactions will not be accepted by the network. - - This wizard will help you generate a cold staking<br>address where you can safely store coins while<br>staking them.<br>You will need to provide two addresses from different wallets:<br> - a staking address: this address will be authorised to stake the<br> coins sent to the cold staking address.<br> - a spending address: this address will authorised to spend the<br> coins sent to the cold staking address.<br>These addresses will be used to generate a cold staking address. + + Number of blocks left - - - NavCoinGUI - - Sign &message... - Sign &message... + + + Unknown... + - - Synchronizing with network... - Synchronizing with network... + + Last block time + Last block time - - &Overview - &Overview + + Progress + - - Node + + Progress increase per hour - - Staking is turned off. + + + calculating... - - - Repair wallet + + Estimated time left until synced - - Wallet has been repaired. + + Hide + + + NavCoinGUI - - Show general overview of wallet - Show general overview of wallet + + A fatal error occurred. NavCoin can no longer continue safely and will quit. + + + + NavTechInit - - &Transactions - &Transactions + + NavTech Setup + - - Browse transaction history - Browse transaction history + + NavCoin uses an unique parallel cluster of nodes called NavTech to protect the privacy of your transactions. + - - - Update exchange prices + + You will find below the list of the NavCoin Foundation Servers. Feel free to modify this list to include your prefered servers: - - E&xit - E&xit + + 95.183.52.55:3000 +95.183.52.28:3000 +95.183.52.29:3000 +95.183.53.184:3000 + + + + + OpenURIDialog - - Quit application - Quit application + + Open URI + - - &About %1 + + Open payment request from URI or file - - Show information about %1 + + URI: - - About &Qt - About &Qt + + Select payment request file + + + + OptionsDialog - - Show information about Qt - Show information about Qt + + Options + Options - - &Options... - &Options... + + &Main + &Main - - Modify configuration options for %1 + + Automatically start %1 after logging in to the system. - Vote for Proposals + &Start %1 on system login - - Vote for Payment Requests + + Size of &database cache - - &Encrypt Wallet... - &Encrypt Wallet... - - - - &Unlock Wallet for Staking... + + MB - - Unlock wallet for Staking + + Number of script &verification threads - - &Backup Wallet... - &Backup Wallet... + + Accept connections from outside + - - &Change Passphrase... - &Change Passphrase... + + Allow incoming connections + - - &Sending addresses... + + + IP address of the proxy (e.g. IPv4: 127.0.0.1 / IPv6: ::1) - - &Receiving addresses... + + Minimize instead of exit the application when the window is closed. When this option is enabled, the application will be closed only after selecting Exit in the menu. - - &Repair wallet + + + Third party URLs (e.g. a block explorer) that appear in the transactions tab as context menu items. %s in the URL is replaced by transaction hash. Multiple URLs are separated by vertical bar |. - - Repair wallet transactions + + Third party transaction URLs - - &Import private key + + Active command-line options that override above options: - - Import private key + + Open the %1 configuration file from the working directory. - - Show &master private key + + Open Configuration File - - Show master private key - + + Reset all client options to default. + Reset all client options to default. - - Open &URI... - + + &Reset Options + &Reset Options - - Currency - + + &Network + &Network - - &Community Fund + + (0 = auto, <0 = leave that many cores free) - - Client restart required to repair the wallet. + + Your Staker vote - - Client will be shut down. Do you want to proceed? + + W&allet - - - %n active connections. - - - - - - - Reindexing blocks on disk... - Reindexing blocks on disk... + + Expert + - - Staking + + Enable coin &control features - - Staking has been enabled + + If you disable the spending of unconfirmed change, the change from a transaction cannot be used until that transaction has at least one confirmation. This also affects how your balance is computed. - - Staking has been disabled + + &Spend unconfirmed change - - Network vote. - + + Automatically open the NavCoin client port on the router. This only works when your router supports UPnP and it is enabled. + Automatically open the NavCoin client port on the router. This only works when your router supports UPnP and it is enabled. + + + + Map port using &UPnP + Map port using &UPnP - - There are new proposals or payment requests in the Community Fund.<br><br>As a staker it's important to engage in the voting process.<br><br>Please cast your vote using the Community Fund tab! + + Connect to the NavCoin network through a SOCKS5 proxy. - Read about the Community Fund + &Connect through SOCKS5 proxy (default proxy): - - Open Voting Window - + + + Proxy &IP: + Proxy &IP: - - - Expected time to earn reward is %n minute(s) - - - - + + + + &Port: + &Port: - - - Expected time to earn reward is %n hour(s) - - - - + + + + Port of the proxy (e.g. 9050) + Port of the proxy (e.g. 9050) - - - Expected time to earn reward is %n day(s) - - - - + + + Used for reaching peers via: + - - You are staking + + + + Shows, if the supplied default SOCKS5 proxy is used to reach peers via this network type. - - Not staking because wallet is locked + + IPv4 - - Not staking because wallet is offline + + IPv6 - - Not staking because wallet is syncing + + Tor - - Not staking because you don't have mature coins + + Connect to the NavCoin network through a separate SOCKS5 proxy for Tor hidden services. - - Not staking, please wait + + Use separate SOCKS5 proxy to reach peers via Tor hidden services: - - Send coins to a NavCoin address - Send coins to a NavCoin address + + &Window + &Window - - Backup wallet to another location - Backup wallet to another location + + &Hide the icon from the system tray. + - - Change the passphrase used for wallet encryption - Change the passphrase used for wallet encryption + + Hide tray icon + - &Debug window - &Debug window + Show only a tray icon after minimizing the window. + Show only a tray icon after minimizing the window. - - Open debugging and diagnostic console - Open debugging and diagnostic console + + &Minimize to the tray instead of the taskbar + &Minimize to the tray instead of the taskbar - - &Verify message... - &Verify message... + + M&inimize on close + M&inimize on close - - NavCoin - NavCoin + + &Display + &Display - - Wallet - Wallet + + User Interface &language: + User Interface &language: - - &Send - &Send + + The user interface language can be set here. This setting will take effect after restarting %1. + - - &Receive - &Receive + + &Unit to show amounts in: + &Unit to show amounts in: - - &Show / Hide - &Show / Hide + + Choose the default subdivision unit to show in the interface and when sending coins. + Choose the default subdivision unit to show in the interface and when sending coins. - - Show or hide the main Window - Show or hide the main Window + + Whether to show coin control features or not. + - - Encrypt the private keys that belong to your wallet - Encrypt the private keys that belong to your wallet + + &OK + &OK - - Sign messages with your NavCoin addresses to prove you own them - Sign messages with your NavCoin addresses to prove you own them + + &Cancel + &Cancel + + + OverviewPage - - Verify messages to ensure they were signed with specified NavCoin addresses - Verify messages to ensure they were signed with specified NavCoin addresses + + Form + Form - - &File - &File + + Balance + - - &Settings - &Settings + + + + + + + TextLabel + - - &Help - &Help + + Immature + - - Request payments (generates QR codes and navcoin: URIs) + + Total - - [TEST ONLY] + + labelTotal - - [RELEASE CANDIDATE] + + Watched - - Toggle &Staking + + + Staking - - Toggle Staking + + This wallet is currently syncing. Your balance may not be accurate until it has completed - - Show the list of used sending addresses and labels + + 24H: - - Show the list of used receiving addresses and labels + + 87 312.312 123 NAV - - &Bootstrap blockchain + + 7D - - - - Bootstrap blockchain + + 1 312.312 NAV - - Open a navcoin: URI or payment request + + 30D - - &Command-line options + + + + 132 431.41 NAV - - You can use an external trusted source to download the blockchain from.<BR>The following URL points to a bootstrap copy provided by the NavCoin Core Team.<BR>Where would you like to download it from? + + Cold Staking - - Client restart required to initiate download.<br><br>Client will be shut down and you should manually start it again. Do you want to proceed? + + 1Y - - - %n active connection(s) to NavCoin network - - %n active connection to NavCoin network - %n active connections to NavCoin network - - - - Indexing blocks on disk... + + ALL - - Processing blocks on disk... + + Transactions - - No block source available... - No block source available... - - - - Processed %n block(s) of transaction history. - - Processed %n block of transaction history. - Processed %n blocks of transaction history. - + + Connecting to NavCoin network... + - - - Last block: %n - - - - + + + 32 active connections. + - - Connected to NavCoin network. + + Last block: 800000 - - Connecting to NavCoin network... + + Available: - - - %n hour(s) - - %n hour - %n hours - - - - - %n day(s) - - %n day - %n days - - - - - - %n week(s) - - %n week - %n weeks - - - - - %1 and %2 - - - - - %n year(s) - - %n year - %n years - - - - - %1 behind - %1 behind - - - - Last received block was generated %1 ago. - Last received block was generated %1 ago. - - - - Transactions after this will not yet be visible. - Transactions after this will not yet be visible. - - - - Important network notice. - - - - - The Nav Coin Network is currently voting on introducing changes on the consensus protocol. As a participant in our network, we value your input and the decision ultimately is yours. Please cast your vote. <br><br>For more information on the proposal, please visit <a href="https://navcoin.org/community-fund">this link</a><br><br>Would you like the Nav Coin Network to update the staking rewards to setup a decentralised community fund that will help grow the network? - - - - - Yes - - - - - No - - - - - Error - Error - - - - Warning - Warning - - - - Information - Information - - - - Up to date - Up to date - - - - Show the %1 help message to get a list with possible NavCoin command-line options - - - - - %1 client - - - - - Catching up... - Catching up... - - - - Date: %1 - - - - - - Amount: %1 - - - - - - Type: %1 - - - - - - Label: %1 - - - - - - Address: %1 - - - - - - Sent transaction - Sent transaction - - - - Incoming transaction - Incoming transaction - - - Wallet is <b>encrypted</b> and currently <b>unlocked for staking only</b> + + Pending: - - - Wallet is <b>encrypted</b> and currently <b>unlocked</b> - Wallet is <b>encrypted</b> and currently <b>unlocked</b> - - - - Wallet is <b>encrypted</b> and currently <b>locked</b> - Wallet is <b>encrypted</b> and currently <b>locked</b> - - NavTechInit - - - NavTech Setup - - - - - NavCoin uses an unique parallel cluster of nodes called NavTech to protect the privacy of your transactions. - - - - - You will find below the list of the NavCoin Foundation Servers. Feel free to modify this list to include your prefered servers: - - + QObject - - 95.183.52.55:3000 -95.183.52.28:3000 -95.183.52.29:3000 -95.183.53.184:3000 - + + %1 didn't yet exit safely... - OpenURIDialog - - - Open URI - - - - - Open payment request from URI or file - - + QObject::QObject - - URI: + + Error: Specified data directory "%1" does not exist. - - Select payment request file + + Error: Cannot parse configuration file: %1. Only use key=value syntax. - - Select payment request file to open + + Error: %1 - OptionsDialog - - - Options - Options - - - - &Main - &Main - - - - Automatically start %1 after logging in to the system. - - - - - &Start %1 on system login - - - - - Size of &database cache - - + RPCConsole + - MB - - - - - Number of script &verification threads - - - - - Accept connections from outside - - - - - Allow incoming connections - - - - - - IP address of the proxy (e.g. IPv4: 127.0.0.1 / IPv6: ::1) - - - - - Minimize instead of exit the application when the window is closed. When this option is enabled, the application will be closed only after selecting Exit in the menu. - - - - - - Third party URLs (e.g. a block explorer) that appear in the transactions tab as context menu items. %s in the URL is replaced by transaction hash. Multiple URLs are separated by vertical bar |. - - - - - Third party transaction URLs - - - - - Active command-line options that override above options: - - - - - Open the %1 configuration file from the working directory. - - - - - Open Configuration File - - - - - Reset all client options to default. - Reset all client options to default. + + + + + + + + + + + + + + + + + + + + + + + + + + + N/A + N/A - - &Reset Options - &Reset Options - - - - &Network - &Network - - - - (0 = auto, <0 = leave that many cores free) - - - - - Your Staker vote - - - - - W&allet - - - - - Expert - - - - - Enable coin &control features - - - - - If you disable the spending of unconfirmed change, the change from a transaction cannot be used until that transaction has at least one confirmation. This also affects how your balance is computed. - - - - - &Spend unconfirmed change - - - - - Automatically open the NavCoin client port on the router. This only works when your router supports UPnP and it is enabled. - Automatically open the NavCoin client port on the router. This only works when your router supports UPnP and it is enabled. - - - - Map port using &UPnP - Map port using &UPnP - - - - Connect to the NavCoin network through a SOCKS5 proxy. - - - - - &Connect through SOCKS5 proxy (default proxy): - - - - - - Proxy &IP: - Proxy &IP: - - - - - &Port: - &Port: - - - - - Port of the proxy (e.g. 9050) - Port of the proxy (e.g. 9050) - - - - Used for reaching peers via: - - - - - - - Shows, if the supplied default SOCKS5 proxy is used to reach peers via this network type. - - - - - IPv4 - - - - - IPv6 - - - - - Tor - - - - - Connect to the NavCoin network through a separate SOCKS5 proxy for Tor hidden services. - - - - - Use separate SOCKS5 proxy to reach peers via Tor hidden services: - - - - - &Window - &Window - - - - &Hide the icon from the system tray. - - - - - Hide tray icon - - - - - Show only a tray icon after minimizing the window. - Show only a tray icon after minimizing the window. - - - - &Minimize to the tray instead of the taskbar - &Minimize to the tray instead of the taskbar - - - - M&inimize on close - M&inimize on close - - - - &Display - &Display - - - - User Interface &language: - User Interface &language: - - - - The user interface language can be set here. This setting will take effect after restarting %1. - - - - - &Unit to show amounts in: - &Unit to show amounts in: - - - - Choose the default subdivision unit to show in the interface and when sending coins. - Choose the default subdivision unit to show in the interface and when sending coins. - - - - Whether to show coin control features or not. - - - - - &OK - &OK - - - - &Cancel - &Cancel - - - - default - default - - - - none - - - - - Confirm options reset - Confirm options reset - - - - - Client restart required to activate changes. - - - - - Client will be shut down. Do you want to proceed? - - - - - Configuration options - - - - - The configuration is used to specify advanced user options less any command-line or Qt options. Any command-line options will override this configuration file. - - - - - This change would require a client restart. - - - - - The supplied proxy address is invalid. - The supplied proxy address is invalid. - - - - OverviewPage - - - Form - Form - - - - Balance - - - - - - - - - TextLabel - - - - - Immature - - - - - Total - - - - - labelTotal - - - - - - Staking - - - - - This wallet is currently syncing. Your balance may not be accurate until it has completed - - - - - 24H: - - - - - 87 312.312 123 NAV - - - - - 7D - - - - - 1 312.312 NAV - - - - - 30D - - - - - - - 132 431.41 NAV - - - - - Cold Staking - - - - - 1Y - - - - - ALL - - - - - Transactions - - - - - Connecting to NavCoin network... - - - - - 32 active connections. - - - - - Last block: 800000 - - - - - Available: - - - - - Pending: - - - - - PaymentServer - - - - - - - - - Verify address - - - - - The provided address is invalid. - - - - - - Please check the address and try again. - - - - - The provided address does not refer to a key. - - - - - Wallet unlock was cancelled. - - - - - Private key for the provided address is not available. - - - - - Message signing failed. - - - - - - - - - - URI handling - - - - - 'navcoin://' is not a valid URI. Use 'navcoin:' instead. - - - - - Payment request fetch URL is invalid: %1 - - - - - Invalid OpenAlias address %1 - - - - - OpenAlias address %1 does not support DNS Sec - - - - - Invalid payment address %1 - - - - - URI cannot be parsed! This can be caused by an invalid NavCoin address or malformed URI parameters. - - - - - Payment request file handling - - - - - Payment request file cannot be read! This can be caused by an invalid payment request file. - - - - - - - - - - Payment request rejected - - - - - Payment request network doesn't match client network. - - - - - Payment request expired. - - - - - - - - - Payment request error - - - - - Payment request is not initialized. - - - - - Unverified payment requests to custom payment scripts are unsupported. - - - - - - Invalid payment request. - - - - - Requested payment amount of %1 is too small (considered dust). - - - - - Refund from %1 - - - - - Payment request %1 is too large (%2 bytes, allowed %3 bytes). - - - - - Error communicating with %1: %2 - - - - - Message signed. - - - - - Something went wrong. - - - - - Payment request cannot be parsed! - - - - - Bad response from server %1 - - - - - Network request error - - - - - Payment acknowledged - - - - - PeerTableModel - - - User Agent - - - - - Node/Service - - - - - Ping Time - - - - - QObject - - - Amount - Amount - - - - Enter a NavCoin address or OpenAlias address (e.g. %1) - - - - - %1 d - - - - - %1 h - - - - - %1 m - - - - - - %1 s - - - - - None - - - - - N/A - N/A - - - - %1 ms - - - - - QRImageWidget - - - &Save Image... - - - - - &Copy Image - - - - - Save QR Code - - - - - PNG Image (*.png) - - - - - RPCConsole - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - N/A - N/A - - - - Client version - Client version - - - - &Information - &Information - - - - Debug window - - - - - General - - - - - Using BerkeleyDB version - - - - - Datadir - - - - - Startup time - Startup time - - - - Network - Network - - - - Name - - - - - Number of connections - Number of connections - - - - Block chain - Block chain - - - - Current number of blocks - Current number of blocks - - - - Memory Pool - - - - - Current number of transactions - - - - - Memory usage - - - - - - Received - - - - - - Sent - - - - - &Peers - - - - - Banned peers - - - - - - - Select a peer to view detailed information. - - - - - Whitelisted - - - - - Direction - - - - - Version - - - - - Starting Block - - - - - Synced Headers - - - - - Synced Blocks - - - - - - User Agent - - - - - Open the %1 debug log file from the current data directory. This can take a few seconds for large log files. - - - - - Decrease font size - - - - - Increase font size - - - - - Services - - - - - Ban Score - - - - - Connection Time - - - - - Last Send - - - - - Last Receive - - - - - Ping Time - - - - - The duration of a currently outstanding ping. - - - - - Ping Wait - - - - - Time Offset - - - - - Last block time - Last block time - - - - &Open - &Open - - - - &Console - &Console - - - - &Network Traffic - - - - - &Clear - - - - - Totals - - - - - In: - - - - - Out: - - - - - Debug log file - Debug log file - - - - Clear console - Clear console - - - - &Disconnect Node - - - - - - - - Ban Node for - - - - - 1 &hour - - - - - 1 &day - - - - - 1 &week - - - - - 1 &year - - - - - &Unban Node - - - - - Welcome to the %1 RPC console. - - - - - Use up and down arrows to navigate history, and <b>Ctrl-L</b> to clear screen. - Use up and down arrows to navigate history, and <b>Ctrl-L</b> to clear screen. - - - - Type <b>help</b> for an overview of available commands. - Type <b>help</b> for an overview of available commands. - - - - %1 B - - - - - %1 KB - - - - - %1 MB - - - - - %1 GB - - - - - (node id: %1) - - - - - via %1 - - - - - - never - - - - - Inbound - - - - - Outbound - - - - - Yes - - - - - No - - - - - - Unknown - - - - - ReceiveCoinsDialog - - - &Amount: - - - - - &Label: - &Label: - - - - &Message: - - - - - Reuse one of the previously used receiving addresses. Reusing addresses has security and privacy issues. Do not use this unless re-generating a payment request made before. - - - - - R&euse an existing receiving address (not recommended) - - - - - - An optional message to attach to the payment request, which will be displayed when the request is opened. Note: The message will not be sent with the payment over the NavCoin network. - - - - - - An optional label to associate with the new receiving address. - - - - - Use this form to request payments. All fields are <b>optional</b>. - - - - - - An optional amount to request. Leave this empty or zero to not request a specific amount. - - - - - Clear all fields of the form. - - - - - Clear - - - - - Requested payments history - - - - - &Request payment - - - - - Show the selected request (does the same as double clicking an entry) - - - - - Show - - - - - Remove the selected entries from the list - - - - - Remove - - - - - Copy label - - - - - Copy message - - - - - Copy amount - - - - - ReceiveRequestDialog - - - QR Code - - - - - Copy &URI - - - - - Copy &Address - - - - - &Save Image... - - - - - Request payment to %1 - - - - - Payment information - - - - - URI - - - - - Address - - - - - Amount - Amount - - - - Label - - - - - Message - - - - - Resulting URI too long, try to reduce the text for label / message. - - - - - Error encoding URI into QR Code. - - - - - RecentRequestsTableModel - - - Date - Date - - - - Label - - - - - Message - - - - - (no label) - - - - - (no message) - - - - - (no amount requested) - - - - - Requested - - - - - SendCoinsDialog - - - - Send Coins - Send Coins - - - - Inputs... - - - - - automatically selected - - - - - Insufficient funds! - - - - - Quantity: - - - - - Bytes: - - - - - Amount: - - - - - Priority: - - - - - Fee: - - - - - After Fee: - - - - - Change: - - - - - If this is activated, but the change address is empty or invalid, change will be sent to a newly generated address. - - - - - Custom change address - - - - - per kilobyte - - - - - - If the custom fee is set to 1000 satoshis and the transaction is only 250 bytes, then "per kilobyte" only pays 250 satoshis in fee, while "total at least" pays 1000 satoshis. For transactions bigger than a kilobyte both pay by kilobyte. - - - - - total at least - - - - - - Paying only the minimum fee is just fine as long as there is less transaction volume than space in the blocks. But be aware that this can end up in a never confirming transaction once there is more demand for navcoin transactions than the network can process. - - - - - (read the tooltip) - - - - - Recommended: - - - - - Custom: - - - - - (Smart fee not initialized yet. This usually takes a few blocks...) - - - - - You don't have any NAVTech server added. - - - - - - Private payment - - - - - Manage NAVTech servers - - - - - Use full amount - - - - - Confirmation time: - - - - - normal - - - - - fast - - - - - Dust: - - - - - Balance: - Balance: - - - - Confirm the send action - Confirm the send action - - - - S&end - S&end - - - - Copy quantity - - - - - Copy amount - - - - - Copy fee - - - - - Copy after fee - - - - - Copy bytes - - - - - Copy priority - - - - - Copy dust - - - - - Copy change - - - - - NAVTech server returned a different number of addresses. - - - - - Something went wrong: - - - - - Do a normal transaction - - - - - Abort - - - - - Switch to normal transaction - - - - - Are you sure you want to do a normal transaction instead of a private payment? - - - - - Details of the payment would be publicly exposed on the blockchain. - - - - - This transaction will spend coins stored in a cold staking address.<br>You did not set any cold staking address as custom change destination, so those coins won't be locked anymore by the cold staking smart contract.<br><br>Do you still want to send this transaction? - - - - - Are you sure you want to send? - - - - - - - - %1 to %2 - - - - - added as transaction fee - - - - - The following fee will be deducted - - - - - Navtech server fee: - - - - - will be deducted as Navtech fee. - - - - - Total Amount %1 - - - - - or - - - - - - Confirm send coins - - - - - The recipient address is not valid. Please recheck. - - - - - The amount to pay must be larger than 0. - - - - - The amount exceeds your balance. - - - - - The total exceeds your balance when the %1 transaction fee is included. - - - - - Duplicate address found: addresses should only be used once each. - - - - - Transaction creation failed! - - - - - The transaction was rejected! This might happen if some of the coins in your wallet were already spent, such as if you used a copy of wallet.dat and coins were spent in the copy but not marked as spent here. - - - - - A fee higher than %1 is considered an absurdly high fee. - - - - - Payment request expired. - - - - - Pay only the required fee of %1 - - - - - Estimated to begin confirmation within %n block(s). - - - - - - - - Warning: Invalid NavCoin address - - - - - Warning: Unknown change address - - - - - (no label) - - - - - SendCoinsEntry - - - - A&mount: - A&mount: - - - - Pay &To: - Pay &To: - - - - &Label: - &Label: - - - - This is a normal payment. - - - - - The NavCoin address to send the payment to - - - - - Alt+A - Alt+A - - - - - Remove this entry - - - - - The fee will be deducted from the amount being sent. The recipient will receive less navcoins than you enter in the amount field. If multiple recipients are selected, the fee is split equally. - - - - - S&ubtract fee from amount - - - - - Message: - - - - - This is an unauthenticated payment request. - - - - - This is an authenticated payment request. - - - - - Enter a label for this address to add it to the list of used addresses - - - - - A message that was attached to the navcoin: URI which will be stored with the transaction for your reference. Note: This message will not be sent over the NavCoin network. - - - - - Save in Address Book - - - - - A&mount (NAV): - - - - - - Pay To: - - - - - - Memo: - - - - - Enter a label for this address to add it to your address book - - - - - SendConfirmationDialog - - - - Yes - - - - - ShutdownWindow - - - %1 is shutting down... - - - - - Do not shut down the computer until this window disappears. - - - - - SignVerifyMessageDialog - - - Signatures - Sign / Verify a Message - Signatures - Sign / Verify a Message - - - - &Sign Message - &Sign Message + + Client version + Client version - - You can sign messages/agreements with your addresses to prove you can receive navcoins sent to them. Be careful not to sign anything vague or random, as phishing attacks may try to trick you into signing your identity over to them. Only sign fully-detailed statements you agree to. - + + &Information + &Information - - The NavCoin address to sign the message with + + Debug window - - - Choose previously used address + + General - - - Alt+A - Alt+A + + Using BerkeleyDB version + - - Paste address from clipboard - Paste address from clipboard + + Datadir + - - Alt+P - Alt+P + + Startup time + Startup time - - Enter the message you want to sign here - Enter the message you want to sign here + + Network + Network - Signature - Signature - - - - Copy the current signature to the system clipboard - Copy the current signature to the system clipboard - - - - Sign the message to prove you own this NavCoin address - Sign the message to prove you own this NavCoin address - - - - Sign &Message - Sign &Message + Name + - - Reset all sign message fields - Reset all sign message fields + + Number of connections + Number of connections - - - Clear &All - Clear &All + + Block chain + Block chain - - &Verify Message - &Verify Message + + Current number of blocks + Current number of blocks - - Enter the receiver's address, message (ensure you copy line breaks, spaces, tabs, etc. exactly) and signature below to verify the message. Be careful not to read more into the signature than what is in the signed message itself, to avoid being tricked by a man-in-the-middle attack. Note that this only proves the signing party receives with the address, it cannot prove sendership of any transaction! + + Memory Pool - - The NavCoin address the message was signed with + + Current number of transactions - - Verify the message to ensure it was signed with the specified NavCoin address - Verify the message to ensure it was signed with the specified NavCoin address - - - - Verify &Message - Verify &Message - - - - Reset all verify message fields - Reset all verify message fields - - - - Click "Sign Message" to generate signature + + Memory usage - - - The entered address is invalid. + + + Received - - - - - Please check the address and try again. + + + Sent - - - The entered address does not refer to a key. + + &Peers - - Wallet unlock was cancelled. + + Banned peers - - Private key for the entered address is not available. + + Select a peer to view detailed information. - - Message signing failed. + + Whitelisted - - Message signed. + + Direction - - The signature could not be decoded. + + Version - - - Please check the signature and try again. + + Starting Block - - The signature did not match the message digest. + + Synced Headers - - Message verification failed. + + Synced Blocks - - Message verified. + + &Error Log - - - SplashScreen - - - [testnet] - [testnet] - - - - TrafficGraphWidget - - KB/s + + Copy Error Log contents to Clipboard - - - TransactionDesc - - - Open for %n more block(s) - - - - - - - Open until %1 + + Copy to Clipboard - - conflicted with a transaction with %1 confirmations + + + User Agent - - %1/offline + + Open the %1 debug log file from the current data directory. This can take a few seconds for large log files. - - 0/unconfirmed, %1 + + Decrease font size - - in memory pool + + Increase font size - - not in memory pool + + Services - - abandoned + + Ban Score - - %1/unconfirmed + + Connection Time - - %1 confirmations + + Last Send - - Status + + Last Receive - - , has not been successfully broadcast yet + + Ping Time - - - , broadcast through %n node(s) - - - - - - - - Date - Date - - - Source + + The duration of a currently outstanding ping. - - Generated + + Ping Wait - - - - From + + Time Offset - - unknown - + + Last block time + Last block time - - - - To - + + &Open + &Open - - own address - + + &Console + &Console - - - watch-only + + &Network Traffic - - label + + &Clear - - - - - - Credit + + Totals - - - matures in %n more block(s) - - - - - - - not accepted - + + Debug log file + Debug log file - - - - Debit - + + Clear console + Clear console + + + ReceiveCoinsDialog - - Total debit + + &Amount: - - Total credit - + + &Label: + &Label: - - Transaction fee + + &Message: - - Net amount + + Reuse one of the previously used receiving addresses. Reusing addresses has security and privacy issues. Do not use this unless re-generating a payment request made before. - - - Message + + R&euse an existing receiving address (not recommended) - - Comment + + + An optional message to attach to the payment request, which will be displayed when the request is opened. Note: The message will not be sent with the payment over the NavCoin network. - - Transaction ID + + + An optional label to associate with the new receiving address. - - Output index + + Use this form to request payments. All fields are <b>optional</b>. - - Merchant + + + An optional amount to request. Leave this empty or zero to not request a specific amount. - - Generated coins must mature %1 blocks before they can be spent. When you generated this block, it was broadcast to the network to be added to the block chain. If it fails to get into the chain, its state will change to "not accepted" and it won't be spendable. This may occasionally happen if another node generates a block within a few seconds of yours. + + Clear all fields of the form. - - Debug information + + Clear - - Transaction + + Requested payments history - - Inputs + + &Request payment - - Amount - Amount - - - - - true + + Show the selected request (does the same as double clicking an entry) - - - false + + Show - - - TransactionDescDialog - - This pane shows a detailed description of the transaction - This pane shows a detailed description of the transaction + + Remove the selected entries from the list + - - Details for %1 + + Remove - TransactionTableModel - - - Date - Date - - - - Type - - + ReceiveRequestDialog - - Label + + QR Code - - - Open for %n more block(s) - - - - - - - Open until %1 + + Copy &URI - - Offline + + Copy &Address - - Unconfirmed + + &Save Image... + + + SendCoinsDialog - - Abandoned - + + Send Coins + Send Coins - - Orphaned + + Inputs... - - Confirming (%1 of %2 recommended confirmations) + + automatically selected - - Confirmed (%1 confirmations) + + Insufficient funds! - - Conflicted + + Quantity: - - Immature (%1 confirmations, will be available after %2) + + Bytes: - - This block was not received by any other nodes and will probably not be accepted! + + Amount: - - Generated but not accepted + + Priority: - - - Sent to + + Fee: - - Community Fund Payment + + After Fee: - - - Private Payment + + Change: - - Received with + + If this is activated, but the change address is empty or invalid, change will be sent to a newly generated address. - - Received from + + Custom change address - - Payment to yourself + + per kilobyte - - watch-only + + + If the custom fee is set to 1000 satoshis and the transaction is only 250 bytes, then "per kilobyte" only pays 250 satoshis in fee, while "total at least" pays 1000 satoshis. For transactions bigger than a kilobyte both pay by kilobyte. - - Community Fund Contribution + + total at least - - (n/a) + + + Paying only the minimum fee is just fine as long as there is less transaction volume than space in the blocks. But be aware that this can end up in a never confirming transaction once there is more demand for navcoin transactions than the network can process. - - (no label) + + (read the tooltip) - - Transaction status. Hover over this field to show number of confirmations. + + Recommended: - - Date and time that the transaction was received. + + Custom: - - Type of transaction. + + (Smart fee not initialized yet. This usually takes a few blocks...) - - Whether or not a watch-only address is involved in this transaction. + + You don't have any NAVTech server added. - - User-defined intent/purpose of the transaction. + + Private payment - - Amount removed from or added to balance. + + Manage NAVTech servers - - - TransactionView - - - All + + Use full amount - - Today + + Confirmation time: - - This week + + normal - - This month + + fast - - Last month + + Dust: - - This year - + + Balance: + Balance: - - Range... - + + Confirm the send action + Confirm the send action - - Received with - + + S&end + S&end + + + SendCoinsEntry - - Sent to - + + + A&mount: + A&mount: - - To yourself - + + Pay &To: + Pay &To: - - Staked/generated - + + &Label: + &Label: - - Community Fund + + This is a normal payment. - - Other + + The NavCoin address to send the payment to - - Enter address or label to search - + + Alt+A + Alt+A - - Min amount + + + Remove this entry - - Abandon transaction + + The fee will be deducted from the amount being sent. The recipient will receive less navcoins than you enter in the amount field. If multiple recipients are selected, the fee is split equally. - - Copy address + + S&ubtract fee from amount - - Copy label + + Message: - - Copy amount + + This is an unauthenticated payment request. - - Copy transaction ID + + This is an authenticated payment request. - - Copy raw transaction + + Enter a label for this address to add it to the list of used addresses - - Copy full transaction details + + A message that was attached to the navcoin: URI which will be stored with the transaction for your reference. Note: This message will not be sent over the NavCoin network. - - Edit label + + Save in Address Book - - Show transaction details + + A&mount (NAV): - - Export Transaction History + + + Pay To: - - Comma separated file (*.csv) + + + Memo: + + + SendCommunityFundDialog - - Confirmed - Confirmed - - - - Watch-only + + Confirm Proposal Details - - Date - Date + + Are you sure you would like to create the following proposal? + - - Type + + Address: - - Label + + NfQJDyPrJ1DzyQQ29jQyewhS5qT3x3TMTG - - Address + + Proposal Hash: - - ID + + 1337 - - Exporting Failed + + Requested Amount: - - There was an error trying to save the transaction history to %1. + + 100 NAV / 100 EUR / 100 USD / 100 BTC - - Exporting Successful + + Description: - - The transaction history was successfully saved to %1. + + Placeholder Description - - Range: + + Proposal Duration: - - to + + 100 Days 100 Hours 100 Minutes - - - UnitDisplayStatusBarControl - - Unit to show amounts in. Click to select another unit. + + By submitting the proposal a X NAV deduction will occur from your wallet - - - WalletFrame - - No wallet has been loaded. + + Cancel - - - WalletModel - - Send Coins - Send Coins + + Yes + - WalletView + SignVerifyMessageDialog - - &Export - &Export + + Signatures - Sign / Verify a Message + Signatures - Sign / Verify a Message - - Export the data in the current tab to a file - Export the data in the current tab to a file + + &Sign Message + &Sign Message - - Backup Wallet + + You can sign messages/agreements with your addresses to prove you can receive navcoins sent to them. Be careful not to sign anything vague or random, as phishing attacks may try to trick you into signing your identity over to them. Only sign fully-detailed statements you agree to. - - Wallet Data (*.dat) + + The NavCoin address to sign the message with - - Backup Failed + + + Choose previously used address - - There was an error trying to save the wallet data to %1. - + + + Alt+A + Alt+A - - Backup Successful - + + Paste address from clipboard + Paste address from clipboard - - The wallet data was successfully saved to %1. - + + Alt+P + Alt+P - - Wallet is not a HD wallet. - + + Enter the message you want to sign here + Enter the message you want to sign here - - Show Master Private Key - + + Signature + Signature - - Master Private Key:<br><br>%1 - + + Copy the current signature to the system clipboard + Copy the current signature to the system clipboard - - Unable to retrieve HD master private key - + + Sign the message to prove you own this NavCoin address + Sign the message to prove you own this NavCoin address - - Import Private Key - + + Sign &Message + Sign &Message - - Private Key: - + + Reset all sign message fields + Reset all sign message fields - - Invalid private key encoding. - + + + Clear &All + Clear &All - - Private key outside allowed range. - + + &Verify Message + &Verify Message - - Address already added. + + Enter the receiver's address, message (ensure you copy line breaks, spaces, tabs, etc. exactly) and signature below to verify the message. Be careful not to read more into the signature than what is in the signed message itself, to avoid being tricked by a man-in-the-middle attack. Note that this only proves the signing party receives with the address, it cannot prove sendership of any transaction! - - Error adding key to wallet. + + The NavCoin address the message was signed with - - NavCoin needs to scan the chain... Please, wait. - + + Verify the message to ensure it was signed with the specified NavCoin address + Verify the message to ensure it was signed with the specified NavCoin address - - Private key correctly added! - + + Verify &Message + Verify &Message + + + + Reset all verify message fields + Reset all verify message fields + + + + TransactionDescDialog + + + This pane shows a detailed description of the transaction + This pane shows a detailed description of the transaction @@ -4409,21 +2279,6 @@ List old addresses - - - Action not available - - - - - Resulting URI too long, try to reduce the text for label / message. - - - - - Error encoding URI into QR Code. - - navcoin-core @@ -4433,27 +2288,27 @@ Options: - + Specify data directory Specify data directory - + Connect to a node to retrieve peer addresses, and disconnect Connect to a node to retrieve peer addresses, and disconnect - + Specify your own public address Specify your own public address - + Accept command line and JSON-RPC commands Accept command line and JSON-RPC commands - + If <category> is not supplied or if <category> = 1, output all debugging information. @@ -4498,17 +2353,17 @@ Run in the background as a daemon and accept commands - + Unable to start HTTP server. See debug log for details. - + Accept connections from outside (default: 1 if no -proxy or -connect) Accept connections from outside (default: 1 if no -proxy or -connect) - + NavCoin Core NavCoin Core @@ -4633,22 +2488,17 @@ - - Warning: The network does not appear to fully agree! Some miners appear to be experiencing issues. - Warning: The network does not appear to fully agree! Some miners appear to be experiencing issues. - - - - Warning: We do not appear to fully agree with our peers! You may need to upgrade, or other nodes may need to upgrade. - Warning: We do not appear to fully agree with our peers! You may need to upgrade, or other nodes may need to upgrade. + + Whitelist peers connecting from the given netmask or IP address. Can be specified multiple times. + - - Whitelist peers connecting from the given netmask or IP address. Can be specified multiple times. + + You are trying to import a new mnemonic but a wallet already exists. Please rename the existing wallet.dat before trying to import again. - + You need to rebuild the database using -reindex-chainstate to change -addressindex @@ -4724,6 +2574,11 @@ + Chain selection options: + + + + Change index out of range @@ -4757,6 +2612,16 @@ Corrupted block database detected Corrupted block database detected + + + Could not clean old Community Fund DB + + + + + Create a new wallet out of the specified mnemonic + + Debugging/Testing options: @@ -4993,7 +2858,12 @@ - + + Specify a customised navcoin address to accumulate the staking rewards. + + + + Specify wallet file (within data directory) Specify wallet file (within data directory) @@ -5007,6 +2877,11 @@ The source code is available from %s. + + + The specified language does not correspond to the mnemonic. + + Unable to bind to %s on this computer. %s is probably already running. @@ -5037,6 +2912,16 @@ Use header spam filter (default: %u) + + + Use the specified language for the mnemonic import + + + + + Use the test chain + + User Agent comment (%s) contains unsafe characters. @@ -5083,12 +2968,17 @@ - + + You specified a wrong mnemonic + + + + permitted provided that the following conditions are met: - + Allow JSON-RPC connections from specified source. Valid for <ip> are a single IP (e.g. 1.2.3.4), a network/netmask (e.g. 1.2.3.4/255.255.255.0) or a network/CIDR (e.g. 1.2.3.4/24). This option can be specified multiple times @@ -5313,12 +3203,12 @@ - + Whitelisted peers cannot be DoS banned and their transactions are always relayed, even if they are already in the mempool, useful e.g. for a gateway - + You need to rebuild the database using -reindex to go back to unpruned mode. This will redownload the entire blockchain @@ -5338,12 +3228,12 @@ - + Connect through SOCKS5 proxy - + Error reading from database, shutting down. @@ -5423,7 +3313,7 @@ Signing transaction failed - + The transaction amount is too small to pay the fee @@ -5473,7 +3363,7 @@ - + Username for JSON-RPC connections Username for JSON-RPC connections @@ -5488,7 +3378,7 @@ - + Zapping all transactions from wallet... @@ -5498,7 +3388,7 @@ - + Password for JSON-RPC connections Password for JSON-RPC connections @@ -5508,12 +3398,12 @@ Execute command when the best block changes (%s in cmd is replaced by block hash) - + Allow DNS lookups for -addnode, -seednode and -connect Allow DNS lookups for -addnode, -seednode and -connect - + Loading addresses... Loading addresses... @@ -5598,7 +3488,7 @@ - + Warning: Wallet file corrupt, data salvaged! Original %s saved as %s in %s; if your balance or transactions are incorrect you should restore from a backup. @@ -5613,7 +3503,7 @@ - + How many blocks to check at startup (default: %u, 0 = all) @@ -5673,7 +3563,7 @@ - + Specify configuration file (default: %s) @@ -5693,7 +3583,7 @@ - + Threshold for disconnecting misbehaving peers (default: %u) @@ -5703,7 +3593,7 @@ Unknown network specified in -onlynet: '%s' - + Insufficient funds Insufficient funds @@ -5713,17 +3603,17 @@ Loading block index... - + Add a node to connect to and attempt to keep the connection open Add a node to connect to and attempt to keep the connection open - + Loading wallet... Loading wallet... - + Cannot downgrade wallet Cannot downgrade wallet @@ -5733,7 +3623,7 @@ Cannot write default address - + Rescanning... Rescanning... @@ -5818,51 +3708,5 @@ Save - - - Remove Navtech server - - - - - You are about to remove the following Navtech server: - - - - - Are you sure? - - - - - Removed. - - - - - - Navtech server - - - - - Address: - - - - - Min amount: - - - - - Max amount: - - - - - Tx fee: - - diff --git a/src/qt/navcoinstrings.cpp b/src/qt/navcoinstrings.cpp index 08991072b..881fae42b 100644 --- a/src/qt/navcoinstrings.cpp +++ b/src/qt/navcoinstrings.cpp @@ -267,22 +267,19 @@ QT_TRANSLATE_NOOP("navcoin-core", "" "comes in the format: :$. A canonical python script is " "included in share/rpcuser. This option can be specified multiple times"), QT_TRANSLATE_NOOP("navcoin-core", "" -"Warning: The network does not appear to fully agree! Some miners appear to " -"be experiencing issues."), -QT_TRANSLATE_NOOP("navcoin-core", "" "Warning: Wallet file corrupt, data salvaged! Original %s saved as %s in %s; " "if your balance or transactions are incorrect you should restore from a " "backup."), QT_TRANSLATE_NOOP("navcoin-core", "" -"Warning: We do not appear to fully agree with our peers! You may need to " -"upgrade, or other nodes may need to upgrade."), -QT_TRANSLATE_NOOP("navcoin-core", "" "Whitelist peers connecting from the given netmask or IP address. Can be " "specified multiple times."), QT_TRANSLATE_NOOP("navcoin-core", "" "Whitelisted peers cannot be DoS banned and their transactions are always " "relayed, even if they are already in the mempool, useful e.g. for a gateway"), QT_TRANSLATE_NOOP("navcoin-core", "" +"You are trying to import a new mnemonic but a wallet already exists. Please " +"rename the existing wallet.dat before trying to import again."), +QT_TRANSLATE_NOOP("navcoin-core", "" "You need to rebuild the database using -reindex to go back to unpruned " "mode. This will redownload the entire blockchain"), QT_TRANSLATE_NOOP("navcoin-core", "" @@ -318,6 +315,7 @@ QT_TRANSLATE_NOOP("navcoin-core", "Block creation options:"), QT_TRANSLATE_NOOP("navcoin-core", "Cannot downgrade wallet"), QT_TRANSLATE_NOOP("navcoin-core", "Cannot resolve -%s address: '%s'"), QT_TRANSLATE_NOOP("navcoin-core", "Cannot write default address"), +QT_TRANSLATE_NOOP("navcoin-core", "Chain selection options:"), QT_TRANSLATE_NOOP("navcoin-core", "Change index out of range"), QT_TRANSLATE_NOOP("navcoin-core", "Clock options:"), QT_TRANSLATE_NOOP("navcoin-core", "Connect only to the specified node(s)"), @@ -327,6 +325,8 @@ QT_TRANSLATE_NOOP("navcoin-core", "Connection options:"), QT_TRANSLATE_NOOP("navcoin-core", "Copyright (C) %i-%i"), QT_TRANSLATE_NOOP("navcoin-core", "Copyright (c) 2014-2017, The Monero Project"), QT_TRANSLATE_NOOP("navcoin-core", "Corrupted block database detected"), +QT_TRANSLATE_NOOP("navcoin-core", "Could not clean old Community Fund DB"), +QT_TRANSLATE_NOOP("navcoin-core", "Create a new wallet out of the specified mnemonic"), QT_TRANSLATE_NOOP("navcoin-core", "Debugging/Testing options:"), QT_TRANSLATE_NOOP("navcoin-core", "Defines the staker vote to be attached to found blocks."), QT_TRANSLATE_NOOP("navcoin-core", "Do not load the wallet and disable wallet RPC calls"), @@ -415,6 +415,7 @@ QT_TRANSLATE_NOOP("navcoin-core", "Sets the default sleep for the staking thread QT_TRANSLATE_NOOP("navcoin-core", "Show all debugging options (usage: --help -help-debug)"), QT_TRANSLATE_NOOP("navcoin-core", "Shrink debug.log file on client startup (default: 1 when no -debug)"), QT_TRANSLATE_NOOP("navcoin-core", "Signing transaction failed"), +QT_TRANSLATE_NOOP("navcoin-core", "Specify a customised navcoin address to accumulate the staking rewards."), QT_TRANSLATE_NOOP("navcoin-core", "Specify configuration file (default: %s)"), QT_TRANSLATE_NOOP("navcoin-core", "Specify connection timeout in milliseconds (minimum: 1, default: %d)"), QT_TRANSLATE_NOOP("navcoin-core", "Specify data directory"), @@ -424,6 +425,7 @@ QT_TRANSLATE_NOOP("navcoin-core", "Specify your own public address"), QT_TRANSLATE_NOOP("navcoin-core", "Spend unconfirmed change when sending transactions (default: %u)"), QT_TRANSLATE_NOOP("navcoin-core", "Synchronizing clock..."), QT_TRANSLATE_NOOP("navcoin-core", "The source code is available from %s."), +QT_TRANSLATE_NOOP("navcoin-core", "The specified language does not correspond to the mnemonic."), QT_TRANSLATE_NOOP("navcoin-core", "The transaction amount is too small to pay the fee"), QT_TRANSLATE_NOOP("navcoin-core", "This is experimental software."), QT_TRANSLATE_NOOP("navcoin-core", "Threshold for disconnecting misbehaving peers (default: %u)"), @@ -443,6 +445,8 @@ QT_TRANSLATE_NOOP("navcoin-core", "Unsupported argument -tor found, use -onion." QT_TRANSLATE_NOOP("navcoin-core", "Upgrade wallet to latest format on startup"), QT_TRANSLATE_NOOP("navcoin-core", "Use UPnP to map the listening port (default: %u)"), QT_TRANSLATE_NOOP("navcoin-core", "Use header spam filter (default: %u)"), +QT_TRANSLATE_NOOP("navcoin-core", "Use the specified language for the mnemonic import"), +QT_TRANSLATE_NOOP("navcoin-core", "Use the test chain"), QT_TRANSLATE_NOOP("navcoin-core", "User Agent comment (%s) contains unsafe characters."), QT_TRANSLATE_NOOP("navcoin-core", "Username for JSON-RPC connections"), QT_TRANSLATE_NOOP("navcoin-core", "Uses the devnet network"), @@ -455,6 +459,7 @@ QT_TRANSLATE_NOOP("navcoin-core", "Wallet needed to be rewritten: restart %s to QT_TRANSLATE_NOOP("navcoin-core", "Wallet options:"), QT_TRANSLATE_NOOP("navcoin-core", "Warning"), QT_TRANSLATE_NOOP("navcoin-core", "Whether to operate in a blocks only mode (default: %u)"), +QT_TRANSLATE_NOOP("navcoin-core", "You specified a wrong mnemonic"), QT_TRANSLATE_NOOP("navcoin-core", "Zapping all transactions from wallet..."), QT_TRANSLATE_NOOP("navcoin-core", "ZeroMQ notification options:"), QT_TRANSLATE_NOOP("navcoin-core", "permitted provided that the following conditions are met:"), From 2baa638a78086b5bec0fc6fdb4b1413333ab82f8 Mon Sep 17 00:00:00 2001 From: alex v Date: Fri, 2 Aug 2019 20:04:05 +0200 Subject: [PATCH 11/17] batchwrite simplification --- src/coins.cpp | 24 ++++++------------------ 1 file changed, 6 insertions(+), 18 deletions(-) diff --git a/src/coins.cpp b/src/coins.cpp index 31fe59eb6..7a8c716d8 100644 --- a/src/coins.cpp +++ b/src/coins.cpp @@ -373,29 +373,15 @@ bool CCoinsViewCache::BatchWrite(CCoinsMap &mapCoins, CProposalMap &mapProposals } for (CProposalMap::iterator it = mapProposals.begin(); it != mapProposals.end();) { - if (it->second.IsNull()) { - CProposalMap::iterator itUs = cacheProposals.find(it->first); - if (itUs != cacheProposals.end()) { - cacheProposals.erase(itUs); - } - } else { - CProposal& entry = cacheProposals[it->first]; - entry.swap(it->second); - } + CProposal& entry = cacheProposals[it->first]; + entry.swap(it->second); CProposalMap::iterator itOld = it++; mapProposals.erase(itOld); } for (CPaymentRequestMap::iterator it = mapPaymentRequests.begin(); it != mapPaymentRequests.end();) { - if (it->second.IsNull()) { - CPaymentRequestMap::iterator itUs = cachePaymentRequests.find(it->first); - if (itUs != cachePaymentRequests.end()) { - cachePaymentRequests.erase(itUs); - } - } else { - CPaymentRequest& entry = cachePaymentRequests[it->first]; - entry.swap(it->second); - } + CPaymentRequest& entry = cachePaymentRequests[it->first]; + entry.swap(it->second); CPaymentRequestMap::iterator itOld = it++; mapPaymentRequests.erase(itOld); } @@ -407,6 +393,8 @@ bool CCoinsViewCache::BatchWrite(CCoinsMap &mapCoins, CProposalMap &mapProposals bool CCoinsViewCache::Flush() { bool fOk = base->BatchWrite(cacheCoins, cacheProposals, cachePaymentRequests, hashBlock); cacheCoins.clear(); + cacheProposals.clear(); + cachePaymentRequests.clear(); cachedCoinsUsage = 0; return fOk; } From e15f607a5062facb99f33f4bff8ba8368650c99c Mon Sep 17 00:00:00 2001 From: alex v Date: Thu, 8 Aug 2019 17:45:59 +0200 Subject: [PATCH 12/17] optimize cfundvote function --- src/consensus/cfund.cpp | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/consensus/cfund.cpp b/src/consensus/cfund.cpp index aa8f00c21..a22f9148c 100644 --- a/src/consensus/cfund.cpp +++ b/src/consensus/cfund.cpp @@ -623,9 +623,6 @@ void CFund::CFundStep(const CValidationState& state, CBlockIndex *pindexNew, con for(unsigned int i = 0; i < pindexblock->vProposalVotes.size(); i++) { - if(!view.GetProposal(pindexblock->vProposalVotes[i].first, proposal)) - continue; - if(vSeen.count(pindexblock->vProposalVotes[i].first) == 0) { if(vCacheProposalsToUpdate.count(pindexblock->vProposalVotes[i].first) == 0) @@ -642,20 +639,6 @@ void CFund::CFundStep(const CValidationState& state, CBlockIndex *pindexNew, con for(unsigned int i = 0; i < pindexblock->vPaymentRequestVotes.size(); i++) { - if(!view.GetPaymentRequest(pindexblock->vPaymentRequestVotes[i].first, prequest)) - continue; - - if(!view.GetProposal(prequest.proposalhash, proposal)) - continue; - - if (mapBlockIndex.count(proposal.blockhash) == 0) - continue; - - CBlockIndex* pindexblockparent = mapBlockIndex[proposal.blockhash]; - - if(pindexblockparent == NULL) - continue; - if(vSeen.count(pindexblock->vPaymentRequestVotes[i].first) == 0) { if(vCachePaymentRequestToUpdate.count(pindexblock->vPaymentRequestVotes[i].first) == 0) From c9cad0c88fc2a4e85f9a1477d379c6d929a7486d Mon Sep 17 00:00:00 2001 From: alex v Date: Sat, 17 Aug 2019 21:03:19 +0200 Subject: [PATCH 13/17] flush db after migration and set flag --- src/init.cpp | 23 ++++++++--------------- 1 file changed, 8 insertions(+), 15 deletions(-) diff --git a/src/init.cpp b/src/init.cpp index 80e684df1..dac925f6d 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1663,20 +1663,16 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) if (pblocktree->GetProposalIndex(vProposals)) { - if (vProposals.size() > 0) + bool fMigrated = true; + if (!pblocktree->ReadFlag("proposals_migrated", fMigrated) || !fMigrated) { LogPrintf("Importing %d proposals to the new CoinsDB...\n", vProposals.size()); - std::vector> vToRemove; for (auto& it: vProposals) { pcoinsTip->AddProposal(it); - vToRemove.push_back(make_pair(it.hash, CProposal())); - } - if (!pblocktree->UpdateProposalIndex(vToRemove)) - { - strLoadError = _("Could not clean old Community Fund DB"); - break; } + pcoinsTip->Flush(); + pblocktree->WriteFlag("proposals_migrated", true); } } @@ -1684,20 +1680,17 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) if (pblocktree->GetPaymentRequestIndex(vPaymentRequests)) { - if (vPaymentRequests.size() > 0) + bool fMigrated = true; + if (!pblocktree->ReadFlag("prequests_migrated", fMigrated) || !fMigrated) { LogPrintf("Importing %d payment requests to the new CoinsDB...\n", vPaymentRequests.size()); std::vector> vToRemove; for (auto& it: vPaymentRequests) { pcoinsTip->AddPaymentRequest(it); - vToRemove.push_back(make_pair(it.hash, CPaymentRequest())); - } - if (!pblocktree->UpdatePaymentRequestIndex(vToRemove)) - { - strLoadError = _("Could not clean old Community Fund DB"); - break; } + pcoinsTip->Flush(); + pblocktree->WriteFlag("proposals_migrated", true); } } From c3bd1c865ea4121a97d2e57ad1b31a179801ec62 Mon Sep 17 00:00:00 2001 From: alex v Date: Sat, 17 Aug 2019 21:04:22 +0200 Subject: [PATCH 14/17] fix typo --- src/init.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/init.cpp b/src/init.cpp index dac925f6d..60dc25d52 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1690,7 +1690,7 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) pcoinsTip->AddPaymentRequest(it); } pcoinsTip->Flush(); - pblocktree->WriteFlag("proposals_migrated", true); + pblocktree->WriteFlag("prequests_migrated", true); } } From efa179d19e1f11a85cad0309ec75e02327f85cbf Mon Sep 17 00:00:00 2001 From: alex v Date: Sat, 17 Aug 2019 21:55:54 +0200 Subject: [PATCH 15/17] do not use flag --- src/init.cpp | 25 ++++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/src/init.cpp b/src/init.cpp index 60dc25d52..d14057101 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1663,16 +1663,20 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) if (pblocktree->GetProposalIndex(vProposals)) { - bool fMigrated = true; - if (!pblocktree->ReadFlag("proposals_migrated", fMigrated) || !fMigrated) + CProposalMap mapProposals; + pcoinsTip->GetAllProposals(mapProposals); + if (vProposals.size() > 0 && mapProposals.size() == 0) { LogPrintf("Importing %d proposals to the new CoinsDB...\n", vProposals.size()); for (auto& it: vProposals) { pcoinsTip->AddProposal(it); } - pcoinsTip->Flush(); - pblocktree->WriteFlag("proposals_migrated", true); + if (!pcoinsTip->Flush()) + { + strLoadError = _("Failed to write to coin database"); + break; + } } } @@ -1680,17 +1684,20 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) if (pblocktree->GetPaymentRequestIndex(vPaymentRequests)) { - bool fMigrated = true; - if (!pblocktree->ReadFlag("prequests_migrated", fMigrated) || !fMigrated) + CPaymentRequestMap mapPaymentRequest; + pcoinsTip->GetAllPaymentRequests(mapPaymentRequest); + if (vPaymentRequests.size() > 0 && mapPaymentRequest.size() == 0) { LogPrintf("Importing %d payment requests to the new CoinsDB...\n", vPaymentRequests.size()); - std::vector> vToRemove; for (auto& it: vPaymentRequests) { pcoinsTip->AddPaymentRequest(it); } - pcoinsTip->Flush(); - pblocktree->WriteFlag("prequests_migrated", true); + if (!pcoinsTip->Flush()) + { + strLoadError = _("Failed to write to coin database"); + break; + } } } From 275386c2fc6783f572e4cb5fab3c38b2e2ad0bef Mon Sep 17 00:00:00 2001 From: alex v Date: Sat, 17 Aug 2019 22:02:03 +0200 Subject: [PATCH 16/17] flush not necessary --- src/init.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/init.cpp b/src/init.cpp index d14057101..29580299c 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1672,11 +1672,6 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) { pcoinsTip->AddProposal(it); } - if (!pcoinsTip->Flush()) - { - strLoadError = _("Failed to write to coin database"); - break; - } } } @@ -1693,11 +1688,6 @@ bool AppInit2(boost::thread_group& threadGroup, CScheduler& scheduler) { pcoinsTip->AddPaymentRequest(it); } - if (!pcoinsTip->Flush()) - { - strLoadError = _("Failed to write to coin database"); - break; - } } } From eb75e2a221e9df0102a575cd2b6f72c985a186c4 Mon Sep 17 00:00:00 2001 From: Craig Date: Fri, 23 Aug 2019 15:42:31 +1200 Subject: [PATCH 17/17] updated release notes --- doc/release-notes/release-notes-4.7.0.md | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/release-notes/release-notes-4.7.0.md b/doc/release-notes/release-notes-4.7.0.md index 863745d84..849841f76 100644 --- a/doc/release-notes/release-notes-4.7.0.md +++ b/doc/release-notes/release-notes-4.7.0.md @@ -83,4 +83,10 @@ When the wallet starts and detects it is still catching up to the latest block a - Added an additional LOCK for cs_main <[Pull Request 558](https://github.com/navcoin/navcoin-core/pull/558)> <[Commit ac5df35](https://github.com/navcoin/navcoin-core/commit/ac5df354f3b9c961a60b581284c1748a275bef5d)> - Added an additional LOCK for cs_main <[Pull Request 558](https://github.com/navcoin/navcoin-core/pull/558)> <[Commit ac5df35](https://github.com/navcoin/navcoin-core/commit/ac5df354f3b9c961a60b581284c1748a275bef5d)> - new SVG icons <[Pull Request 555](https://github.com/navcoin/navcoin-core/pull/555)> <[Commit 9619bc4](https://github.com/navcoin/navcoin-core/commit/9619bc4352af42ab9234664d5836ede23294a69c)> -- Added a lock before we call GetTxStakeAmount() <[Pull Request 564](https://github.com/navcoin/navcoin-core/pull/564)> <[Commit bfeb225](https://github.com/navcoin/navcoin-core/commit/bfeb22567f7a77e65431ccc3802cdc925428709d)> \ No newline at end of file +- Added a lock before we call GetTxStakeAmount() <[Pull Request 564](https://github.com/navcoin/navcoin-core/pull/564)> <[Commit bfeb225](https://github.com/navcoin/navcoin-core/commit/bfeb22567f7a77e65431ccc3802cdc925428709d)> +- Fixed crash when selecting a currency with no price data <[Pull Request 571](https://github.com/navcoin/navcoin-core/pull/571)> <[Commit 4337157](https://github.com/navcoin/navcoin-core/commit/43371570b5060960ae92c2b22b53355d931ce45f)> +- vector logo and icon <[Pull Request 575](https://github.com/navcoin/navcoin-core/pull/575)> <[Commit 8cb91db](https://github.com/navcoin/navcoin-core/commit/8cb91dbe3b17a655020a47c221ea123ca46c3cf9)> +- Added a lock (Crashed the wallet when voting from details dialog) <[Pull Request 577](https://github.com/navcoin/navcoin-core/pull/577)> <[Commit f2b924e](https://github.com/navcoin/navcoin-core/commit/f2b924ef59cf2ae19fa8106ca3b71c5e7cd0a2c3)> +- Updated a lock on LoadWallet to fix a crash on wallet rescan <[Pull Request 582](https://github.com/navcoin/navcoin-core/pull/582)> <[Commit 06109e8](https://github.com/navcoin/navcoin-core/commit/06109e8356ebf741a7c9701adde1a20d234e5c1c)> +- Coldstaking pool fee <[Pull Request 523](https://github.com/navcoin/navcoin-core/pull/523)> <[Commit f449aec](https://github.com/navcoin/navcoin-core/commit/f449aeca138273151ded55b2ec14f9c97ca3f3dd)> +- OSX pink menu bug <[Pull Request 589](https://github.com/navcoin/navcoin-core/pull/589)> <[Commit e087919](https://github.com/navcoin/navcoin-core/commit/e0879195bdf5373e5b1fcf4e970af0a8815660f6)> \ No newline at end of file