Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an additional LOCK for cs_main #558

Conversation

mxaddict
Copy link
Contributor

@mxaddict mxaddict commented Jul 7, 2019

This fixes a bug I found in the RC build

Wallet would crash in certain scenarios due to a missing lock on cs_main

Copy link
Member

@aguycalled aguycalled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

untested

@mxaddict
Copy link
Contributor Author

mxaddict commented Jul 7, 2019

Found another missing lock, would sometimes crash when setting votes as cs_main lock was not help when calling CFund::VoteProposal

@mxaddict mxaddict changed the title Added an additional LOCK for cs_main in rpcwallet Added an additional LOCK for cs_main Jul 7, 2019
Copy link
Member

@proletesseract proletesseract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Unit tests passing in travis

@proletesseract proletesseract merged commit ac5df35 into navcoin:master Jul 7, 2019
@proletesseract proletesseract mentioned this pull request Jul 8, 2019
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants