Skip to content

Fixed crash when selecting a currency with no price data #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2019
Merged

Fixed crash when selecting a currency with no price data #571

merged 1 commit into from
Jul 21, 2019

Conversation

mxaddict
Copy link
Contributor

closes #570

@proletesseract
Copy link
Member

testing today

proletesseract
proletesseract approved these changes Jul 21, 2019
View reviewed changes
Copy link
Member

@proletesseract proletesseract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how to test the crash scenario, but it compiles and runs fine for me.

@proletesseract proletesseract merged commit 4337157 into navcoin:master Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@proletesseract proletesseract proletesseract approved these changes

@aguycalled aguycalled aguycalled approved these changes

@dy5es41 dy5es41 Awaiting requested review from dy5es41

@marcus290 marcus290 Awaiting requested review from marcus290

@red010b37 red010b37 Awaiting requested review from red010b37

Assignees
No one assigned
Labels
needed for final release ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

current master/v4.7.0 version crashes in windows
3 participants
@mxaddict @proletesseract @aguycalled