Repository navigation
Sort available coins for staking by coin age descending - #578
Merged
Merged
Conversation
dantudor
changed the title
aguycalled
reviewed
Aug 2, 2019
| } | ||
| } | ||
|
|
||
| std::sort(vCoins.begin(), vCoins.end(), sortByCoinAgeDescending()); |
Member
There was a problem hiding this comment.
I would add here if (GetBoolArg("-stakingsortbycoinage",false))
Contributor
There was a problem hiding this comment.
I agree with this flag check
@dantudor can you add this flag check, then I'll approve PR
aguycalled
approved these changes
Aug 2, 2019
Contributor
|
testedACK, waiting for requested change to approve |
Contributor
|
I added the flag check that @aguycalled suggested |
mxaddict
self-requested a review
September 26, 2019 17:00
mxaddict
approved these changes
Sep 26, 2019
mxaddict
left a comment
mxaddict
left a comment
Contributor
There was a problem hiding this comment.
testedACK (Ubuntu 19.10)
Contributor
|
Will merge after Travis builds are done |
Contributor
|
This change looks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation for sorting the available coins for staking by coin age decending.