Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX pink menu bug #589

Merged
merged 11 commits into from
Aug 21, 2019
Merged

Conversation

proletesseract
Copy link
Member

Fixes #521

Screen Shot 2019-08-20 at 9 01 14 PM

OSX build: https://builds.navcore.org/521-osx-png-bug

Gitian building the other OS binaries now to smoke test it doesn't break the layout on other operating systems.

@aguycalled
Copy link
Member

image

image

@aguycalled
Copy link
Member

The menu icons show with an appreciable lower resolution, but this can be a temporary valid solution until the whole redesign is finished. Would be interesting to confirm how it shows in other OS/resolutions.

@proletesseract
Copy link
Member Author

@aguycalled yeah Juguelio reported the same, it works but its a bit blurry.

I have the other OS's compiled here now, so ill try to get people on discord to try it out:

https://builds.navcore.org/521-osx-png-bug/

@proletesseract
Copy link
Member Author

proletesseract commented Aug 20, 2019

Ubuntu:
unknown (5)

Windows 7:
unknown (6)

Courtesy of salmonskinroll

@proletesseract
Copy link
Member Author

and i agree, this is a quick interim fix before replacing the menu with @mxaddict's work. I could spend more time going down the pxmap approach but i dont think its worth the effort.

Copy link
Contributor

@mxaddict mxaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested Gitian Build on windows 10, looks fine.

@proletesseract proletesseract merged commit e087919 into navcoin:master Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSX gitian build of master branch is funky looking
3 participants