OSX pink menu bug #589
Merged
OSX pink menu bug #589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebasing to navcoin:master
rebasing to upstream master
rebasing to navcoin:master
merging in navcoin#549
merging navcoin#556 from navcoin master
Merging navcoin master
merging master into 4.7.0
updated PNG's and changed border-image to background
adding bg colors
removing repeat-y
Member
|
|
Member
|
The menu icons show with an appreciable lower resolution, but this can be a temporary valid solution until the whole redesign is finished. Would be interesting to confirm how it shows in other OS/resolutions. |
aguycalled
approved these changes
Aug 20, 2019
Member
Author
|
@aguycalled yeah Juguelio reported the same, it works but its a bit blurry. I have the other OS's compiled here now, so ill try to get people on discord to try it out: |
Member
Author
|
Ubuntu: Windows 7: Courtesy of salmonskinroll |
Member
Author
|
and i agree, this is a quick interim fix before replacing the menu with @mxaddict's work. I could spend more time going down the pxmap approach but i dont think its worth the effort. |
mxaddict
approved these changes
Aug 21, 2019
Contributor
mxaddict
left a comment
mxaddict
left a comment
There was a problem hiding this comment.
tested Gitian Build on windows 10, looks fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #521
OSX build: https://builds.navcore.org/521-osx-png-bug
Gitian building the other OS binaries now to smoke test it doesn't break the layout on other operating systems.