Skip to content

Fix random RPC tests failing - #612

Merged
mxaddict merged 4 commits into
navcoin:masterfrom
aguycalled:fix-random-rpc-test-fail
Oct 17, 2019
Merged

Fix random RPC tests failing#612
mxaddict merged 4 commits into
navcoin:masterfrom
aguycalled:fix-random-rpc-test-fail

Conversation

@aguycalled

Copy link
Copy Markdown
Member

This PR fixes a few RPC tests which were randomly failing.

@mxaddict

Copy link
Copy Markdown
Contributor

Looks like coldstaking_fee.py is failing on this PR

@aguycalled

Copy link
Copy Markdown
Member Author

included fix for coldstaking_fee.py

@mxaddict
mxaddict force-pushed the fix-random-rpc-test-fail branch from b700f63 to 05a9ab3 Compare October 16, 2019 19:50
@mxaddict

Copy link
Copy Markdown
Contributor

Changes make sense, build passes

@chasingkirkjufell

Copy link
Copy Markdown
Contributor

one test failed.

stakingaddress.py:
Initializing test directory /tmp/test09ema07u/6
Restart node with staking address option ...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
Assertion failed: 0E-8 != 2
Stopping nodes
Not cleaning up dir /tmp/test09ema07u/6
Failed

stderr:
File "/home/cluster/navcoin-core/qa/rpc-tests/test_framework/test_framework.py", line 149, in main
self.run_test()
File "/home/cluster/navcoin-core/qa/rpc-tests/stakingaddress.py", line 42, in run_test
assert_equal(self.nodes[0].gettransaction(stake_tx)["details"][0]["amount"], 2)
File "/home/cluster/navcoin-core/qa/rpc-tests/test_framework/util.py", line 507, in assert_equal
raise AssertionError("%s != %s"%(str(thing1),str(thing2)))

Pass: False, Duration: 79 s

@aguycalled

Copy link
Copy Markdown
Member Author

@chasingkirkjufell i think you are running the tests from other branch. line 42 has been changed in this pr

@chasingkirkjufell

Copy link
Copy Markdown
Contributor

You are right, that's a little weird though. Testing the correct branch now.

@chasingkirkjufell chasingkirkjufell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested the tests 5-10x each and all passed.

@chasingkirkjufell
chasingkirkjufell self-requested a review October 17, 2019 14:14

@chasingkirkjufell chasingkirkjufell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

misclicked

@mxaddict
mxaddict merged commit 902970a into navcoin:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants