Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix random RPC tests failing #612

Merged
merged 4 commits into from Oct 17, 2019
Merged

Conversation

@aguycalled
Copy link
Member

aguycalled commented Oct 16, 2019

This PR fixes a few RPC tests which were randomly failing.

@mxaddict

This comment has been minimized.

Copy link
Contributor

mxaddict commented Oct 16, 2019

Looks like coldstaking_fee.py is failing on this PR

@aguycalled

This comment has been minimized.

Copy link
Member Author

aguycalled commented Oct 16, 2019

included fix for coldstaking_fee.py

@mxaddict mxaddict force-pushed the aguycalled:fix-random-rpc-test-fail branch from b700f63 to 05a9ab3 Oct 16, 2019
@mxaddict

This comment has been minimized.

Copy link
Contributor

mxaddict commented Oct 16, 2019

Changes make sense, build passes

@chasingkirkjufell

This comment has been minimized.

Copy link

chasingkirkjufell commented Oct 16, 2019

one test failed.

stakingaddress.py:
Initializing test directory /tmp/test09ema07u/6
Restart node with staking address option ...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
waiting for a new block...
Assertion failed: 0E-8 != 2
Stopping nodes
Not cleaning up dir /tmp/test09ema07u/6
Failed

stderr:
File "/home/cluster/navcoin-core/qa/rpc-tests/test_framework/test_framework.py", line 149, in main
self.run_test()
File "/home/cluster/navcoin-core/qa/rpc-tests/stakingaddress.py", line 42, in run_test
assert_equal(self.nodes[0].gettransaction(stake_tx)["details"][0]["amount"], 2)
File "/home/cluster/navcoin-core/qa/rpc-tests/test_framework/util.py", line 507, in assert_equal
raise AssertionError("%s != %s"%(str(thing1),str(thing2)))

Pass: False, Duration: 79 s

@aguycalled

This comment has been minimized.

Copy link
Member Author

aguycalled commented Oct 17, 2019

@chasingkirkjufell i think you are running the tests from other branch. line 42 has been changed in this pr

@chasingkirkjufell

This comment has been minimized.

Copy link

chasingkirkjufell commented Oct 17, 2019

You are right, that's a little weird though. Testing the correct branch now.

Copy link

chasingkirkjufell left a comment

tested the tests 5-10x each and all passed.

@chasingkirkjufell chasingkirkjufell self-requested a review Oct 17, 2019
Copy link

chasingkirkjufell left a comment

misclicked

@mxaddict mxaddict merged commit 902970a into navcoin:master Oct 17, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.