Mnemonic Startup GUI by KolbyML · Pull Request #659 · navcoin/navcoin-core

KolbyML · 2020-02-16T01:11:15Z

This PR was for the #451 a bounty Navcoin had to add a Startup GUI which allowed for the ability to restore and create wallets with Mnemonic words. Mnemonic words are like a read readable master key for BIP32 a bitcoin proposal to make key generation derived from one key or a masterkey instead of being randomly created as before hand.

This page is the first page and it allows for the user to select Restore wallet an option to restore a wallet with your mnemonic words or Create a new wallet if you have never created a wallet that supports Mnemonic words before

The restore page is where you would enter your mnemonic words if you were restoring it from the mnemonic words you kept safe. If a word is spelt incorrectly or invalid the box will have a red outline, if it is correct it will have a purple outline.

The reveal page. This page is shown after the user selects Create New Wallet and shows the user his Mnemonic words that he must write down and keep safe.

The sort page. This page is shown after the reveal page and it is used to confirm whether the user has written down his words.

The address the bounty should be paid to NdTrSEe6bMMvVwNUimxs2BiWkX5Xn9MW7o

mxaddict · 2020-02-16T01:34:35Z

I'm out of the house right now, will review when I get home.

…

On Sun, Feb 16, 2020, 09:33 alex v. ***@***.***> wrote: @aguycalled <https://github.com/aguycalled> requested your review on: #659 <#659> Mnemonic Startup GUI. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#659?email_source=notifications&email_token=AAIDAKPAD2GGS3MKXDMWXUTRDCJWXA5CNFSM4KV6CSV2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWVC5LGA#event-3041252760>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDAKK2BB3XIIRIPKY4KBTRDCJWXANCNFSM4KV6CSVQ> .

chasingkirkjufell · 2020-02-16T01:38:30Z

Same as mxaddict.

navbuilder · 2020-02-16T02:31:12Z

A new build of 5ae6e0d has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

navbuilder · 2020-02-16T03:53:30Z

A new build of 208b4f0 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

chasingkirkjufell · 2020-02-16T04:32:00Z

Gitian build of 208b4f0 on Ubuntu 19.04 64GB RAM.

Observation 1:
Wallet client shows welcome page even though wallet.dat was previously created. Users do not have to option to skip the welcome page but only have to choose between creating a new wallet vs importing an old one.

Creating an wallet when wallet.dat already exists actually displays the mnemonic seeds of the existing wallet instead of a new wallet.

Expectation 1:
Wallet client should not have a welcome page when wallet.dat already exists.

Observation 2:
When wallet.dat does not exist, after re-entering all the mnemonic seeds, the wallet will fail to boot up and show
key.cpp:148: CPubKey CKey::GetPubKey() const: Assertion `fValid' failed.

Expectation 2:
When wallet.dat does not exist, after re-entering all the mnemonic seeds, the wallet should load normally.

Observation 3 (non-critical):
When re-entering the seeds, the only way to correct a misplaced seed word is to drag and drop another one on top of it. It'd be nice if the users can simply drag and drop the word back down. An extreme case would be if a user finds out the seeds are misplaced after using all the words, the user will have no way to correct it but return to the previous step and come back doing it all over again.

Also tested:
Importing devnet wallet worked without issue.

KolbyML · 2020-02-16T06:09:45Z

Observation 1:
Wallet client shows welcome page even though wallet.dat was previously created. Users do not have to option to skip the welcome page but only have to choose between creating a new wallet vs importing an old one.

I have now fixed this issue stated above ^

Observation 2:
When wallet.dat does not exist, after re-entering all the mnemonic seeds, the wallet will fail to boot up and show
key.cpp:148: CPubKey CKey::GetPubKey() const: Assertion `fValid' failed.

I have also just fixed this issue stated above the issue was that I was redefining words in wallet.cpp instead of just setting the value.

Observation 3 (non-critical):
When re-entering the seeds, the only way to correct a misplaced seed word is to drag and drop another one on top of it. It'd be nice if the users can simply drag and drop the word back down. An extreme case would be if a user finds out the seeds are misplaced after using all the words, the user will have no way to correct it but return to the previous step and come back doing it all over again.

For Observation 3 that is just an inherent issue with Qt drag and drop system and nothing can really be done about that. I spent hours looking into that 8 months back.

Recap Both issues 1&2 were fixed and then I squashed the commit, also issue 3 is just an issue with how qt works and that is the best solution for drag and drop I found.

navbuilder · 2020-02-16T07:22:59Z

A new build of 59a69a2 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

navbuilder · 2020-02-16T08:44:50Z

A new build of f1cfe1a has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

aguycalled · 2020-02-16T10:56:16Z

When I click in one of the words it is highlighted. If some words in other columns are also highlighted, those are not reset.

aguycalled · 2020-02-16T10:58:03Z

This window looks too big for the little content and too dry. Would it be possible to make it smaller and maybe add the NavCoin logo from the splash screen?

mxaddict · 2020-02-16T15:26:36Z

GUI is asking me to restore/create a key when I already have a wallet.dat

My wallet is in ~/.navcoin4/devnet/wallet.dat

mxaddict · 2020-02-16T15:58:16Z

I would suggest asking for 8 words randomly instead of all 24 words (This would make it easier for the user)

For example have 16 of the words already pre filled on the drag and drop stage.

mxaddict · 2020-02-16T15:59:53Z

Also might be better if instead of drag and drop, it would be just click the words on the order that they are required (Drag n Drop is harder then just clicking the correct words in the correct order)

And if they make a mistake, they can just click the word that is wrong (In the top section) to remove it.

mxaddict · 2020-02-16T16:00:56Z

I also see some of the styles are still inline, I can help move these into a stylesheet (Once the GUI PR #557 is merged)

Other than that, nice work on the PR.

KolbyML · 2020-02-16T16:13:02Z

GUI is asking me to restore/create a key when I already have a wallet.dat

I Already fixed that can you can confirm which commit you compiled the current commit is: f1cfe1a

KolbyML · 2020-02-16T16:15:40Z

I would suggest asking for 8 words randomly instead of all 24 words (This would make it easier for the user)

For example have 16 of the words already pre filled on the drag and drop stage.

This is a onetime setup, so it shouldn't be that much of a hassle do all 24. If the user had to do this more then once in his lifetime, that would be more of a concern, but the goal he knows the placement of all 24 words.

mxaddict · 2020-02-16T16:26:30Z

GUI is asking me to restore/create a key when I already have a wallet.dat

I Already fixed that can you can confirm which commit you compiled the current commit is: f1cfe1a

I cloned a fresh copy just a an hour ago, so it was latest commit for sure.

Tested on Ubuntu LTS 18.04

mxaddict · 2020-02-16T16:27:38Z

I would suggest asking for 8 words randomly instead of all 24 words (This would make it easier for the user)
For example have 16 of the words already pre filled on the drag and drop stage.

This is a onetime setup, so it shouldn't be that much of a hassle do all 24. If the user had to do this more then once in his lifetime, that would be more of a concern, but the goal he knows the placement of all 24 words.

This is exactly why I suggested, I do this kind of thing (Importing keys, don't ask why 😅 ) about 1-2 times a month 👍

mxaddict · 2020-02-16T16:28:40Z

GUI is asking me to restore/create a key when I already have a wallet.dat

I Already fixed that can you can confirm which commit you compiled the current commit is: f1cfe1a

I cloned a fresh copy just a an hour ago, so it was latest commit for sure.

Tested on Ubuntu LTS 18.04

I'm trying the windows version now.

KolbyML · 2020-02-16T16:29:53Z

Also might be better if instead of drag and drop, it would be just click the words on the order that they are required (Drag n Drop is harder then just clicking the correct words in the correct order)

^ While that sounds like a good idea, that would probably require a rewrite of what I wrote which wouldn't really be possible at this time

And if they make a mistake, they can just click the word that is wrong (In the top section) to remove it.

^ This is a pretty good idea I can probably add that, the only issue would be which QGraphicsList it got put into which other then that it is possible.

mxaddict · 2020-02-16T16:31:48Z

Also might be better if instead of drag and drop, it would be just click the words on the order that they are required (Drag n Drop is harder then just clicking the correct words in the correct order)

^ While that sounds like a good idea, that would probably require a rewrite of what I wrote which wouldn't really be possible at this time

And if they make a mistake, they can just click the word that is wrong (In the top section) to remove it.

^ This is a pretty good idea I can probably add that, the only issue would be which QGraphicsList it got put into which other then that it is possible.

Not really deal breakers, I think in the current design we can merge these changes and make modifications to it as needed, important thing is we have a GUI for non CLI savy users to import the keys, good work.

mxaddict · 2020-02-16T16:52:25Z

Build: f1cfe1a
Ubuntu LTS 18.04

Restore works
Creating new key works
Does not ask to import/create if already have a wallet.dat file

src/mnemonic/generateseed.cpp

mxaddict · 2020-02-16T19:15:27Z

Build: f795e44
Windows 10 and Ubuntu 18.04

Restore works
Creating new key works
Does not ask to import/create if already have a wallet.dat file on this network (mainnet, devnet, testnet)

navbuilder · 2020-02-16T19:59:10Z

A new build of b539b58 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

navbuilder · 2020-02-16T22:39:04Z

A new build of f795e44 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

chasingkirkjufell · 2020-02-16T23:04:39Z

Build: f795e44
Ubuntu 19.04

Restore works
Creating new key works
Does not ask to import/create if already have a wallet.dat file on this network (mainnet, devnet, testnet)

I am happy with this PR now. I will leave the final review for @aguycalled for OSX system.

src/qt/startoptionsmain.cpp

aguycalled · 2020-02-17T09:37:07Z

in OSX 10.14 the list of words covers the last row of cells

src/qt/navcoin.cpp

KolbyML · 2020-02-17T16:18:58Z

in OSX 10.14 the list of words covers the last row of cells

Can you try making the window larger for context of what will happen

Also I don't own a mac so I can't really troubleshot that

chasingkirkjufell · 2020-02-17T16:23:17Z

I'm seeing it on Ubuntu too now. The last row will show up if the window is enlarged.
Edit: I think it's most likely due to the added words on top.

mxaddict · 2020-02-17T16:28:11Z

I think it's caused the the extra text we added to the top.

…

On Tue, Feb 18, 2020, 00:23 chasingkirkjufell ***@***.***> wrote: I'm seeing it on Ubuntu too now. The last row will show up if the window is enlarged. — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#659?email_source=notifications&email_token=AAIDAKKAACM3WCAJCNCQ7GTRDK2XLA5CNFSM4KV6CSV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL67VEQ#issuecomment-587070098>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDAKI37MGKBI4JNNSAZKDRDK2XLANCNFSM4KV6CSVQ> .

KolbyML · 2020-02-17T16:49:21Z

I made a change that I believe will fix the issue found of linux and mac, If someone could test it and take a screenshot for me thanks.

src/qt/startoptionssort.cpp

chasingkirkjufell · 2020-02-17T18:59:32Z

4th row now correctly shown on commit a2fd710.

mxaddict · 2020-02-17T19:07:11Z

Nice <3

…

On Tue, Feb 18, 2020, 02:59 chasingkirkjufell ***@***.***> wrote: 4th row now correctly shown on commit a2fd710 <a2fd710> . [image: image] <https://user-images.githubusercontent.com/38635377/74680079-40547b00-5185-11ea-98f5-81a65f9210c2.png> — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#659?email_source=notifications&email_token=AAIDAKOUNVZZKJYH6LMYRYLRDLNBLA5CNFSM4KV6CSV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL7MKNQ#issuecomment-587121974>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDAKIWRNR2QZX4WQDC3VTRDLNBLANCNFSM4KV6CSVQ> .

navbuilder · 2020-02-17T19:19:21Z

A new build of cc016af has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

navbuilder · 2020-02-17T20:44:04Z

A new build of a2fd710 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

src/qt/navcoin.cpp

navbuilder · 2020-02-17T23:29:28Z

A new build of 3bd3c98 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

aguycalled · 2020-02-17T23:45:03Z

Tested MacOS, approved after last changes.

aguycalled · 2020-02-17T22:11:12Z

src/Makefile.qt.include

 NAVCOIN_RC = qt/res/navcoin-qt-res.rc

 NAVCOIN_QT_INCLUDES = -I$(builddir)/qt -I$(srcdir)/qt -I$(srcdir)/qt/forms \
-	-I$(builddir)/qt/forms -DQT_NO_KEYWORDS


same about removing this.
first reference i found makes me wonder maybe it should not be removed unless there's a reason for it.
https://stackoverflow.com/questions/22188432/qt-macro-keywords-cause-name-collisions

navbuilder · 2020-02-18T00:54:40Z

A new build of 96a460a has completed succesfully!
Binaries available at https://build.nav.community/binaries/mnemonic-startup-gui

aguycalled requested review from aguycalled, chasingkirkjufell, mxaddict and proletesseract and removed request for proletesseract February 16, 2020 01:33

aguycalled added bounty-xhigh ready for review wallet labels Feb 16, 2020

aguycalled requested changes Feb 16, 2020

View reviewed changes

src/mnemonic/generateseed.cpp Outdated Show resolved Hide resolved

KolbyML requested a review from aguycalled February 16, 2020 19:47

mxaddict approved these changes Feb 16, 2020

View reviewed changes

aguycalled requested changes Feb 17, 2020

View reviewed changes

src/qt/startoptionsmain.cpp Outdated Show resolved Hide resolved

src/qt/startoptionsmain.cpp Outdated Show resolved Hide resolved

src/qt/startoptionsmain.cpp Outdated Show resolved Hide resolved

aguycalled reviewed Feb 17, 2020

View reviewed changes

src/qt/navcoin.cpp Show resolved Hide resolved

chasingkirkjufell reviewed Feb 17, 2020

View reviewed changes

src/qt/startoptionssort.cpp Outdated Show resolved Hide resolved

aguycalled reviewed Feb 17, 2020

View reviewed changes

src/qt/navcoin.cpp Show resolved Hide resolved

Welcome to wallet GUI for mnemonic

96a460a

aguycalled added the bounty pending payment label Feb 17, 2020

aguycalled approved these changes Feb 17, 2020

View reviewed changes

aguycalled merged commit 579f9fa into navcoin:master Feb 17, 2020

aguycalled added bounty paid and removed bounty pending payment labels Feb 19, 2020

Conversation

KolbyML commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020 via email

Uh oh!

chasingkirkjufell commented Feb 16, 2020

Uh oh!

navbuilder commented Feb 16, 2020

Uh oh!

navbuilder commented Feb 16, 2020

Uh oh!

chasingkirkjufell commented Feb 16, 2020

Uh oh!

KolbyML commented Feb 16, 2020

Uh oh!

navbuilder commented Feb 16, 2020

Uh oh!

navbuilder commented Feb 16, 2020

Uh oh!

aguycalled commented Feb 16, 2020

Uh oh!

aguycalled commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

KolbyML commented Feb 16, 2020

Uh oh!

KolbyML commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

KolbyML commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

Uh oh!

mxaddict commented Feb 16, 2020

Uh oh!

navbuilder commented Feb 16, 2020

Uh oh!

navbuilder commented Feb 16, 2020

Uh oh!

chasingkirkjufell commented Feb 16, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aguycalled commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

KolbyML commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chasingkirkjufell commented Feb 17, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mxaddict commented Feb 17, 2020 via email

Uh oh!

KolbyML commented Feb 17, 2020

Uh oh!

Uh oh!

chasingkirkjufell commented Feb 17, 2020

Uh oh!

mxaddict commented Feb 17, 2020 via email

Uh oh!

navbuilder commented Feb 17, 2020

mxaddict commented Feb 16, 2020 •

edited

Loading

aguycalled commented Feb 17, 2020 •

edited

Loading

KolbyML commented Feb 17, 2020 •

edited

Loading

chasingkirkjufell commented Feb 17, 2020 •

edited

Loading