Rescan when importing mnemonic #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguycalled
requested review from
chasingkirkjufell,
mxaddict and
proletesseract
Contributor
|
Tested on devnet and imported wallet still not showing past transactions. |
chasingkirkjufell
approved these changes
Feb 19, 2020
Contributor
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
There was a problem hiding this comment.
Tested on Ubuntu 19.04 64GB RAM
- Importing wallet and verify past tx appear correctly
- Creating a new wallet with seed phrase
- Client boots normally when a wallet.dat already exists
|
A new build of f0297ca has completed succesfully! |
mxaddict
approved these changes
Feb 20, 2020
Contributor
|
Tested on Windows 10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug which prevented a wallet to scan an already existing chain for old transactions when importing a mnemonic.
By default, the wallet will look for all the transactions from the Genesis block. This can be changed using
importmnemonicfromtime=<timestamp>in order to save scanning time and to look for transactions in a concrete period.### What to test
Importing a mnemonic from a wallet with transactions existing prior to the import time should show the complete transaction list and right balance.