Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call #692

Merged
merged 2 commits into from
Jun 6, 2020
Merged

[GUI] Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call #692

merged 2 commits into from
Jun 6, 2020

Conversation

mxaddict
Copy link
Contributor

@mxaddict mxaddict commented Jun 4, 2020 •
edited
Loading

Capture1

Capture2

closes #621

@mxaddict mxaddict mentioned this pull request Jun 4, 2020
Closed
@mxaddict mxaddict changed the title Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call [GUI] Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call Jun 4, 2020
@navbuilder
Copy link

A new build of 2f713d9 has completed succesfully!
Binaries available at https://build.nav.community/binaries/added-dump-mnemonic-ui

chasingkirkjufell
chasingkirkjufell approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested gitian build on Window 10.

@Xa5r
Copy link

Xa5r commented Jun 5, 2020

I would not call it "master mnemonic"
Just "mnemonic" or "mnemonic/seed"

mxaddict
mxaddict commented Jun 5, 2020
View reviewed changes
src/qt/navcoingui.cpp
@@ -499,6 +500,9 @@ void NavCoinGUI::createActions()
exportMasterPrivateKeyAction = new QAction(tr("Show &master private key"), this);
exportMasterPrivateKeyAction->setToolTip(tr("Show master private key"));

exportMnemonicAction = new QAction(tr("Show m&nemonic"), this);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xa5r I've changed the label

@mxaddict
Copy link
Contributor Author

mxaddict commented Jun 5, 2020

I would not call it "master mnemonic"
Just "mnemonic" or "mnemonic/seed"

Done

@navbuilder
Copy link

A new build of 5492fa5 has completed succesfully!
Binaries available at https://build.nav.community/binaries/added-dump-mnemonic-ui

aguycalled
aguycalled approved these changes Jun 6, 2020
View reviewed changes
Copy link
Member

@aguycalled aguycalled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested osx

@aguycalled aguycalled merged commit 52bea8d into navcoin:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguycalled aguycalled aguycalled approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@dantudor dantudor Awaiting requested review from dantudor

@proletesseract proletesseract Awaiting requested review from proletesseract

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Master Private Key with Mnemonic
5 participants
@mxaddict @navbuilder @Xa5r @aguycalled @chasingkirkjufell