Skip to content

[GUI] Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call#692

Merged
aguycalled merged 2 commits intonavcoin:masterfrom
mxaddict:added-dump-mnemonic-ui
Jun 6, 2020
Merged

[GUI] Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call#692
aguycalled merged 2 commits intonavcoin:masterfrom
mxaddict:added-dump-mnemonic-ui

Conversation

@mxaddict
Copy link
Contributor

@mxaddict mxaddict commented Jun 4, 2020

Capture1

Capture2

closes #621

@mxaddict mxaddict changed the title Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call [GUI] Added new show/dump mnemonic UI, similar to the dumpmnemonic RPC call Jun 4, 2020
@navbuilder
Copy link

A new build of 2f713d9 has completed succesfully!
Binaries available at https://build.nav.community/binaries/added-dump-mnemonic-ui

Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested gitian build on Window 10.

@Xa5r
Copy link

Xa5r commented Jun 5, 2020

I would not call it "master mnemonic"
Just "mnemonic" or "mnemonic/seed"

exportMasterPrivateKeyAction = new QAction(tr("Show &master private key"), this);
exportMasterPrivateKeyAction->setToolTip(tr("Show master private key"));

exportMnemonicAction = new QAction(tr("Show m&nemonic"), this);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xa5r I've changed the label

@mxaddict
Copy link
Contributor Author

mxaddict commented Jun 5, 2020

I would not call it "master mnemonic"
Just "mnemonic" or "mnemonic/seed"

Done

@navbuilder
Copy link

A new build of 5492fa5 has completed succesfully!
Binaries available at https://build.nav.community/binaries/added-dump-mnemonic-ui

Copy link
Member

@aguycalled aguycalled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested osx

@aguycalled aguycalled merged commit 52bea8d into navcoin:master Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Master Private Key with Mnemonic

5 participants