Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QT] Updated price update timer to respect shutdown request #696

Merged

Conversation

mxaddict
Copy link
Contributor

@mxaddict mxaddict commented Jun 4, 2020

This bug was reported by Goku over on discord.

master/5.0.0 version of the wallet would fail to close if shutdown was request at exactly the time the price data was updated.

This patches that up so the wallet will respect shutdown request.

@mxaddict mxaddict changed the title Updated price update timer to respect shutdown request [QT] Updated price update timer to respect shutdown request Jun 4, 2020
@navbuilder
Copy link

A new build of 15c56eb has completed succesfully!
Binaries available at https://build.nav.community/binaries/updated-price-update-to-respect-shutdown

Copy link
Member

@aguycalled aguycalled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense

@mxaddict mxaddict merged commit ce6fefb into navcoin:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants