[WALLET] Updated the encrypt wallet logic to not replace master key

[mxaddict]

closes #695

I've updated the wallet to not replace master key with new key on encryption.

Test scenarios:

• Scenario 1
  • Create wallet
  • Dumped mnemonic
  • Encrypted wallet
  • Dumped mnemonic again
  • Made sure all dumped mnemonic match
• Scenario 2
  • Create wallet
  • Dumped mnemonic 1
  • Encrypted wallet
  • Dumped mnemonic 2
  • Changed password
  • Dumped mnemonic 3
  • Made sure all dumped mnemonic match
• Scenario 3
  • Restored wallet with mnemonic
  • Dumped mnemonic 1
  • Encrypted wallet
  • Dumped mnemonic 2
  • Changed password
  • Dumped mnemonic 3
  • Made sure all dumped mnemonic match

[navbuilder]

A new build of 25c173d has completed succesfully!
Binaries available at https://build.nav.community/binaries/disabled-regeneration-of-master-key-on-encryption

[mxaddict]

I'll try it out with those lines reverted.

[mxaddict]

Hmmm, you were right, it does work without those 2 changes, I don't understand why though, I thought that new masterkey was the key used for the mnemonic...

So the HD master key is the one used?

[aguycalled]

/**

• Private key encryption is done based on a CMasterKey,
• which holds a salt and random encryption key.
• CMasterKeys are encrypted using AES-256-CBC using a key
• derived using derivation method nDerivationMethod
• (0 == EVP_sha512()) and derivation iterations nDeriveIterations.
• vchOtherDerivationParameters is provided for alternative algorithms
• which may require more parameters (such as scrypt).
• Wallet Private Keys are then encrypted using AES-256-CBC
• with the double-sha256 of the public key as the IV, and the
• master key's key as the encryption key (see keystore.[ch]).
  */

[aguycalled]

master key here is more related to the password used for encrypting

[mxaddict]

master key here is more related to the password used for encrypting

Gotcha, the name was confusing me I guess 😸

[navbuilder]

A new build of d76bfbf has completed succesfully!
Binaries available at https://build.nav.community/binaries/disabled-regeneration-of-master-key-on-encryption

[Xa5r]

Test scenarios:

* [x]  Scenario 1
  
  * [x]  Create wallet
  * [x]  Dumped mnemonic
  * [x]  Encrypted wallet
  * [x]  Dumped mnemonic again
  * [x]  Made sure all dumped mnemonic match

* [x]  Scenario 2
  
  * [x]  Create wallet
  * [x]  Dumped mnemonic 1
  * [x]  Encrypted wallet
  * [x]  Dumped mnemonic 2
  * [x]  Changed password
  * [x]  Dumped mnemonic 3
  * [x]  Made sure all dumped mnemonic match

* [x]  Scenario 3
  
  * [x]  Restored wallet with mnemonic
  * [x]  Dumped mnemonic 1
  * [x]  Encrypted wallet
  * [x]  Dumped mnemonic 2
  * [x]  Changed password
  * [x]  Dumped mnemonic 3
  * [x]  Made sure all dumped mnemonic match

Tested all this scenarios including master private key, the mnemonic never changes.

[chasingkirkjufell]

• Scenario 1
  • Create wallet
  • Dumped mnemonic
  • Encrypted wallet
  • Dumped mnemonic again
  • Made sure all dumped mnemonic match
• Scenario 2
  • Create wallet
  • Dumped mnemonic 1
  • Encrypted wallet
  • Dumped mnemonic 2
  • Changed password
  • Dumped mnemonic 3
  • Made sure all dumped mnemonic match
• Scenario 3
  • Restored wallet with mnemonic
  • Dumped mnemonic 1
  • Encrypted wallet
  • Dumped mnemonic 2
  • Changed password
  • Dumped mnemonic 3
  • Made sure all dumped mnemonic match

[aguycalled]

tested gitian osx