Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] Fixed some functional tests that were checking for state == 0 for expired proposals or prequests #698

Merged
merged 2 commits into from
Jun 5, 2020
Merged

[TEST] Fixed some functional tests that were checking for state == 0 for expired proposals or prequests #698

merged 2 commits into from
Jun 5, 2020

Conversation

mxaddict
Copy link
Contributor

@mxaddict mxaddict commented Jun 4, 2020

I noticed this test was checking for state == 0, but if I remember correctly state == 3 is expired.

@mxaddict mxaddict changed the title [TEST] Fixed cfund-paymentrequest-state-expired.py [TEST] Fixed some functional tests that were checking for state == 3 for expired proposals or prequests Jun 4, 2020
@mxaddict mxaddict changed the title [TEST] Fixed some functional tests that were checking for state == 3 for expired proposals or prequests [TEST] Fixed some functional tests that were checking for state == 0 for expired proposals or prequests Jun 4, 2020
@navbuilder
Copy link

A new build of 27a093a has completed succesfully!
Binaries available at https://build.nav.community/binaries/fixed-cfund-paymentrequest-state-expired-test

aguycalled
aguycalled approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@aguycalled aguycalled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes make sense

chasingkirkjufell
chasingkirkjufell approved these changes Jun 5, 2020
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@mxaddict mxaddict merged commit f485b3c into navcoin:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguycalled aguycalled aguycalled approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@dantudor dantudor Awaiting requested review from dantudor

@proletesseract proletesseract Awaiting requested review from proletesseract

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mxaddict @navbuilder @aguycalled @chasingkirkjufell