[GUI][SETUP] Added a password step to setup wizard#700
[GUI][SETUP] Added a password step to setup wizard#700aguycalled merged 3 commits intonavcoin:masterfrom
Conversation
mxaddict
commented
Jun 5, 2020
mxaddict
commented
mxaddict
requested review from
aguycalled,
chasingkirkjufell,
dantudor and
proletesseract
|
related to #697 |
|
NOTES: Password step should come always at the last step before loading wallet |
|
A new build of 9e665a8 has completed succesfully! |
|
The button is "skip/next" when creating a new wallet but only "next" when importing with mnemonics. |
|
|
I think on the step on the picture, there dont need to stay skip/next, because without password is also just going to the next step |
|
Not sure if this is a bug here, but if you dont set a password and encrypt the wallet later, the mnemonic changes |
This won't happen once the fix for that bug is also merged into master |
Ok, so just "next"? |
|
Yes |
Makes sense 👍 |
|
I've pushed the suggested changes 👍 |
|
A new build of 1cd0efd has completed succesfully! |
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
There was a problem hiding this comment.
Tested gitian build on Windows 10.
aguycalled
left a comment
aguycalled
left a comment
There was a problem hiding this comment.
tested osx, reviewed code. everything ok except of the strings when no password is entered
| // Check if we gave a password | ||
| if (!password.empty()) { | ||
| // Is this safe? or do I need to do something more | ||
| // to the string after I've converted it to SecureString | ||
| SecureString strWalletPass; | ||
| strWalletPass.reserve(100); | ||
| strWalletPass = password.c_str(); | ||
| walletInstance->EncryptWallet(strWalletPass); | ||
| } |
There was a problem hiding this comment.
@aguycalled About this part, is this safe? will it not lead the password in memory?
5 participants
