[RPC][GUI] Added more progress indicators during wallet start up, also shows via…

[mxaddict]

closes #654

I'm sure this will be helpful for people wanting CLI progress during wallet start up, and also makes the splash screen have more feedback to the user.

But not sure how much this slows down the start up as it's basically tracking progress for most of the heavy loops in wallet start up.

@aguycalled do you think we should add this?

It's just something that came to mind when I took a look @ pr #654

[mxaddict]

Ok, I did some testing with this code, the wallet only loads like ~1% to ~2% slower than without this change on my PC, can you guys test and let me know if it performance ok?

[mxaddict]

[Xa5r]

Rescanning (changing the wallet.dat) it also what took a very long time yesterday

[navbuilder]

A new build of a455624 has completed succesfully!
Binaries available at https://build.nav.community/binaries/added-more-progress-indicators

[mxaddict]

Rescanning (changing the wallet.dat) it also what took a very long time yesterday

@Xa5r could you test this PR and see if it makes your wallet start time slow?

[Xa5r]

Its difficult to compare because the loading time is always different.
But I noticed that by bootstraping the notice "Loading block guts xxx..." goes over 4.3 million, more blocks than the current highest block.

[mxaddict]

Its difficult to compare because the loading time is always different.
But I noticed that by bootstraping the notice "Loading block guts xxx..." goes over 4.3 million, more blocks than the current highest block.

I don't think that loading block guts only loads active chains, I think it also loads forked/abandoned chain heads, which might explain why it loads more than the active chain.

I'm just assuming though, might be better to ask @aguycalled about it.

[aguycalled]

Its difficult to compare because the loading time is always different.
But I noticed that by bootstraping the notice "Loading block guts xxx..." goes over 4.3 million, more blocks than the current highest block.

I don't think that loading block guts only loads active chains, I think it also loads forked/abandoned chain heads, which might explain why it loads more than the active chain.

I'm just assuming though, might be better to ask @aguycalled about it.

yes that's right

[aguycalled]

tested gitian osx, surprisingly, my wallet in mainnet loads 10 times faster with this branch

[mxaddict]

tested gitian osx, surprisingly, my wallet in mainnet loads 10 times faster with this branch

I don't know how that would happen, but it's a good thing I guess 🗡️

[mxaddict]

tested gitian osx, surprisingly, my wallet in mainnet loads 10 times faster with this branch

I don't know how that would happen, but it's a good thing I guess 🗡️

@chasingkirkjufell can you maybe test this branch as well on windows?

I've tested on Ubuntu 18.04 (Which performed about 1-2% slower)

[chasingkirkjufell]

I love it. It is about 1% slower on with Gitian build on Windows 10 but having the extra info is really nice.