Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GUI] Fix for crash when voting for payment request #706

Merged
merged 1 commit into from
Jun 7, 2020
Merged

[GUI] Fix for crash when voting for payment request #706

merged 1 commit into from
Jun 7, 2020

Conversation

aguycalled
Copy link
Member

@aguycalled aguycalled commented Jun 6, 2020 •
edited
Loading

Should fix #704

@navbuilder
Copy link

A new build of 1ac3dcd has completed succesfully!
Binaries available at https://build.nav.community/binaries/aguycalled-patch-7

chasingkirkjufell
chasingkirkjufell approved these changes Jun 6, 2020
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm fixes the crashing issue with gitian build on Windows 10.

@mxaddict mxaddict mentioned this pull request Jun 7, 2020
Closed
@mxaddict
Copy link
Contributor

mxaddict commented Jun 7, 2020

Testing on Ubuntu 18.04 (Waiting for wallet to boot :D)

@mxaddict mxaddict self-requested a review June 7, 2020 11:35
mxaddict
mxaddict approved these changes Jun 7, 2020
View reviewed changes
Copy link
Contributor

@mxaddict mxaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fixes the crash

@mxaddict mxaddict merged commit 399bf98 into master Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxaddict mxaddict mxaddict approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navcoin 5 wallet crashing on vote change
4 participants
@aguycalled @navbuilder @mxaddict @chasingkirkjufell