[RPC] Fix for getaddresshistory balance of multiple addresses#735
Merged
[RPC] Fix for getaddresshistory balance of multiple addresses#735
Conversation
aguycalled
requested review from
chasingkirkjufell,
dantudor,
mxaddict and
proletesseract
|
A new build of 12bbfb0 has completed succesfully! |
|
A new build of 97ca921 has completed succesfully! |
chasingkirkjufell
approved these changes
Aug 7, 2020
Contributor
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
There was a problem hiding this comment.
Tested gitian build on Windows 10
Contributor
|
Changes look good, will test once I get on my main PC |
Contributor
|
Tested the RPC on devnet with Ubuntu 18.04 self built binary |
mxaddict
approved these changes
Aug 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getaddresshistory is queried for multiple addresses, it was showing incorrect accumulated balances. Instead it should show the correct balance of each address.