Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] blsCT: Boneh–Lynn–Shacham Confidential Transactions #743

Merged
merged 552 commits into from Dec 29, 2020

Conversation

0x2830
Copy link
Contributor

@0x2830 0x2830 commented Aug 25, 2020

[...]

@navbuilder
Copy link

A new build of has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

1 similar comment
@navbuilder
Copy link

A new build of has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@chasingkirkjufell
Copy link
Contributor

chasingkirkjufell commented Aug 30, 2020

Ubuntu 20.04 local build

When sending private tx with the qt wallet crashes. The initial couple of private tx would go through but after the wallet stake for a while, sending a private tx would crash the wallet.
image

************************
EXCEPTION: St13runtime_error       
ReserveBLSCTBlindingKeyFromKeyPool(): unknown key in key pool       
navcoin in Runaway exception       

terminate called after throwing an instance of 'boost::wrapexcept<boost::lock_error>'
  what():  boost: mutex lock failed in pthread_mutex_lock: Invalid argument

@mxaddict
Copy link
Contributor

This is gonna be a huge update 👍

@mxaddict
Copy link
Contributor

@aguycalled @0x2830 @chasingkirkjufell I see that a build for gitian passed 2 days ago, is there still an issue with the bls lib build during gitian builds?

@chasingkirkjufell
Copy link
Contributor

chasingkirkjufell commented Aug 31, 2020

@mxaddict I think there is. I'll try a gitian build today. The build bot also didn't build windows binaries. And the lastest commits are not built.

@aguycalled
Copy link
Member

@mxaddict I think there is. I'll try a gitian build today. The build bot also didn't build windows binaries. And the lastest commits are not built.

please use gitian-builder from https://github.com/aguycalled/gitian-builder

this needs apt-cacher-ng to be able to fetch the cmake repo key.

sudo apt install apt-cacher-ng
echo 'PassThroughPattern: .*' | sudo tee -a /etc/apt-cacher-ng/acng.conf
sudo service apt-cacher-ng restart
cd $HOME
git clone https://github.com/aguycalled/gitian-builder.git
pushd ./gitian-builder
bin/make-base-vm --docker --arch amd64 --suite bionic
mkdir -p inputs
pushd ./inputs
wget https://bitcoincore.org/cfields/osslsigncode-Backports-to-1.7.1.patch
wget http://downloads.sourceforge.net/project/osslsigncode/osslsigncode/osslsigncode-1.7.1.tar.gz
wget https://bitcoincore.org/depends-sources/sdks/MacOSX10.11.sdk.tar.gz
wget https://bitcoincore.org/depends-sources/sdks/MacOSX10.14.sdk.tar.gz

@chasingkirkjufell
Copy link
Contributor

chasingkirkjufell commented Sep 1, 2020

commit e34be7a gitian build x86_64-linux-gnu on Ubuntu 20.04

Wallet gets stuck at loading page.

debug log:

2020-09-01 05:30:52 keypool added key 100, size=100
2020-09-01 05:30:52 keypool added key 101, size=101
2020-09-01 05:30:52 keypool reserve 1
2020-09-01 05:30:52 keypool keep 1
2020-09-01 05:35:44 INFO: Updating prices
2020-09-01 05:35:44 INFO: Updated prices
2020-09-01 05:40:44 INFO: Updating prices
2020-09-01 05:40:44 INFO: Updated prices

image

@0x2830
Copy link
Contributor Author

0x2830 commented Sep 1, 2020

@aguycalled @0x2830 @chasingkirkjufell I see that a build for gitian passed 2 days ago, is there still an issue with the bls lib build during gitian builds?

Windows build does not complete yet. Could you help having a look? :D

@navbuilder
Copy link

A new build of has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

1 similar comment
@navbuilder
Copy link

A new build of has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@chasingkirkjufell
Copy link
Contributor

This is more of a yes/no question to me than a yes/cancel question.
image

@chasingkirkjufell
Copy link
Contributor

chasingkirkjufell commented Sep 6, 2020

Ubuntu 20.04 local build qt wallet
Issue 1:
private tx amount is not shown (public to private)
image
image

Issue 2:
private send with mixing session coins will crash the wallet
debug info:
image

@chasingkirkjufell
Copy link
Contributor

Issue 3:
startaggregationsession and then privatesendmixtoaddress will sign the tx but nothing is sent
image

2020-09-07 18:05:03 blsctblindingkeypool reserve 10
2020-09-07 18:05:03 connection to 116.203.87.1:18886 timeout
2020-09-07 18:05:05 trying connection 116.203.87.1:18886 lastseen=83.2hrs
2020-09-07 18:05:06 blsctblindingkeypool return 10
2020-09-07 18:05:06 blsctblindingkeypool return 9

@chasingkirkjufell
Copy link
Contributor

Issue 4:
in a private to private tx, the sender wallet shows the "change" of the outgoing tx instead of the actual outgoing amount
image

@0x2830
Copy link
Contributor Author

0x2830 commented Sep 7, 2020

Issue 4:
in a private to private tx, the sender wallet shows the "change" of the outgoing tx instead of the actual outgoing amount
image

Ubuntu 20.04 local build qt wallet
Issue 1:
private tx amount is not shown (public to private)

Thank you very much! I've patched 1 and 4 in fea7311

@0x2830
Copy link
Contributor Author

0x2830 commented Sep 7, 2020

Issue 3:
startaggregationsession and then privatesendmixtoaddress will sign the tx but nothing is sent
image

2020-09-07 18:05:03 blsctblindingkeypool reserve 10
2020-09-07 18:05:03 connection to 116.203.87.1:18886 timeout
2020-09-07 18:05:05 trying connection 116.203.87.1:18886 lastseen=83.2hrs
2020-09-07 18:05:06 blsctblindingkeypool return 10
2020-09-07 18:05:06 blsctblindingkeypool return 9

Can

Issue 3:
startaggregationsession and then privatesendmixtoaddress will sign the tx but nothing is sent
image

2020-09-07 18:05:03 blsctblindingkeypool reserve 10
2020-09-07 18:05:03 connection to 116.203.87.1:18886 timeout
2020-09-07 18:05:05 trying connection 116.203.87.1:18886 lastseen=83.2hrs
2020-09-07 18:05:06 blsctblindingkeypool return 10
2020-09-07 18:05:06 blsctblindingkeypool return 9

Fixed @ cb27ea8

@navbuilder
Copy link

A new build of 66edb55 has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of 79a4bef has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@mxaddict
Copy link
Contributor

This PR is really looking good!

@navbuilder
Copy link

A new build of 44fb39d has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of 6998ca9 has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of 30e089c has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of 322eb12 has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of 8ce53cf has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of fec2fb7 has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of db2f4b8 has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@navbuilder
Copy link

A new build of 10b2fef has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@mxaddict
Copy link
Contributor

👍

@navbuilder
Copy link

A new build of 1ce27e5 has completed succesfully!
Binaries available at https://build.nav.community/binaries/blsct

@aguycalled aguycalled merged commit e8ca03d into navcoin:master Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants