From 9f6ac1af14e2a4a6029cd2cf8e1dabdde4cbdad0 Mon Sep 17 00:00:00 2001 From: "Daybrush (Younkue Choi)" Date: Fri, 12 Jun 2020 14:04:52 +0900 Subject: [PATCH] fix: fix loading element for first mount #340 (#342) * fix: fix loading element for first mount #340 * test: test travis' node version --- .travis.yml | 2 +- packages/react-infinitegrid/package.json | 2 +- .../src/react-infinitegrid/InfiniteGrid.tsx | 7 +++---- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 6d297a2c..e29c5c43 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,6 +1,6 @@ language: node_js node_js: - - "6" + - "10" dist: trusty sudo: false install: diff --git a/packages/react-infinitegrid/package.json b/packages/react-infinitegrid/package.json index c55d5c06..6e9dc4a6 100644 --- a/packages/react-infinitegrid/package.json +++ b/packages/react-infinitegrid/package.json @@ -1,6 +1,6 @@ { "name": "@egjs/react-infinitegrid", - "version": "3.0.4", + "version": "3.0.5", "description": "A react component that can easily use egjs-infinitegrid", "types": "declaration/index.d.ts", "main": "dist/infinitegrid.cjs.js", diff --git a/packages/react-infinitegrid/src/react-infinitegrid/InfiniteGrid.tsx b/packages/react-infinitegrid/src/react-infinitegrid/InfiniteGrid.tsx index efde5c2c..b631461b 100644 --- a/packages/react-infinitegrid/src/react-infinitegrid/InfiniteGrid.tsx +++ b/packages/react-infinitegrid/src/react-infinitegrid/InfiniteGrid.tsx @@ -73,10 +73,6 @@ export default class InfiniteGrid extends React. state.layout = result === "relayout" ? result : state.layout || result; visibleChildren = ig.getRenderingItems().map((item: IItem) => item.jsx); - - if (this.props.loading) { - visibleChildren.push(); - } } else { const groups = categorize(items); if (props.status) { @@ -90,6 +86,9 @@ export default class InfiniteGrid extends React. visibleChildren = groups[0].items.map((item: IItem) => item.jsx); } } + if (this.props.loading) { + visibleChildren.push(); + } return {this.renderContainer(visibleChildren)}; } public componentDidUpdate() {