Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failed controller test case #303

wants to merge 1 commit into from


None yet
2 participants
Copy link

donggyu04 commented Aug 6, 2018

Fix failed controller test case.

List of failed tests.

  1. testCache
    • Delete because it is unnecessary test.(Depends on cache used.)
  2. testSaveGetDeleteAgent
    • Expire agentManager cache before testing
  3. testHealthCheck
    • Fix verification value "NONE" -> regionService.getCurrent()
  4. testDynamicCacheConfig
    • NPE
    • Add appropriate mock object
  5. testTagging
    • Fix verification value
      assertThat(tagRepository.count(hasPerfTest()), is(1L)); -> assertThat(tagRepository.count(hasPerfTest()), is(2L));
  6. testFileTemplateWithOptions
  7. testInfiniteScriptValidation
    • OOM
    • Reduce the number of logs generated by the test script(
  8. testSetPasswordEncoder
    • Deleted
  9. testAdditionalAuthenticationChecks
    • Fix testAddNewUserIntoLocal test that affected this test


@donggyu04 donggyu04 added the wip label Aug 6, 2018

@donggyu04 donggyu04 requested review from junoyoon and songeunwoo Aug 6, 2018

@donggyu04 donggyu04 force-pushed the fix-controller-test-case branch from 31bb1fc to bd272f1 Aug 8, 2018

@donggyu04 donggyu04 removed the wip label Aug 8, 2018

@donggyu04 donggyu04 force-pushed the fix-controller-test-case branch from bd272f1 to 800619a Aug 8, 2018


This comment has been minimized.

Copy link
Contributor Author

donggyu04 commented Aug 8, 2018

Migration to #308

@donggyu04 donggyu04 closed this Aug 8, 2018

@donggyu04 donggyu04 deleted the fix-controller-test-case branch Aug 17, 2018

@junoyoon junoyoon added this to the 3.4.2 milestone Aug 30, 2018

@junoyoon junoyoon added the bug fix label Aug 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.