Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing ties with Osclass Market. #22

Merged
merged 64 commits into from Aug 14, 2019

Conversation

@webmods-croatia
Copy link

commented Aug 13, 2019

I removed all files and functions regarding Osclass Market. I did some tests, here's the status report:

  • Fully successful script installation (removed location insert, instead showing message to download and import manually; removed "connect with Market").
  • No errors when opening admin panel (removed Market from menus and header, removed upgrade from menus).
  • No errors when importing, installing and enabling a plugin (tested with Job Attributes).
  • No errors when importing, installing and enabling a theme (tested with Bender Red).
  • No errors when importing, installing and enabling a language (tested with Czech).
  • No errors when importing, installing and enabling a location (tested with Croatia) - location page should point to tools -> import (not sure yet).
  • No errors when an automatic or manual cron is triggered (removed auto-upgrade).

webmods-croatia added some commits Aug 13, 2019

Merge pull request #1 from navjottomer/master
Update to 3.8.0. beta 2
Delete market.php
Removing all ties with Osclass Market.
Delete market/header.php
Removing all ties with Osclass Market.
Delete market/index.php
Removing all ties with Osclass Market.
Delete market/section.php
Removing all ties with Osclass Market.
Update widgets.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.
Update main.php
Removing all ties with Osclass Market.
Update add.php
Removing all ties with Osclass Market.
Update add.php
Removing all ties with Osclass Market.
Update add.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.
Update plugins.php
Removing all ties with Osclass Market.
Update languages.php
Removing all ties with Osclass Market.
Update ajax.php
Removing all ties with Osclass Market.
Update install-location.php
Removing all ties with Osclass Market.
Update AdminMenu.php
Removing all ties with Osclass Market.
Update AdminToolbar.php
Removing all ties with Osclass Market.
Update main.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.
Update functions.php
Removing all ties with Osclass Market.
Update ajax.php
Removing all ties with Osclass Market.
Delete upgrade-funcs.php
Removing all ties with Osclass Market.
Update hPreference.php
Removing all ties with Osclass Market.
Update utils.php
Removing all ties with Osclass Market.
Update functions.php
Removing all ties with Osclass Market.
Update install-functions.php
Removing all ties with Osclass Market.

webmods-croatia added some commits Aug 13, 2019

Update basic_data.sql
Removing all ties with Osclass Market.
Delete upgrade.php
Removing all ties with Osclass Market.
Delete index.php
Removing all ties with Osclass Market.
Delete upgrade.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.
Update AdminSecBaseModel.php
Removing all ties with Osclass Market.
Update tools.php
Removing all ties with Osclass Market.
Update cron.php
Removing all ties with Osclass Market.
Update utils.php
Removing all ties with Osclass Market.
Update emails.php
Removing all ties with Osclass Market.
Update appearance.php
Removing all ties with Osclass Market.
Update main.php
Removing all ties with Osclass Market.
Update plugins.php
Removing all ties with Osclass Market.
Update index.php
Removing all ties with Osclass Market.

@navjottomer navjottomer changed the base branch from master to develop Aug 14, 2019

@navjottomer navjottomer merged commit 803892d into navjottomer:develop Aug 14, 2019

4 checks passed

security/snyk - oc-includes/composer.lock (navjottomer) No manifest changes detected
security/snyk - oc-includes/osclass/gui/package.json (navjottomer) No manifest changes detected
security/snyk - oc-includes/vendor/phpmailer/phpmailer/composer.lock (navjottomer) No manifest changes detected
security/snyk - package.json (navjottomer) No manifest changes detected
@navjottomer

This comment has been minimized.

Copy link
Owner

commented Aug 14, 2019

I have merged it into develop branch, we will work on develop branch now on and merge it into master when we need to release a new version. I hope it's okay.

@navjottomer

This comment has been minimized.

Copy link
Owner

commented Aug 14, 2019

Also please do not make changes to README.md in a single pull request as we may not accept a change to it and your pull request will be declined. I will post some guidelines in future to make this process easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.