Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Market #57

Merged
merged 19 commits into from Sep 4, 2019
Merged

Remove Market #57

merged 19 commits into from Sep 4, 2019

Conversation

@webmods-croatia
Copy link
Contributor

webmods-croatia commented Aug 31, 2019

  • Disabled (commented) cron update checking.
  • Removed Market products from admin home
  • Removed Market page from admin
  • Removed all links to Market (theme and plugin install)
  • Bundled languages with Osclass - location picker on install works

I want to make locations work too, but first, we need to decide do we want them to be fetched from GitHub or bundled with the installer.
Is it enough if there's only country picker? Currently, you can pick a country, then all or specific regions and then all or specific cities. That complicates stuff a bit.

All commits are described well. If there's anything I need to revert, tell me.

@navjottomer

This comment has been minimized.

Copy link
Owner

navjottomer commented Sep 1, 2019

Please check files for other markets related reference.
like I found in the oc-admin/index.php file.
Locations are fine from osclass geo DB site for now.
We need to work on the geo DB repo to be used with this new version. BTW I have forked your https://github.com/webmods-croatia/love-osclass, I'll need to update it before we can use it in our osclass build.

@webmods-croatia webmods-croatia force-pushed the webmods-croatia:wm-patch2 branch to 9057981 Sep 2, 2019
@webmods-croatia

This comment has been minimized.

Copy link
Contributor Author

webmods-croatia commented Sep 2, 2019

I made more updates check it. I think that's it. I only left code for updating plugins and themes (used for external updates).

@navjottomer navjottomer merged commit c7836b5 into navjottomer:develop Sep 4, 2019
4 checks passed
4 checks passed
security/snyk - oc-includes/composer.lock (navjottomer) No new issues
Details
security/snyk - oc-includes/osclass/gui/package.json (navjottomer) No manifest changes detected
security/snyk - oc-includes/vendor/phpmailer/phpmailer/composer.lock (navjottomer) No manifest changes detected
security/snyk - package.json (navjottomer) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.