This repository was archived by the owner on Jun 16, 2020. It is now read-only.
Publish but do not install tests#78
Closed
polyzen wants to merge 1 commit intonbedos:developfrom
polyzen:donotinstalltests
Closed
Publish but do not install tests#78polyzen wants to merge 1 commit intonbedos:developfrom polyzen:donotinstalltests
polyzen wants to merge 1 commit intonbedos:developfrom
polyzen:donotinstalltests
Conversation
Contributor
Author
|
Unless you as the author do not want tests installed, or the tests take up an excessive amount of space, this PR isn't needed. |
Contributor
Author
|
facepalm Removing just Edit: Forgot to publish tests again via |
Contributor
Author
|
Something like this may also be needed: |
nbedos
added a commit
that referenced
this pull request
Dec 2, 2018
Owner
Thanks, I'm fine with tests being included in the package. It makes it easier to run them once the installation is done.
It's now fixed by 213a1b8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this it seems tests have to be run withpython -m unittest discover tests. Perhaps I am missing something?As an example:
https://github.com/sphinx-doc/sphinx/blob/5d2d4e04778c5cbdb89c29d62d5a30cc2c23e76d/setup.py#L214
https://github.com/sphinx-doc/sphinx/blob/5d2d4e04778c5cbdb89c29d62d5a30cc2c23e76d/MANIFEST.in#L25
Edit: Referencing #77