Added CreateChargeWithToken method so a card number does not need to be passed in #8

Merged
merged 1 commit into from Nov 7, 2012

Conversation

Projects
None yet
3 participants
@robconery

One of the main benefits of using Stripe is that it's powered by Javascript. This is more true these days with the Stripe Button (https://stripe.com/docs/button) - you do not want credit card information hitting your server in order to remain PCI compliant.

Stripe gets around this by giving you a "token" for the approved card that you can charge against. You send that token to your server to then CreateCharge against stripe.

That's what this pull request is and does - a test has been added to Stripe.Tests as well.

Cheers! And thanks for the library.

Added the ablity to create a charge by token instead of card, which i…
…s the power of Stripe. Added test to confirm it works

nberardi added a commit that referenced this pull request Nov 7, 2012

Merge pull request #8 from robconery/master
Added CreateChargeWithToken method so a card number does not need to be passed in

@nberardi nberardi merged commit 59e6130 into nberardi:master Nov 7, 2012

@nberardi

This comment has been minimized.

Show comment Hide comment
@nberardi

nberardi Nov 7, 2012

Owner

Thanks for the patch. I was covering this with an ICreditCard interface and the CreditCardToken class

https://github.com/hoppio/stripe-dotnet/blob/master/src/CreditCardToken.cs

But this method in your patch is more straight forward, so it is probably more easily discovered. Thanks again for the encouragement and patch.

Owner

nberardi commented Nov 7, 2012

Thanks for the patch. I was covering this with an ICreditCard interface and the CreditCardToken class

https://github.com/hoppio/stripe-dotnet/blob/master/src/CreditCardToken.cs

But this method in your patch is more straight forward, so it is probably more easily discovered. Thanks again for the encouragement and patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment