Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Added CreateChargeWithToken method so a card number does not need to be passed in #8
Conversation
added a commit
that referenced
this pull request
Nov 7, 2012
nberardi
merged commit 59e6130
into
nberardi:master
Nov 7, 2012
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
nberardi
Nov 7, 2012
Owner
Thanks for the patch. I was covering this with an ICreditCard interface and the CreditCardToken class
https://github.com/hoppio/stripe-dotnet/blob/master/src/CreditCardToken.cs
But this method in your patch is more straight forward, so it is probably more easily discovered. Thanks again for the encouragement and patch.
|
Thanks for the patch. I was covering this with an ICreditCard interface and the CreditCardToken class https://github.com/hoppio/stripe-dotnet/blob/master/src/CreditCardToken.cs But this method in your patch is more straight forward, so it is probably more easily discovered. Thanks again for the encouragement and patch. |
robconery commentedNov 7, 2012
One of the main benefits of using Stripe is that it's powered by Javascript. This is more true these days with the Stripe Button (https://stripe.com/docs/button) - you do not want credit card information hitting your server in order to remain PCI compliant.
Stripe gets around this by giving you a "token" for the approved card that you can charge against. You send that token to your server to then CreateCharge against stripe.
That's what this pull request is and does - a test has been added to Stripe.Tests as well.
Cheers! And thanks for the library.