Nicolas Braem nbraem

  • Antwerp, Belgium
  • Joined on

Organizations

@Predicta
nbraem commented on issue scrapinghub/adblockparser#1
@nbraem

Benefit is that you don't need additional logic to match the options rule by rule.

nbraem commented on issue scrapinghub/adblockparser#1
@nbraem

How about adding the options to the regex? When matching you could build 1 string that includes the specified options and then just match it with t…

@nbraem
rule with single negated domain not matched correctly
nbraem pushed to master at nbraem/pyre2
@nbraem
nbraem pushed to master at nbraem/pyre2
@nbraem
nbraem pushed to master at nbraem/pyre2
@nbraem
nbraem commented on issue KeepSafe/aiohttp#262
@nbraem

Ok, thanks, I'll give that a shot!

nbraem commented on issue KeepSafe/aiohttp#262
@nbraem

Ok, so here's my use case. I'm implementing a proxy server. It should transparently pass through invalid headers and let the client decide what do …

nbraem commented on issue KeepSafe/aiohttp#262
@nbraem

This is obviously not my server, it's a random server on the internet. I'm not saying aiohttp should violate RFC, I'm saying raising an exception i…

@nbraem
no way to read response when InvalidHeader error occurs
nbraem commented on issue KeepSafe/aiohttp#253
@nbraem

I have a second commit in the pull request which is better: nbraem/aiohttp@5dd86d0 In the case I'm describing, self._conns[key] will contain an arr…

nbraem commented on issue KeepSafe/aiohttp#253
@nbraem

No, that's not it. Once the connection between the client (apachebench in this case) and the aiohttp server is lost, the aiohttp server will cancel…

nbraem commented on issue KeepSafe/aiohttp#253
@nbraem

I'm callilng response.read() first and then response.release(). Just tried keepalive_timeout=1, same result though. It cleans up some sockets, but …

nbraem commented on issue KeepSafe/aiohttp#253
@nbraem

Ok, here's a gist that more closely reproduces my problem, using this code, I can reproduce it every time: https://gist.github.com/nbraem/05972f50d…

nbraem commented on issue KeepSafe/aiohttp#253
@nbraem

Ok, I'll see if I can make a new gist that can reproduce it, that resembles my setup more closely.

nbraem commented on issue KeepSafe/aiohttp#253
@nbraem

Ran the fix overnight, here are graphs of the open sockets before and after the fix. Before: After:

nbraem commented on commit nbraem/aiohttp@5dd86d0060
@nbraem

The comment has since been removed.

@nbraem
  • @nbraem 5dd86d0
    make sure tests pass for #253
nbraem opened pull request KeepSafe/aiohttp#254
@nbraem
connection leak fix for #253
1 commit with 0 additions and 1 deletion
nbraem commented on issue KeepSafe/aiohttp#253
@nbraem

Same thing.

nbraem commented on commit nbraem/aiohttp@73016c4f09
@nbraem

The comment has since been removed.

@nbraem
  • @nbraem 73016c4
    connection leak fix for #253
@nbraem
Connection not closed when request is cancelled