New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The code style is unconsitent. #172

Open
jvoisin opened this Issue Mar 16, 2015 · 3 comments

Comments

Projects
None yet
2 participants
@jvoisin
Collaborator

jvoisin commented Mar 16, 2015

What about using something like uncrustify in a git-hook to impose a consistent coding-style?

@buixor

This comment has been minimized.

Member

buixor commented Nov 8, 2016

@buixor buixor assigned jvoisin and unassigned buixor Nov 8, 2016

@jvoisin

This comment has been minimized.

Collaborator

jvoisin commented Nov 9, 2016

Well, what about no?

@jvoisin

This comment has been minimized.

Collaborator

jvoisin commented Feb 28, 2017

It seems that we also have some naming issues:

Beyond this, I find (admittedly pedantic) issues with small chunks of source (and I’m not the only one). Naxsi uses a mix of prefixes among strucs and functions; the use of ngx_http_ is particularly confusing, especially to new developers. This namespace pollution is wholly unnecessary. There are also a number of compile-time definitions that feel like they should be configurable (at least as an advanced option), including recursive JSON parsing depth and PCRE ovec sizes, and overall the codebase is littered with inconsistent style. It feels very much like an odd, organic blend of data-driven architecture and hard-coded logic branches based on rule definitions, making extension and development very difficult.

This should be addressed too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment