New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw a warning when naxsi is enabled in an internal location #311

Closed
buixor opened this Issue Aug 23, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@buixor
Member

buixor commented Aug 23, 2016

naxsi does not parse requests to internal location (to avoid loops and other weird things).
However it would be cool to throw a warning when this happens.

@buixor buixor added this to the 0.56 milestone Aug 23, 2016

@buixor buixor self-assigned this Aug 23, 2016

@jvoisin jvoisin removed the Low prio label Oct 13, 2016

@buixor

This comment has been minimized.

Member

buixor commented Nov 8, 2016

The warning will be thrown once at the first request that hits the internal location.
I could do this at every request, but it's - at most - just a clever way to fill up logs ?

Sadly, we can't do it at config time :/

@jvoisin

This comment has been minimized.

Collaborator

jvoisin commented Nov 8, 2016

  • How can one issue a request to an internal location?
    • This is documented here
  • What kind of decision would the admin take upon such a notification?
@buixor

This comment has been minimized.

Member

buixor commented Nov 8, 2016

Naxsi will simply not treat a request that is tagged as "internal" (because of re-entrant aspect of nginx).
So it means the admin must configure naxsi so that the request is processed before the request is tagged as internal. It might be changed in the future to allow an admin to specifically allow this behavior. For now, we just want to throw a warning in the logs.

@buixor

This comment has been minimized.

Member

buixor commented Nov 9, 2016

Commited a fix attempt a548d60 let's see :)

@buixor buixor closed this Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment