New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update erroneous regex for double encoded values in cookies (1315) #415

Merged
merged 1 commit into from Mar 20, 2018

Conversation

Projects
None yet
3 participants
@rhowe-gds
Contributor

rhowe-gds commented Mar 19, 2018

%[2|3] matches %2, %| and %3

What I think was intended was to match either %2 or %3

Fix the regex accordingly.

Update erroneous regex for double encoded values in cookies (1315)
%[2|3] matches '%2', '%|' and '%3'

What I think was intended was to match either '%2' or '%3'

Fix the regex accordingly.
@buixor

This comment has been minimized.

Show comment
Hide comment
@buixor

buixor Mar 19, 2018

Member

looks good to me :)

Member

buixor commented Mar 19, 2018

looks good to me :)

@buixor

buixor approved these changes Mar 19, 2018

@jvoisin jvoisin merged commit 83cb255 into nbs-system:master Mar 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jvoisin

This comment has been minimized.

Show comment
Hide comment
@jvoisin

jvoisin Mar 20, 2018

Collaborator

Thank you ♥

Collaborator

jvoisin commented Mar 20, 2018

Thank you ♥

@rhowe-gds rhowe-gds deleted the rhowe-gds:rule_1315_fixup branch Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment