New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "include" statement in the configuration file #27

Closed
fr33tux opened this Issue Oct 6, 2017 · 2 comments

Comments

3 participants
@fr33tux
Copy link

fr33tux commented Oct 6, 2017

It may be nice to provide a way to split the configuration file into multiple smaller ones.

A syntax like that sp.include("file/to/import") for instance.

@jvoisin jvoisin added this to the 1.0 - Elephant Gambit milestone Oct 6, 2017

@blotus

This comment has been minimized.

Copy link
Contributor

blotus commented Oct 10, 2017

This feature might be a bit too tricky to implement considering the overall usefulness, it would complicate the configuration parsing code (which i find already too messy) for a not-so-great improvement.
I'm closing this for now, but i'm keeping the idea in the to-do list (and PR are always welcome :)).

@blotus blotus closed this Oct 10, 2017

@jvoisin

This comment has been minimized.

Copy link
Collaborator

jvoisin commented Oct 18, 2017

Actually, we could use it via the sp.configure_file php directive: this wouldn't complexify the parsing, no need to deal with recursion and stuff like that, while still allowing include-like behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment