-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some demo issues #4
Comments
Maybe something like this for the 3rd issue (not a pull request since I'm sure there's better ways to do this and I don't know how you feel about whether it's even a problem at all). |
I tried doubling the time interval between demos, it's a lot easier for me to read them. I couldn't figure out how to make the element highlighting last longer, though. |
Highlighting speed is controlled by the elementsSelected timeout in iframe.js. It's currently 1000. |
Ah, sorry, it's a css animation in iframe.html. The timeout doesn't control the actual effect. |
@nbubna what would you like me to do with this issue? Create a PR (for points 1 & 3, not sure what to do for 2), or just close it? Either way is fine for me. |
A pull request would be great. I may have some time to work on this next week, but i'm too busy today and tomorrow. |
Moving discussion to #6 ... |
The demos here are really helpful, but I noticed a few issues:
//...
comment line would be fine), or 2) a button to force evaluation should be added.These definitely aren't show-stoppers -- the app still worked great!
The text was updated successfully, but these errors were encountered: