Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some demo issues #4

Closed
mattfenwick opened this issue Aug 14, 2013 · 8 comments
Closed

Some demo issues #4

mattfenwick opened this issue Aug 14, 2013 · 8 comments

Comments

@mattfenwick
Copy link

The demos here are really helpful, but I noticed a few issues:

  • they're too fast for me -- I didn't have time to both read the code and see the effect before the code is deleted
  • when I get to start writing in my own examples, if I do something wrong -- i.e. a typo or try to call a non-existing method -- there's no visible feedback that I did something wrong (I had to open the console to figure out why nothing was happening)
  • I wasn't really sure how to trigger the update when I was done typing, sometimes the page seemed to figure out that I was done on its own and sometimes it didn't. I suggest that either 1) instructions should be added, describing what to do (in another //... comment line would be fine), or 2) a button to force evaluation should be added.

These definitely aren't show-stoppers -- the app still worked great!

@mattfenwick
Copy link
Author

Maybe something like this for the 3rd issue (not a pull request since I'm sure there's better ways to do this and I don't know how you feel about whether it's even a problem at all).

@mattfenwick
Copy link
Author

I tried doubling the time interval between demos, it's a lot easier for me to read them. I couldn't figure out how to make the element highlighting last longer, though.

@nbubna
Copy link
Owner

nbubna commented Aug 14, 2013

Highlighting speed is controlled by the elementsSelected timeout in iframe.js. It's currently 1000.

@mattfenwick
Copy link
Author

@nbubna do you mean on this line? Hmm ... increasing that value didn't do anything on my computer, since the highlighting is already completely faded before the attribute is removed.

@nbubna
Copy link
Owner

nbubna commented Aug 14, 2013

Ah, sorry, it's a css animation in iframe.html. The timeout doesn't control the actual effect.

@mattfenwick
Copy link
Author

@nbubna what would you like me to do with this issue? Create a PR (for points 1 & 3, not sure what to do for 2), or just close it? Either way is fine for me.

@nbubna
Copy link
Owner

nbubna commented Aug 16, 2013

A pull request would be great. I may have some time to work on this next week, but i'm too busy today and tomorrow.

@nbubna
Copy link
Owner

nbubna commented Aug 23, 2013

Moving discussion to #6 ...

@nbubna nbubna closed this as completed Aug 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants