Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Issue of Guid.Empty Being Changed #93

Merged
merged 2 commits into from Aug 17, 2019

Conversation

@DHemken97
Copy link
Contributor

commented Jul 31, 2019

When Generating a list of GUID the Empty Static member was being changed

@PureKrome

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@DHemken97 heya! I'm just trying to understand what the initial problem is.

Can you show some sample code showing what the current code does before your fix, please?

NOTE: I don't have permission to accept PR's .. but I'm curious to see what's going on/learn ...

@DHemken97

This comment has been minimized.

Copy link
Contributor Author

commented Aug 1, 2019

@PureKrome Check The Included Unit Test. When you Created a list Builder Of Type Guid The Static member Guid.Empty Would Be Changed.

@crmckenzie
Copy link
Collaborator

left a comment

Thanks for the PR. See my notes about the approach you chose. I think they should be fairly easy to address. Also thanks for making sure there are tests in place! :)

@crmckenzie crmckenzie merged commit d9ccad9 into nbuilder:develop Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.