Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AutoGC Work for the JavaScript Target #15

Closed
zicklag opened this issue Feb 20, 2019 · 1 comment
Closed

Make AutoGC Work for the JavaScript Target #15

zicklag opened this issue Feb 20, 2019 · 1 comment
Assignees
@zicklag
Labels
enhancement help wanted

Comments

@zicklag
Copy link
Collaborator

zicklag commented Feb 20, 2019

Currently the AutoGC option doesn't do anything for the JavaScript target. The WebIDL binder that comes with Emscripten and is used for Ammo.js does do some kind of wrapping of the generated bindings that allows the pointers to be garbage collected by JavaScript. I don't understand exactly how this works, but I'll have to try to take the same concept and implement it here.

If anybody else understands it I could use some pointers. 🙂
@zicklag zicklag self-assigned this Feb 20, 2019
@zicklag zicklag mentioned this issue Feb 21, 2019
Closed
@zicklag
Copy link
Collaborator Author

zicklag commented Feb 28, 2019

Looks like this actually isn't possible to do for JS, unfortunately. 🙁 ( see emscripten-core/emscripten#8206 (comment) ). Should maybe update the autoGC flag to be hlAutoGC or something else specific to HL to avoid confusion.

@zicklag zicklag closed this as completed Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zicklag zicklag

Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zicklag