Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url parsed failed #5

Closed
bibig opened this issue Dec 16, 2012 · 3 comments
Closed

url parsed failed #5

bibig opened this issue Dec 16, 2012 · 3 comments

Comments

@bibig
Copy link

bibig commented Dec 16, 2012

i use npm install bbcode, and i make a source test file to test, the following url related tests failed!

    1) should parse [url="<url>"] to <a href=<url>>
     2) should parse [url='<url>'] to <a href=<url>>
     3) should parse [link=<url>]test[/link]
     4) should parse [link="<url>"]test[/link]
     5) should parse [link='<url>']test[/link]
     6) as attribute with quotes - [img="<img>"] to <img src=<img>>
     7) as attribute with single quotes - [img='<img>'] to <img src=<img>>




detail:

     1) bcrypt #parse should parse [url] and [link] should parse [url="<url>"] to <a href=<url>>:

         actual expected

         <a href[url="http://example.com">"]url</a<span style="color: red">[/url]</span>

if i git clone the source, the tests all past!

@bibig
Copy link
Author

bibig commented Dec 16, 2012

in my node project,
the url parse broked:

parse: 
[url="http://sample.com"]name[/url]
but get:
[url="http://sample.com"]name<span style="color: red">[/url]</span>

@bibig
Copy link
Author

bibig commented Dec 16, 2012

i got the reason, the version 0.1.1 in npmjs is yet not updated.

@ncb000gt
Copy link
Owner

I've updated the version in npm. Sorry for the delay. Enjoy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants