Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

route53 list_resource_record_sets not called #15

Open
t-rojan opened this issue Oct 22, 2018 · 2 comments
Open

route53 list_resource_record_sets not called #15

t-rojan opened this issue Oct 22, 2018 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@t-rojan
Copy link

t-rojan commented Oct 22, 2018

Hi - I noticed that the gui file exports include route53 hosted zones but do not include results of calls to list_resource_record_sets for reach hosted zone. I am guessing because of the way that aws-inventory enumerates APIs that it hasn't figured out that this API can be called if the right parameters are provided. I am sure there are other APIs that are not getting called because of similar issues. Is there a solution to this that I've missed, or suggestions on how to get the resource records included?

@bitsandsalsa
Copy link
Collaborator

Currently, the tool ignores APIs that require args.

That specific API list-resource-record-sets does indeed require a hosted-zone-id argument. This feature is on the TODO list, but implementing it would require significant work. The service models that botocore interprets can get us this information. Without this feature, I don't see a sane way to even single out certain APIs you want to provide args for.

Just spitballing here, but you could take in some list from the user that specifies 2 things: what APIs their after and where to find values to use as args. The "where" could be used as keys into the response data store which is just a big dictionary. But now you have a dependency problem if the data isn't yet there from an earier API that hasn't been called yet.

@bitsandsalsa bitsandsalsa added enhancement New feature or request help wanted Extra attention is needed labels Oct 24, 2018
@ncc-erik-steringer
Copy link
Collaborator

Cleaning out issues. It looks like this is a larger-scale feature to add. What I'm thinking is some sort of dependency system that can:

  • Track which APIs depend on each other
  • Pass response output from one API into the other (maybe with configurable jq / regex)
  • Be flexible enough to build with existing "configparser" stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants