Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dask to runtime dependencies #75

Closed
1 task
aidanjgriffiths opened this issue Oct 17, 2023 · 3 comments
Closed
1 task

Add missing dask to runtime dependencies #75

aidanjgriffiths opened this issue Oct 17, 2023 · 3 comments

Comments

@aidanjgriffiths
Copy link
Collaborator

Tasks

  • Add dask (optional: pinned version) to core dependencies
@tennlee
Copy link
Collaborator

tennlee commented Oct 17, 2023

I don't think dask is a core dependency. It's tested for in development, but isn't a requirement for the users unless I've overlooked it

@aidanjgriffiths
Copy link
Collaborator Author

Sorry, I think I maybe either misled or there is a bug in the pip install scores[all] command as I was getting ModuleNotFoundError's missing dask this morning.

@aidanjgriffiths
Copy link
Collaborator Author

After some local testing it seems that the pypi scores package isn't recent enough to contain the dask dependency in pyproject.toml. This will be fixed in the new pypi release so I will close this issue. The behaviour works fine when running locally e.g. `pip install .[all]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants