Blosc1 gpu#4
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
+ Coverage 40.80% 41.91% +1.11%
==========================================
Files 28 29 +1
Lines 4220 4454 +234
Branches 1008 1081 +73
==========================================
+ Hits 1722 1867 +145
- Misses 1995 2028 +33
- Partials 503 559 +56
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #2
Adds blosc-zstd and blosc-lz4 decoding on the gpu. Supports the various bit/byte shuffle things.
Uses nvcomp for the raw lz4/zstd parts.
Allows for mixed sources - a batch can draw samples from zarrs with different encodings. supporting zstd, blosc-lz4, blosc-zstd, and none for now.
Not really optimized yet.
There's a d2h early in the pipeline and a sync point that's required for getting parameters for the nvcomp launch. The blosc kernels themselves probably need an optimization pass too. I did some basic checking on register pressure etc, but more to do there.