Handle parents provided by StateObject references #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 88e8f51 on paweld2:master into * on ncuillery:master*. |
|
Changes Unknown when pulling cfe86aa on paweld2:master into * on ncuillery:master*. |
|
Changes Unknown when pulling f76c018 on paweld2:master into * on ncuillery:master*. |
src/angular-breadcrumb.js
Outdated
Owner
|
Thanks for the PR, clean and tested ! I just leave a note above. Additionally, can you amend the commit and type this message: |
|
Changes Unknown when pulling f4288d3 on paweld2:master into * on ncuillery:master*. |
Author
|
Code fixed and message changed. |
|
Changes Unknown when pulling f4288d3 on paweld2:master into * on ncuillery:master*. |
Owner
|
Landed, thanks a lot ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the 'parent' property of a state is provided as a reference to a StateObject, the function $$parentState returns a reference to the State object and not the state name. On this case the application crash.
I added a test case for this and a fix on $$parentState.