Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Union mount needs to implement the optional Methods Move, Copy, DirMove etc. #2619

Closed
ghost opened this issue Oct 2, 2018 · 8 comments
Closed
Assignees
Milestone

Comments

@ghost
Copy link

ghost commented Oct 2, 2018

Issue as references here:

https://forum.rclone.org/t/plex-gdrive-using-union-mount/7024/22?u=nimbuz

Example of error:
"2018/10/02 10:08:22 ERROR : Bull (2016)/Season 3/Bull.(2016).S03E02.Jury.Duty.HDTV-720p.KILLERS.mkv.partial~: Dir.Rename error: Fs “union root ‘’” can’t rename files (no server side Move or Copy)"

Tentative solution: "The Union mount needs to implement the optional Methods Move, Copy, DirMove etc. It might be better to embed the fs for this"

@ncw ncw added this to the v1.44 milestone Oct 2, 2018
@ncw ncw self-assigned this Oct 2, 2018
ncw added a commit that referenced this issue Oct 2, 2018
…#2619

Implement optional interfaces
- Purge
- PutStream
- Copy
- Move
- DirMove
- DirCacheFlush
- ChangeNotify
- About

Make Hashes() return the intersection of all the hashes supported by the remotes
@ncw
Copy link
Member

ncw commented Oct 2, 2018

Here is an initial attempt at this

https://beta.rclone.org/branch/v1.43-130-gd90eccd6-fix-2619-union-beta/ (uploaded in 15-30 mins)

can you have a go and see if it fixes that problem?

@ghost
Copy link
Author

ghost commented Oct 3, 2018

This fix only has software for windows and osx. I'm running linux, so unfortunately I can't test it with those packages, sorry!
You will need to test if Radarr can move files into the folder of a vfs-mount and rename them.

@ncw
Copy link
Member

ncw commented Oct 3, 2018

@nimbuz the build failed, I've kicked it and the linux binaries are there now - can you have a test please?

Thanks

ncw added a commit that referenced this issue Oct 3, 2018
…#2619

Implement optional interfaces
- Purge
- PutStream
- Copy
- Move
- DirMove
- DirCacheFlush
- ChangeNotify
- About

Make Hashes() return the intersection of all the hashes supported by the remotes
@ghost
Copy link
Author

ghost commented Oct 4, 2018

@ncw Since I run unraid, it’s harder for me to test betas. It requires me to create a plugin from the file. I tried my best at a plugin, and I think I made it work (https://github.com/nimbuz/rclone-unraid/blob/beta/plugin/rclone.plg). However I'm unable to create a union remote through the config. You seeing the same?
I installed it on windows as well, and also not getting union as a remote.

@ncw
Copy link
Member

ncw commented Oct 6, 2018

@nimbuz - sorry I'm not an unraid user, so I'm not sure what is going on :-( The beta shouldn't have changed the union backend config at all.

@ghost
Copy link
Author

ghost commented Oct 6, 2018

@ncw Unfortunately I won't be able to test it on my system, before the fix is pushed to the main beta branch. However the implementation of --move should fix the issue. I tried reinstalling the fix on windows, and I'm seeing the union remote now, so it seems to be working.
I won't be able to test it though, sorry.

@ncw ncw closed this as completed in 364fca5 Oct 6, 2018
@ncw
Copy link
Member

ncw commented Oct 6, 2018

OK, I've merged that to master and it will be in the latest beta in 15-30 mins.

@ghost
Copy link
Author

ghost commented Oct 9, 2018

I’ve been running the beta for a few days now, and it’s running wonderfully. Good job on it!
The way it copies to the union folder, and then afterwards moves it to the correct local folder seems a bit slow however (I assume that’s what it’s doing), but it’s obviously not too big of an issue with fast hard drives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant