New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyurl --dryrun not working #2886

Closed
nishkalprakash opened this Issue Jan 3, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@nishkalprakash
Copy link

nishkalprakash commented Jan 3, 2019

What is the problem you are having with rclone?

When I use rclone copyurl then --dry-run wasn’t working, and it copied the file anyway.

What is your rclone version (output from rclone version)

rclone v1.45-056-g95e52e1a-beta

os/arch: windows/amd64
go version: go1.11

Which OS you are using and how many bits (eg Windows 7, 64 bit)

Windows 8.1, 64 bit

Which cloud storage system are you using? (eg Google Drive)

Google Drive

The command you were trying to run (eg rclone copy /tmp remote:tmp)

rclone copyurl https://example.com/dir1/file1.txt?jtoken=4ba0d4388ff1eafb3671473977a3a4ab remote:dir1/file1.txt --dry-run

A log from the command with the -vv flag (eg output from rclone -vv copy /tmp remote:tmp)

@ncw ncw added this to the Help Wanted milestone Jan 4, 2019

@kfur

This comment has been minimized.

Copy link
Contributor

kfur commented Jan 4, 2019

It seems it is being happened because we check --dry-run flag only in Rcat func when copyurl is using it only when size is unknown.

@ncw

This comment has been minimized.

Copy link
Owner

ncw commented Jan 4, 2019

It seems it is being happened because we check --dry-run flag only in Rcat func when copyurl is using it only when size is unknown.

Well spotted :-) Want to send in a fix?

@kfur

This comment has been minimized.

Copy link
Contributor

kfur commented Jan 4, 2019

Working on it

@kfur kfur referenced this issue Jan 4, 2019

Merged

cmd/copyurl: fix checking of --dry-run #2890

5 of 5 tasks complete
@ncw

This comment has been minimized.

Copy link
Owner

ncw commented Jan 8, 2019

@kfur - thanks for for fixing this.

I've merged the fix now - it will be in the latest beta in 15-30 mins and released in v1.46.

@ncw ncw closed this Jan 8, 2019

@ncw ncw modified the milestones: Help Wanted, v1.46 Jan 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment