New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update flag comment for checksum to avoid confusion #2903

Closed
calisro opened this Issue Jan 9, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@calisro
Copy link

calisro commented Jan 9, 2019

As seem here, there is always confusion on crypts about checksums and the --checksum flag which can cause people to believe its using checksum when they have in fact made things worst by disabling it.

https://forum.rclone.org/t/s3-takes-too-long-checksum-misses-excel-files/8269/6

Propose to change the descriptions like this:

-c, --checksum Skip based on checksum & size, not mod-time & size

to

-c, --checksum Skip based on checksum & size, not mod-time & size. If checksums don't exist(crypt), then just size.

Alternatively (or in addition to), warn the user in the log based on the remote.

@ncw ncw added bug doc fix labels Jan 9, 2019

@ncw ncw added this to the v1.46 milestone Jan 9, 2019

@ncw

This comment has been minimized.

Copy link
Owner

ncw commented Jan 9, 2019

Great idea

How about

-c, --checksum Skip based on checksum (if available) & size, not mod-time & size.

A warning in the log is a great idea, so if someone started a sync with --checksum on a remote with no hashes (or maybe with no hashes in common for the source and destination) it could log

--checksum in use but source and destination have no hashes in common - falling back to --size-only

Something like that?

This should probably be a NOTICE log level so it appears without -v.

Sound OK?

@calisro

This comment has been minimized.

Copy link

calisro commented Jan 9, 2019

I think that's perfect.

@ncw ncw closed this in ff72059 Jan 10, 2019

@ncw

This comment has been minimized.

Copy link
Owner

ncw commented Jan 10, 2019

I've done that now - find it in the latest beta in 15-30 mins and in 1.46 - thanks for suggesting it :-)

@calisro

This comment has been minimized.

Copy link

calisro commented Jan 10, 2019

Thanks as always

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment