Implement cleanup for other remotes #575

Open
ncw opened this Issue Jul 9, 2016 · 6 comments

Projects

None yet

3 participants

@ncw
Owner
ncw commented Jul 9, 2016 edited

Implement cleanup for remotes

  • amazonclouddrive
  • b2 - done in #462
  • drive
  • dropbox
  • googlecloudstorage - not possible
  • hubic - not possible
  • local - not possible
  • onedrive
  • s3 - not possible
  • swift - not possible
  • yandex
@ncw ncw added this to the Soon milestone Jul 9, 2016
@cederberg
Contributor

Trying v1.34 of rclone, I can't seem to get rclone cleanup to work properly against B2. The files remain listed (hidden) in the Backblaze file browser tool (web site).

Strangely, the hidden files do not show up when running rclone cleanup -v .... A guess might be that this is the root cause. Also tried with the --b2-versions flag, but to no avail.

@ncw
Owner
ncw commented Dec 2, 2016

@cederberg rclone cleanup should work properly with b2 now. Can you open a new issue with a log file and some instructions on how to reproduce please? I thought this might be related to #604 but I fixed that apparently!

@cederberg
Contributor

Hmm. Tried to reproduce, but now it works. Weird. The B2 web UI is sometimes slow, but shouldn't take several minutes to update... Hmm...

Ignore this for now. I'll file a proper bug if I see this again (and can repro the issue). Thanks for the quick support!

@ncw
Owner
ncw commented Dec 2, 2016

@cederberg might be caching I suppose... File a bug if you can reproduce it! Thanks, Nick

@eharris
eharris commented Dec 30, 2016

I haven't had a chance to dig into the code yet, but I'm wondering if cleanup is smart enough to only "cleanup" the files that rclone deleted, or if it does a whole-storage empty/purge? If the latter, I'm not sure I'd be comfortable with that without a pretty clear confirmation or --yes-really kind of option.

@ncw
Owner
ncw commented Dec 31, 2016

@eharris cleanup will do its stuff on all files, regardless of whether rclone deleted them. It should only remove already deleted files.

If the latter, I'm not sure I'd be comfortable with that without a pretty clear confirmation or --yes-really kind of option.

Lots of rclone commands can cause data loss if used incorrectly. The --dry-run option is for those cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment