Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zsh: sort the commands to keep a determinist output #3289

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@bmwiedemann
Copy link

commented Jun 24, 2019

Make the rclone package build reproducible

no

For background information see https://github.com/bmwiedemann/theunreproduciblepackage/tree/master/hash and https://reproducible-builds.org/

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

Based on spf13/cobra#801

Tested By: Bernhard M. Wiedemann

The alternative fix would be to update spf13/cobra - there this codepath has been rewritten.

zsh: sort the commands to keep a determinist output
from spf13/cobra#801

Tested By: Bernhard M. Wiedemann
@ncw

This comment has been minimized.

Copy link
Owner

commented Jun 25, 2019

I can't take patches to the vendor directory it will upset go modules no end :-(

Can you follow the procedure here please to pull the update from upstream: https://github.com/ncw/rclone/blob/master/CONTRIBUTING.md#updating-a-dependency

That will keep go modules happy.

If the cobra release isn't tagged yet then you'll need to add @master on the end, though I'd prefer a tagged version if possible.

Can you check in the changes plus the changes to go.mod and go.sums in in a single commit vendor: updated spf13/cobra to ...

Thanks

@bmwiedemann bmwiedemann referenced this pull request Jun 26, 2019

Closed

vendor: update github.com/spf13/cobra #3299

2 of 5 tasks complete
@bmwiedemann

This comment has been minimized.

Copy link
Author

commented Jun 28, 2019

Already solved by commit d61ba7e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.