Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koofr backend: support for setting modification times #3350

Merged
merged 2 commits into from Jul 24, 2019

Conversation

jkmcnk
Copy link
Contributor

@jkmcnk jkmcnk commented Jul 15, 2019

What is the purpose of this change?

Support for setting modification times on Koofr backend.

Was the change discussed in an issue or in the forum before?

No.

Checklist

  • I have read the contribution guidelines.
  • I have added tests for all changes in this PR if appropriate.
  • I have added documentation for the changes if appropriate.
  • All commit messages are in house style.
  • I'm done, this Pull Request is ready for review :-)

Configuration time option to disable the above for if using Dropbox (does not
allow setting mtime on copy) or Amazon Drive (neither on upload nor on copy).
@buengese
Copy link
Member

Could you explain a bit more how this works? What if the user answers the setmtime option wrong? Could this be detected automatically?

@jkmcnk
Copy link
Contributor Author

jkmcnk commented Jul 15, 2019

Could you explain a bit more how this works? What if the user answers the setmtime option wrong? Could this be detected automatically?

for this to be relevant, the user must meddle with the advanced options in the first place, to select a location that goes to a dropbox or amazon drive backed storage, and not to a Koofr-hosted one, so I don't find this such a problem. tbh, it could be detected automatically, but would require some network communication with the server just to return from the Precision() method: thus, I opted to avoid this.

@buengese
Copy link
Member

buengese commented Jul 15, 2019

I see looks fine to me but I think we're gonna wait for ncw to return from vacation before merging this.

@jkmcnk
Copy link
Contributor Author

jkmcnk commented Jul 16, 2019

I see looks fine to me but I think we're gonna wait for ncw to return from vacation before merging this.

ofc. we're in no hurry, but hopefully we get this merged in prior to next release.

@ncw
Copy link
Member

ncw commented Jul 22, 2019

I think this looks sound to me. Do the integration tests pass with and without the flag?

@jkmcnk
Copy link
Contributor Author

jkmcnk commented Jul 23, 2019

I think this looks sound to me. Do the integration tests pass with and without the flag?

yes. except for the obviously wrong case of declaring that the backend supports setting mtime while directing the files to a dropbox backend connected via koofr.

@ncw
Copy link
Member

ncw commented Jul 24, 2019

Great. The code for this looks good - will merge now :-)

@ncw ncw merged commit a35aa13 into rclone:master Jul 24, 2019
@ncw
Copy link
Member

ncw commented Jul 24, 2019

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants