Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal method Connection.storage() might use the wrong Connection.StorageUrl. #22

Closed
simonklee opened this issue Mar 9, 2014 · 4 comments
Assignees

Comments

@simonklee
Copy link

Connection.storage() makes a call to Connection.Call() passing Connection.StorageUrl. Connection.Call() might enter a re-authentication state, calling to Connection.Authenticate() which does overwrite the Connection.StorageUrl.
However, Connection.Call() will continue using the initially passed in storageUrl instead of the reading the value of Connection.StorageUrl.

The easiest way to reproduce this issue is to make any API request on a connection without first calling Authenticate().

@ncw ncw self-assigned this Mar 9, 2014
@ncw
Copy link
Owner

ncw commented Mar 9, 2014

Yes I agree.

I'll post a fix for you to try shortly

@ncw
Copy link
Owner

ncw commented Mar 9, 2014

Hopefully the above fixes your problem - let me know either way!

Thanks

@simonklee
Copy link
Author

Thanks Nick,

This seems to fix the problem. As a side effect it is no longer necessary to call Connection.Authenticate() before using a connection.

@ncw ncw closed this as completed in 9167af0 Mar 11, 2014
@ncw
Copy link
Owner

ncw commented Mar 11, 2014

Merged along with a comment about no longer having to call Authenticate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants