fixed text selection bug #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @TobiasBeck, thanks a lot for that. Could you rewrite your Git history so it uses semver. It's necessary for automatic library building. I wonder why the Git hooks doesn't alarm when you don't follow the schema (should be). But that's another topic. |
Contributor
Author
|
@ndabAP Hey yea, of course, I've never worked with that tool before, however, if I understand it right I need to prefix the comment with |
Owner
|
Yeah, exactly! Just |
Contributor
Author
|
Done. I've rewritten the commit. |
Owner
|
🎉 This PR is included in version 23.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a text selection bug where a user could not select text in the terminal.
This is really annoying as someone may like to copy the text a command returns to paste it somewhere else.
The solution is quite simple, It just checks now If the user selected anything
If it's not empty, setting the focus is skipped.
Tests still pass.