Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add stub support #62

Merged
merged 1 commit into from Dec 8, 2013

Conversation

Projects
None yet
4 participants
Contributor

aaronjensen commented Apr 7, 2013

stub was added in 2.2.0. It took me a while to figure out why it wasn't working when I realized it was effectively monkey patched out by turbo-sprockets-rails3. This adds it back in and bumps up the sprockets version dependency (which I realize may not be something you want to do). We could always detect support for it and optionally perform the stub removal.

Any reason why this is not taken along?

Owner

ndbroadbent commented Aug 16, 2013

Not sure how this affects compatibility with other versions of Rails 3.2. I think 3-2-stable is pegged to a lower version of sprockets, IIRC. Maybe the optional stub removal would be a better idea in that case.

Contributor

aaronjensen commented Aug 16, 2013

Regardless, I bumped the version in the turbo-sprockets-rails3 gemspec so people on older sprockets could still use the older version.

romanbsd commented Dec 8, 2013

Took me a while to understand, why my CSS is screwed up. This feature is absolutely required...

@ndbroadbent ndbroadbent added a commit that referenced this pull request Dec 8, 2013

@ndbroadbent ndbroadbent Merge pull request #62 from aaronjensen/add-stub-support
Add stub support
1ab6db2

@ndbroadbent ndbroadbent merged commit 1ab6db2 into ndbroadbent:master Dec 8, 2013

1 check passed

default The Travis build passed
Details
Owner

ndbroadbent commented Dec 8, 2013

Sorry for the huge delay, merged and pushed 0.3.11 to rubygems

romanbsd commented Dec 8, 2013

Awesome! 👍

Owner

ndbroadbent commented Dec 8, 2013

Please do let me know if you have any problems after updating

On Sun, Dec 8, 2013 at 1:18 PM, Roman Shterenzon
notifications@github.comwrote:

Awesome! [image: 👍]


Reply to this email directly or view it on GitHubhttps://github.com/ndbroadbent/turbo-sprockets-rails3/pull/62#issuecomment-30093128
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment