From 4104239939864ffb3be67550b397ff72ff1e4aed Mon Sep 17 00:00:00 2001 From: Nicholas Cunningham Date: Fri, 5 Nov 2021 13:28:10 -0600 Subject: [PATCH] fix(web): refactor line to add a guard instead for easier readability When a typescript webpack config file is provided as an option for the web build executor `nx run project:serve` will not fail because the file type is typescript. ISSUES CLOSED: #7454 --- packages/web/package.json | 1 + packages/web/src/utils/webpack/tsNodeRegister.ts | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/web/package.json b/packages/web/package.json index c57900d1e916b3..8281e1cfc32f6a 100644 --- a/packages/web/package.json +++ b/packages/web/package.json @@ -100,6 +100,7 @@ "terser": "4.3.8", "terser-webpack-plugin": "^5.1.1", "ts-loader": "^9.2.6", + "ts-node": "~9.1.1", "tsconfig-paths": "^3.9.0", "tsconfig-paths-webpack-plugin": "3.4.1", "tslib": "^2.0.0", diff --git a/packages/web/src/utils/webpack/tsNodeRegister.ts b/packages/web/src/utils/webpack/tsNodeRegister.ts index 6cfd836fc43854..c8739ce2003354 100644 --- a/packages/web/src/utils/webpack/tsNodeRegister.ts +++ b/packages/web/src/utils/webpack/tsNodeRegister.ts @@ -1,5 +1,5 @@ export function tsNodeRegister(file: string = '', tsConfig?: string) { - if (file && file.endsWith('.ts')) { + if (!file?.endsWith('.ts')) return; // Register TS compiler lazily require('ts-node').register({ project: tsConfig, @@ -16,5 +16,4 @@ export function tsNodeRegister(file: string = '', tsConfig?: string) { if (baseUrl && paths) { tsconfigPaths.register({ baseUrl, paths }); } - } }