New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to run hoogle server over TLS #156

Merged
merged 1 commit into from Feb 23, 2016

Conversation

Projects
None yet
2 participants
@kuk0
Contributor

kuk0 commented Feb 22, 2016

hoogle server --https --cert="my_cert.pem" --key="my_key.pem" serves the hoogle pages over TLS

tested with a self-generated certificate:
screen shot 2016-02-22 at 4 38 43 pm

  • are we worried about pulling in this dependency?
  • i have no idea whether this depends on particular versions of some packages
  • if this is useful, i can also modify hoogle5 to support https
, repeat_ :: Int
, queryChunks :: [String]
, queryParsed :: Either ParseError Query
, queryText :: String

This comment has been minimized.

@ndmitchell

ndmitchell Feb 23, 2016

Owner

Generally I prefer my indentation style as it was originally. Not too fussed for pushing onto the Hoogle 4 branch, more a note for anything you submit to Hoogle 5.

This comment has been minimized.

@kuk0

kuk0 Feb 23, 2016

Contributor

sure... Data and Convert below have the space so i thought i was keeping the style...

This comment has been minimized.

@ndmitchell

ndmitchell Feb 23, 2016

Owner

Ah, fair enough, I guess you are being tripped up by my past inconsistencies - can't ask for more than keeping the style consistent, whatever it might be!

@ndmitchell

This comment has been minimized.

Owner

ndmitchell commented Feb 23, 2016

Looks good to me - the dependency on warp-tls looks very minor, since all its dependencies are already dependencies of Hoogle, so the total increase in dependencies is small. A patch to Hoogle 5 would be most welcome.

ndmitchell added a commit that referenced this pull request Feb 23, 2016

Merge pull request #156 from kuk0/https
add option to run hoogle server over TLS

@ndmitchell ndmitchell merged commit 1e6009d into ndmitchell:hoogle4 Feb 23, 2016

0 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details

@kuk0 kuk0 deleted the kuk0:https branch Feb 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment