Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying any GitHub user and commit in travis.sh #40

Merged
merged 1 commit into from
May 19, 2018

Conversation

tomjaguarpaw
Copy link
Contributor

I would like to be able to use neil from my own GitHub repository. Furthermore I would like my packages to be able to specify a specific commit or branch to test with, firstly so that they don't have to be updated in lockstep with master and secondly to allow myself to test different versions of neil.

checkTravis expects a script stanza like this

- curl -sL https://raw.github.com/tomjaguarpaw/neil/<commit>/travis.sh | sh -s tomjaguarpaw <commit>

and it just checks that GitHub user name and commit match on both sides of the pipe.

@tomjaguarpaw
Copy link
Contributor Author

To preserve the old behaviour change your packages' travis.yml scripts from

- curl -sL https://raw.github.com/ndmitchell/neil/master/travis.sh | sh

to

- curl -sL https://raw.github.com/ndmitchell/neil/master/travis.sh | sh -s ndmitchell master

@ndmitchell
Copy link
Owner

I'd be a fan of defaulting to ndmitchell and master, but allowing this customisation - which seems entirely reasonable.

@tomjaguarpaw tomjaguarpaw force-pushed the github_user_commit branch 2 times, most recently from e6dbf41 to 04acf52 Compare May 19, 2018 08:45
@tomjaguarpaw
Copy link
Contributor Author

OK, my latest version defaults to ndmitchell and master so your existing travis.ymls don't need to change.

@ndmitchell ndmitchell merged commit 716c4b3 into ndmitchell:master May 19, 2018
@ndmitchell
Copy link
Owner

Thanks!

@ndmitchell
Copy link
Owner

I just followed up with a few cleanups to fix older GHC's and not require -s if you have no arguments.

@tomjaguarpaw
Copy link
Contributor Author

tomjaguarpaw commented May 19, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants