Correctly specify module name for 'shake' executable. #3

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

thoughtpolice commented Mar 18, 2013

This fixes a critical problem in the shake executable distributed with shake-0.10: it doesn't specify the correct module name for the Main module. Without this, the build fails like so:

$ cabal install -j1
Resolving dependencies...
Configuring shake-0.10...
Building shake-0.10...
Preprocessing executable 'shake' for shake-0.10...
[ 1 of 31] Compiling Paths_shake      ( dist/build/autogen/Paths_shake.hs, dist/build/shake/shake-tmp/Paths_shake.o )
...
[31 of 31] Compiling Development.Make.Main ( Development/Make/Main.hs, dist/build/shake/shake-tmp/Development/Make/Main.o )
Warning: output was redirected with -o, but no output will be generated
because there is no Main module.
Preprocessing library shake-0.10...
[ 1 of 27] Compiling Development.Shake.Errors ( Development/Shake/Errors.hs, dist/build/Development/Shake/Errors.o )
...
Documentation created: dist/doc/html/shake/index.html
Installing library in /home/a/.cabal/lib/shake-0.10/ghc-7.4.2
Installing executable(s) in /home/a/.cabal/bin
cabal: dist/build/shake/shake: does not exist
Failed to install shake-0.10
cabal: Error: some packages failed to install:
shake-0.10 failed during the final install step. The exception was:
ExitFailure 1
$ 

I'd suggest merging and releasing shake-0.11 ASAP.

@thoughtpolice thoughtpolice Correctly specify module name for 'shake' executable.
Signed-off-by: Austin Seipp <aseipp@pobox.com>
829519c
Owner

ndmitchell commented Mar 18, 2013

Thanks for the report. That fix doesn't work because in the test program (can be build with --flags=test-prog) I import that module by name. I'll do the full refactoring and move it so there is a shared module they import/reexport, but as a quick fix before I head into work, I've just added a ghc-options: -main-is flag, which on my machine works. Can you check that is enough for you? Released as version 0.10.1

Contributor

thoughtpolice commented Mar 18, 2013

Yep, fixed!

thoughtpolice deleted the unknown repository branch Mar 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment