From 4db83a574d96587dd59fcf1e2a8e9c4f7065c90e Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Fri, 22 Mar 2024 00:45:48 +0100 Subject: [PATCH 1/2] Test sanitizer --- .github/scripts/windows/build_task.bat | 1 + win32/build/confutils.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/.github/scripts/windows/build_task.bat b/.github/scripts/windows/build_task.bat index e8d84b8c0bfd6..ced53bc413feb 100644 --- a/.github/scripts/windows/build_task.bat +++ b/.github/scripts/windows/build_task.bat @@ -45,6 +45,7 @@ cmd /c configure.bat ^ --without-analyzer ^ --enable-object-out-dir=%PHP_BUILD_OBJ_DIR% ^ --with-php-build=%DEPS_DIR% ^ + --enable-sanitizer ^ %ADD_CONF% ^ --disable-test-ini if %errorlevel% neq 0 exit /b 3 diff --git a/win32/build/confutils.js b/win32/build/confutils.js index 1da17bddbd9fe..5bb7de836f289 100644 --- a/win32/build/confutils.js +++ b/win32/build/confutils.js @@ -3264,6 +3264,10 @@ function toolset_setup_common_cflags() ADD_FLAG('CFLAGS', ' /wd4996 '); } + if (PHP_SANITIZER == "yes") { + ADD_FLAG('CFLAGS', ' /fsanitize=address '); + } + if (PHP_DEBUG == "yes") { // Set some debug/release specific options ADD_FLAG('CFLAGS', ' /RTC1 '); From 508f5e907fbbfbc38df04e0113d681a99f6f5439 Mon Sep 17 00:00:00 2001 From: Niels Dossche <7771979+nielsdos@users.noreply.github.com> Date: Fri, 22 Mar 2024 00:54:12 +0100 Subject: [PATCH 2/2] fix? --- win32/build/confutils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win32/build/confutils.js b/win32/build/confutils.js index 5bb7de836f289..1021b9b225c9e 100644 --- a/win32/build/confutils.js +++ b/win32/build/confutils.js @@ -3265,7 +3265,7 @@ function toolset_setup_common_cflags() } if (PHP_SANITIZER == "yes") { - ADD_FLAG('CFLAGS', ' /fsanitize=address '); + ADD_FLAG('CFLAGS', ' /fsanitize=address /wd5072 '); } if (PHP_DEBUG == "yes") {